Spec PR - MSC4147: Including device keys with Olm-encrypted events #2122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Johannes Marbach <[email protected]>
Johennes
commented
Mar 28, 2025
| } | ||
| } | ||
| ``` | ||
| {{% definition path="api/client-server/definitions/olm_payload" %}} |
Contributor
Author
There was a problem hiding this comment.
I replaced the example with a schema because that allows us to reuse device_keys.yaml.
Member
There was a problem hiding this comment.
(and it's just generally Better. We're trying to phase out these old-style json blocks)
turt2live
changed the title
Member
|
(the notifications are really hard to distinguish when the spec PR and MSC share the same title) |
Contributor
Author
|
Sorry, I hadn't thought of this. Will keep it in mind for the future. |
richvdh
requested changes
May 13, 2025
| } | ||
| } | ||
| ``` | ||
| {{% definition path="api/client-server/definitions/olm_payload" %}} |
Member
There was a problem hiding this comment.
(and it's just generally Better. We're trying to phase out these old-style json blocks)
Johennes
commented
May 26, 2025
richvdh
requested changes
May 28, 2025
Member
richvdh
left a comment
richvdh
left a comment
There was a problem hiding this comment.
Looks better now, thanks. A few minor editorial nits.
Co-authored-by: Richard van der Hoff <[email protected]>
Co-authored-by: Richard van der Hoff <[email protected]>
Co-authored-by: Richard van der Hoff <[email protected]>
Johennes
commented
May 28, 2025
Johennes
added a commit
to Johennes/matrix-spec
that referenced
this pull request
May 30, 2025
…atrix-org#2122) Signed-off-by: Johannes Marbach <[email protected]> Co-authored-by: Richard van der Hoff <[email protected]>
This was referenced May 30, 2025
34 tasks
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec for MSC4147.
Pull Request Checklist
Preview: https://pr2122--matrix-spec-previews.netlify.app