Skip to content

Commit 15ee6d4

Browse files
matthiaskrgrmatthiaskrgr
authored
Rollup merge of rust-lang#89718 - jkugelman:must-use-is_condition-tests, r=joshtriplett
Add #[must_use] to is_condition tests There's nothing insightful to say about these so I didn't write any extra explanations. Parent issue: rust-lang#89692
2 parents 2679c9f + 475e992 commit 15ee6d4

File tree

12 files changed

+61
-0
lines changed

12 files changed

+61
-0
lines changed

‎library/alloc/src/collections/btree/set.rs‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -534,6 +534,7 @@ impl<T> BTreeSet<T> {
534534
/// b.insert(1);
535535
/// assert_eq!(a.is_disjoint(&b), false);
536536
/// ```
537+
#[must_use]
537538
#[stable(feature = "rust1", since = "1.0.0")]
538539
pub fn is_disjoint(&self, other: &BTreeSet<T>) -> bool
539540
where
@@ -559,6 +560,7 @@ impl<T> BTreeSet<T> {
559560
/// set.insert(4);
560561
/// assert_eq!(set.is_subset(&sup), false);
561562
/// ```
563+
#[must_use]
562564
#[stable(feature = "rust1", since = "1.0.0")]
563565
pub fn is_subset(&self, other: &BTreeSet<T>) -> bool
564566
where
@@ -638,6 +640,7 @@ impl<T> BTreeSet<T> {
638640
/// set.insert(2);
639641
/// assert_eq!(set.is_superset(&sub), true);
640642
/// ```
643+
#[must_use]
641644
#[stable(feature = "rust1", since = "1.0.0")]
642645
pub fn is_superset(&self, other: &BTreeSet<T>) -> bool
643646
where

‎library/core/src/char/methods.rs‎

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -692,6 +692,7 @@ impl char {
692692
/// // love is many things, but it is not alphabetic
693693
/// assert!(!c.is_alphabetic());
694694
/// ```
695+
#[must_use]
695696
#[stable(feature = "rust1", since = "1.0.0")]
696697
#[inline]
697698
pub fn is_alphabetic(self) -> bool {
@@ -724,6 +725,7 @@ impl char {
724725
/// assert!(!'中'.is_lowercase());
725726
/// assert!(!' '.is_lowercase());
726727
/// ```
728+
#[must_use]
727729
#[stable(feature = "rust1", since = "1.0.0")]
728730
#[inline]
729731
pub fn is_lowercase(self) -> bool {
@@ -756,6 +758,7 @@ impl char {
756758
/// assert!(!'中'.is_uppercase());
757759
/// assert!(!' '.is_uppercase());
758760
/// ```
761+
#[must_use]
759762
#[stable(feature = "rust1", since = "1.0.0")]
760763
#[inline]
761764
pub fn is_uppercase(self) -> bool {
@@ -784,6 +787,7 @@ impl char {
784787
///
785788
/// assert!(!'越'.is_whitespace());
786789
/// ```
790+
#[must_use]
787791
#[stable(feature = "rust1", since = "1.0.0")]
788792
#[inline]
789793
pub fn is_whitespace(self) -> bool {
@@ -812,6 +816,7 @@ impl char {
812816
/// assert!('و'.is_alphanumeric());
813817
/// assert!('藏'.is_alphanumeric());
814818
/// ```
819+
#[must_use]
815820
#[stable(feature = "rust1", since = "1.0.0")]
816821
#[inline]
817822
pub fn is_alphanumeric(self) -> bool {
@@ -837,6 +842,7 @@ impl char {
837842
/// assert!('œ'.is_control());
838843
/// assert!(!'q'.is_control());
839844
/// ```
845+
#[must_use]
840846
#[stable(feature = "rust1", since = "1.0.0")]
841847
#[inline]
842848
pub fn is_control(self) -> bool {
@@ -852,6 +858,7 @@ impl char {
852858
/// [uax29]: https://www.unicode.org/reports/tr29/
853859
/// [ucd]: https://www.unicode.org/reports/tr44/
854860
/// [`DerivedCoreProperties.txt`]: https://www.unicode.org/Public/UCD/latest/ucd/DerivedCoreProperties.txt
861+
#[must_use]
855862
#[inline]
856863
pub(crate) fn is_grapheme_extended(self) -> bool {
857864
unicode::Grapheme_Extend(self)
@@ -881,6 +888,7 @@ impl char {
881888
/// assert!(!'و'.is_numeric());
882889
/// assert!(!'藏'.is_numeric());
883890
/// ```
891+
#[must_use]
884892
#[stable(feature = "rust1", since = "1.0.0")]
885893
#[inline]
886894
pub fn is_numeric(self) -> bool {
@@ -1060,6 +1068,7 @@ impl char {
10601068
/// assert!(ascii.is_ascii());
10611069
/// assert!(!non_ascii.is_ascii());
10621070
/// ```
1071+
#[must_use]
10631072
#[stable(feature = "ascii_methods_on_intrinsics", since = "1.23.0")]
10641073
#[rustc_const_stable(feature = "const_ascii_methods_on_intrinsics", since = "1.32.0")]
10651074
#[inline]
@@ -1237,6 +1246,7 @@ impl char {
12371246
/// assert!(!lf.is_ascii_alphabetic());
12381247
/// assert!(!esc.is_ascii_alphabetic());
12391248
/// ```
1249+
#[must_use]
12401250
#[stable(feature = "ascii_ctype_on_intrinsics", since = "1.24.0")]
12411251
#[rustc_const_stable(feature = "const_ascii_ctype_on_intrinsics", since = "1.47.0")]
12421252
#[inline]
@@ -1270,6 +1280,7 @@ impl char {
12701280
/// assert!(!lf.is_ascii_uppercase());
12711281
/// assert!(!esc.is_ascii_uppercase());
12721282
/// ```
1283+
#[must_use]
12731284
#[stable(feature = "ascii_ctype_on_intrinsics", since = "1.24.0")]
12741285
#[rustc_const_stable(feature = "const_ascii_ctype_on_intrinsics", since = "1.47.0")]
12751286
#[inline]
@@ -1303,6 +1314,7 @@ impl char {
13031314
/// assert!(!lf.is_ascii_lowercase());
13041315
/// assert!(!esc.is_ascii_lowercase());
13051316
/// ```
1317+
#[must_use]
13061318
#[stable(feature = "ascii_ctype_on_intrinsics", since = "1.24.0")]
13071319
#[rustc_const_stable(feature = "const_ascii_ctype_on_intrinsics", since = "1.47.0")]
13081320
#[inline]
@@ -1339,6 +1351,7 @@ impl char {
13391351
/// assert!(!lf.is_ascii_alphanumeric());
13401352
/// assert!(!esc.is_ascii_alphanumeric());
13411353
/// ```
1354+
#[must_use]
13421355
#[stable(feature = "ascii_ctype_on_intrinsics", since = "1.24.0")]
13431356
#[rustc_const_stable(feature = "const_ascii_ctype_on_intrinsics", since = "1.47.0")]
13441357
#[inline]
@@ -1372,6 +1385,7 @@ impl char {
13721385
/// assert!(!lf.is_ascii_digit());
13731386
/// assert!(!esc.is_ascii_digit());
13741387
/// ```
1388+
#[must_use]
13751389
#[stable(feature = "ascii_ctype_on_intrinsics", since = "1.24.0")]
13761390
#[rustc_const_stable(feature = "const_ascii_ctype_on_intrinsics", since = "1.47.0")]
13771391
#[inline]
@@ -1408,6 +1422,7 @@ impl char {
14081422
/// assert!(!lf.is_ascii_hexdigit());
14091423
/// assert!(!esc.is_ascii_hexdigit());
14101424
/// ```
1425+
#[must_use]
14111426
#[stable(feature = "ascii_ctype_on_intrinsics", since = "1.24.0")]
14121427
#[rustc_const_stable(feature = "const_ascii_ctype_on_intrinsics", since = "1.47.0")]
14131428
#[inline]
@@ -1445,6 +1460,7 @@ impl char {
14451460
/// assert!(!lf.is_ascii_punctuation());
14461461
/// assert!(!esc.is_ascii_punctuation());
14471462
/// ```
1463+
#[must_use]
14481464
#[stable(feature = "ascii_ctype_on_intrinsics", since = "1.24.0")]
14491465
#[rustc_const_stable(feature = "const_ascii_ctype_on_intrinsics", since = "1.47.0")]
14501466
#[inline]
@@ -1478,6 +1494,7 @@ impl char {
14781494
/// assert!(!lf.is_ascii_graphic());
14791495
/// assert!(!esc.is_ascii_graphic());
14801496
/// ```
1497+
#[must_use]
14811498
#[stable(feature = "ascii_ctype_on_intrinsics", since = "1.24.0")]
14821499
#[rustc_const_stable(feature = "const_ascii_ctype_on_intrinsics", since = "1.47.0")]
14831500
#[inline]
@@ -1528,6 +1545,7 @@ impl char {
15281545
/// assert!(lf.is_ascii_whitespace());
15291546
/// assert!(!esc.is_ascii_whitespace());
15301547
/// ```
1548+
#[must_use]
15311549
#[stable(feature = "ascii_ctype_on_intrinsics", since = "1.24.0")]
15321550
#[rustc_const_stable(feature = "const_ascii_ctype_on_intrinsics", since = "1.47.0")]
15331551
#[inline]
@@ -1563,6 +1581,7 @@ impl char {
15631581
/// assert!(lf.is_ascii_control());
15641582
/// assert!(esc.is_ascii_control());
15651583
/// ```
1584+
#[must_use]
15661585
#[stable(feature = "ascii_ctype_on_intrinsics", since = "1.24.0")]
15671586
#[rustc_const_stable(feature = "const_ascii_ctype_on_intrinsics", since = "1.47.0")]
15681587
#[inline]

‎library/core/src/num/f32.rs‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -436,6 +436,7 @@ impl f32 {
436436
/// assert!(nan.is_nan());
437437
/// assert!(!f.is_nan());
438438
/// ```
439+
#[must_use]
439440
#[stable(feature = "rust1", since = "1.0.0")]
440441
#[rustc_const_unstable(feature = "const_float_classify", issue = "72505")]
441442
#[inline]
@@ -467,6 +468,7 @@ impl f32 {
467468
/// assert!(inf.is_infinite());
468469
/// assert!(neg_inf.is_infinite());
469470
/// ```
471+
#[must_use]
470472
#[stable(feature = "rust1", since = "1.0.0")]
471473
#[rustc_const_unstable(feature = "const_float_classify", issue = "72505")]
472474
#[inline]
@@ -488,6 +490,7 @@ impl f32 {
488490
/// assert!(!inf.is_finite());
489491
/// assert!(!neg_inf.is_finite());
490492
/// ```
493+
#[must_use]
491494
#[stable(feature = "rust1", since = "1.0.0")]
492495
#[rustc_const_unstable(feature = "const_float_classify", issue = "72505")]
493496
#[inline]
@@ -515,6 +518,7 @@ impl f32 {
515518
/// assert!(lower_than_min.is_subnormal());
516519
/// ```
517520
/// [subnormal]: https://en.wikipedia.org/wiki/Denormal_number
521+
#[must_use]
518522
#[stable(feature = "is_subnormal", since = "1.53.0")]
519523
#[rustc_const_unstable(feature = "const_float_classify", issue = "72505")]
520524
#[inline]
@@ -541,6 +545,7 @@ impl f32 {
541545
/// assert!(!lower_than_min.is_normal());
542546
/// ```
543547
/// [subnormal]: https://en.wikipedia.org/wiki/Denormal_number
548+
#[must_use]
544549
#[stable(feature = "rust1", since = "1.0.0")]
545550
#[rustc_const_unstable(feature = "const_float_classify", issue = "72505")]
546551
#[inline]
@@ -587,6 +592,7 @@ impl f32 {
587592
/// assert!(f.is_sign_positive());
588593
/// assert!(!g.is_sign_positive());
589594
/// ```
595+
#[must_use]
590596
#[stable(feature = "rust1", since = "1.0.0")]
591597
#[rustc_const_unstable(feature = "const_float_classify", issue = "72505")]
592598
#[inline]
@@ -604,6 +610,7 @@ impl f32 {
604610
/// assert!(!f.is_sign_negative());
605611
/// assert!(g.is_sign_negative());
606612
/// ```
613+
#[must_use]
607614
#[stable(feature = "rust1", since = "1.0.0")]
608615
#[rustc_const_unstable(feature = "const_float_classify", issue = "72505")]
609616
#[inline]

‎library/core/src/num/f64.rs‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -435,6 +435,7 @@ impl f64 {
435435
/// assert!(nan.is_nan());
436436
/// assert!(!f.is_nan());
437437
/// ```
438+
#[must_use]
438439
#[stable(feature = "rust1", since = "1.0.0")]
439440
#[rustc_const_unstable(feature = "const_float_classify", issue = "72505")]
440441
#[inline]
@@ -466,6 +467,7 @@ impl f64 {
466467
/// assert!(inf.is_infinite());
467468
/// assert!(neg_inf.is_infinite());
468469
/// ```
470+
#[must_use]
469471
#[stable(feature = "rust1", since = "1.0.0")]
470472
#[rustc_const_unstable(feature = "const_float_classify", issue = "72505")]
471473
#[inline]
@@ -487,6 +489,7 @@ impl f64 {
487489
/// assert!(!inf.is_finite());
488490
/// assert!(!neg_inf.is_finite());
489491
/// ```
492+
#[must_use]
490493
#[stable(feature = "rust1", since = "1.0.0")]
491494
#[rustc_const_unstable(feature = "const_float_classify", issue = "72505")]
492495
#[inline]
@@ -514,6 +517,7 @@ impl f64 {
514517
/// assert!(lower_than_min.is_subnormal());
515518
/// ```
516519
/// [subnormal]: https://en.wikipedia.org/wiki/Denormal_number
520+
#[must_use]
517521
#[stable(feature = "is_subnormal", since = "1.53.0")]
518522
#[rustc_const_unstable(feature = "const_float_classify", issue = "72505")]
519523
#[inline]
@@ -540,6 +544,7 @@ impl f64 {
540544
/// assert!(!lower_than_min.is_normal());
541545
/// ```
542546
/// [subnormal]: https://en.wikipedia.org/wiki/Denormal_number
547+
#[must_use]
543548
#[stable(feature = "rust1", since = "1.0.0")]
544549
#[rustc_const_unstable(feature = "const_float_classify", issue = "72505")]
545550
#[inline]
@@ -586,13 +591,15 @@ impl f64 {
586591
/// assert!(f.is_sign_positive());
587592
/// assert!(!g.is_sign_positive());
588593
/// ```
594+
#[must_use]
589595
#[stable(feature = "rust1", since = "1.0.0")]
590596
#[rustc_const_unstable(feature = "const_float_classify", issue = "72505")]
591597
#[inline]
592598
pub const fn is_sign_positive(self) -> bool {
593599
!self.is_sign_negative()
594600
}
595601

602+
#[must_use]
596603
#[stable(feature = "rust1", since = "1.0.0")]
597604
#[rustc_deprecated(since = "1.0.0", reason = "renamed to is_sign_positive")]
598605
#[inline]
@@ -611,13 +618,15 @@ impl f64 {
611618
/// assert!(!f.is_sign_negative());
612619
/// assert!(g.is_sign_negative());
613620
/// ```
621+
#[must_use]
614622
#[stable(feature = "rust1", since = "1.0.0")]
615623
#[rustc_const_unstable(feature = "const_float_classify", issue = "72505")]
616624
#[inline]
617625
pub const fn is_sign_negative(self) -> bool {
618626
self.to_bits() & 0x8000_0000_0000_0000 != 0
619627
}
620628

629+
#[must_use]
621630
#[stable(feature = "rust1", since = "1.0.0")]
622631
#[rustc_deprecated(since = "1.0.0", reason = "renamed to is_sign_negative")]
623632
#[inline]

‎library/core/src/num/int_macros.rs‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2502,6 +2502,7 @@ macro_rules! int_impl {
25022502
#[doc = concat!("assert!(10", stringify!($SelfT), ".is_positive());")]
25032503
#[doc = concat!("assert!(!(-10", stringify!($SelfT), ").is_positive());")]
25042504
/// ```
2505+
#[must_use]
25052506
#[stable(feature = "rust1", since = "1.0.0")]
25062507
#[rustc_const_stable(feature = "const_int_methods", since = "1.32.0")]
25072508
#[inline(always)]
@@ -2518,6 +2519,7 @@ macro_rules! int_impl {
25182519
#[doc = concat!("assert!((-10", stringify!($SelfT), ").is_negative());")]
25192520
#[doc = concat!("assert!(!10", stringify!($SelfT), ".is_negative());")]
25202521
/// ```
2522+
#[must_use]
25212523
#[stable(feature = "rust1", since = "1.0.0")]
25222524
#[rustc_const_stable(feature = "const_int_methods", since = "1.32.0")]
25232525
#[inline(always)]

0 commit comments

Comments
 (0)