Rollup merge of rust-lang#94948 - jhpratt:rustc_deprecated, r=Dylan-DPC

matthiaskrgr · web-flow · commit 780083a4ab6f · 2022-03-19T23:36:43.000+01:00
Fix diagnostics for `#![feature(deprecated_suggestion)]` Follow up from rust-lang#94635, where I missed a couple things.
diff --git a/compiler/rustc_attr/src/builtin.rs b/compiler/rustc_attr/src/builtin.rs
@@ -758,8 +758,7 @@ where
                                     if sess.is_nightly_build() {
                                         diag.help("add `#![feature(deprecated_suggestion)]` to the crate root");
                                     }
-                                    // FIXME(jhpratt) change this to an actual tracking issue
-                                    diag.note("see #XXX for more details").emit();
+                                    diag.note("see #94785 for more details").emit();
                                 }
 
                                 if !get(mi, &mut suggestion) {
@@ -772,10 +771,10 @@ where
                                     meta.span(),
                                     AttrError::UnknownMetaItem(
                                         pprust::path_to_string(&mi.path),
-                                        if attr.has_name(sym::deprecated) {
-                                            &["since", "note"]
-                                        } else {
+                                        if sess.features_untracked().deprecated_suggestion {
                                             &["since", "note", "suggestion"]
+                                        } else {
+                                            &["since", "note"]
                                         },
                                     ),
                                 );
diff --git a/src/test/ui/deprecation/feature-gate-deprecated_suggestion.stderr b/src/test/ui/deprecation/feature-gate-deprecated_suggestion.stderr
@@ -5,7 +5,7 @@ LL | #[deprecated(suggestion = "foo")]
    |              ^^^^^^^^^^^^^^^^^^
    |
    = help: add `#![feature(deprecated_suggestion)]` to the crate root
-   = note: see #XXX for more details
+   = note: see #94785 for more details
 
 error: aborting due to previous error
 

Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@ LL \| #[deprecated(suggestion = "foo")]`
`5`	`5`	`\| ^^^^^^^^^^^^^^^^^^`
`6`	`6`	`\|`
`7`	`7`	= help: add `#![feature(deprecated_suggestion)]` to the crate root
`8`		`- = note: see #XXX for more details`
	`8`	`+ = note: see #94785 for more details`
`9`	`9`
`10`	`10`	`error: aborting due to previous error`
`11`	`11`