Remove unused room from AESKEY variable #608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original LMIC AES implementation uses this variable to store 10x16 bytes of round keys, but for the other implementations (only IDEETRON right now) this is only used to store the main key. In the latter case, this variable only needs to be 16 bytes long, saving 160 bytes of RAM.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original LMIC AES implementation uses this variable to store
10x16 bytes of round keys, but for the other implementations (only
IDEETRON right now) this is only used to store the main key. In the
latter case, this variable only needs to be 16 bytes long, saving 160
bytes of RAM.
This commit has been part of my arduino-lmic version since 2017, but seems it was never ported to this version.