Include workflow name as input for action ReadSetting

[OleWunschmann]

We would like to use the action ReadSettings in a custom job to read the settings of another workflow.
The function ReadSettings already contains the parameter for the workflow name.
So could the action be extended with an input for the workflow name?

[aholstrup1]

Hi @OleWunschmann. Before we consider whether this is something we want to do, could you explain what your scenario is and what it is you're trying to achieve?

[OleWunschmann]

Hi @aholstrup1, thanks for your reply.

We have a customized template for COSMO Alpaca and would like to create a custom workflow (sorry not just a custom job) that can be dispatched to create a COSMO Alpaca container based on the settings of another workflow (e.g. "CI/CD", "Test Current", "Test Next Minor", Test Next Major").
For this we would like to use the existing action ReadSettings to read the respective settings and determine the artifact url based on these settings.

In our opinion, this would be the cleanest solution, but we have also considered other solutions:

• New setting that allows to inherit/include other settings (e.g. from other workflows or even projects)
• Download/checkout the file "./Actions/.Modules/ReadSettings.psm1" from the AL-Go repository and use the function ReadSettings directly
  Pro: Requires no changes to AL-Go
• Define the same settings as conditional settings for custom BuildModes.
  Pro: Requires no changes to AL-Go
  Con: Results in redundant settings.

[OleWunschmann]

If you agree with the solution, then I'm happy to contribute it.

[aholstrup1]

Just to make sure I have the correct understanding

The solution you're suggesting is:

• Add workflow name as an input to the action here:

  AL-Go/Actions/ReadSettings/action.yaml

  Lines 4 to 15 in e3ae9e0

  	shell:
  	description: Shell in which you want to run the action (powershell or pwsh)
  	required: false
  	default: powershell
  	project:
  	description: Project folder
  	required: false
  	default: '.'
  	buildMode:
  	description: Build mode
  	required: false
  	default: 'Default'

• Add workflow name as a parameter here:

  AL-Go/Actions/ReadSettings/ReadSettings.ps1

  Lines 2 to 7 in e3ae9e0

  	[Parameter(HelpMessage = "Project folder", Mandatory = $false)]
  	[string] $project = ".",
  	[Parameter(HelpMessage = "Build mode", Mandatory = $false)]
  	[string] $buildMode = "Default",
  	[Parameter(HelpMessage = "Specifies which properties to get from the settings file, default is all", Mandatory = $false)]
  	[string] $get = ""

• Pass the workflow name here:

  AL-Go/Actions/ReadSettings/ReadSettings.ps1

  Line 12 in e3ae9e0

  $settings = ReadSettings -project $project -buildMode $buildMode

That way you can call the ReadSettings action with the workflow name as a parameter. That's what you're suggesting right? If so, I agree 🚀 Just make sure the new input parameter defaults to the current workflow name so it doesn't break any existing functionality.

[OleWunschmann]

You understood that correctly, and I already had the default value for the input parameter in mind 👍

[OleWunschmann]

@aholstrup1 I created the pull request #1888. I'm open to feedback regarding my contribution.

[aholstrup1]

Thank you for the contribution @OleWunschmann. We'll get the change deployed to preview in the coming days