Implement ICloneable semantically for deep cloning

Author: MaggieKimani1

src/Microsoft.OpenApi/Models/OpenApiCallback.cs

@@ -34,21 +34,19 @@ public class OpenApiCallback : IOpenApiSerializable, IOpenApiReferenceable, IOpe
         /// This object MAY be extended with Specification Extensions.
         /// </summary>
         public IDictionary<string, IOpenApiExtension> Extensions { get; set; } = new Dictionary<string, IOpenApiExtension>();
-
-        /// <summary>
-        /// Parameter-less constructor
-        /// </summary>
-        public OpenApiCallback() { }
-
+        
         /// <summary>
         /// Initializes a copy of an <see cref="OpenApiCallback"/> object
         /// </summary>
-        public OpenApiCallback(OpenApiCallback callback)
+        public object Clone()
         {
-            PathItems = callback.PathItems;
-            UnresolvedReference = callback.UnresolvedReference;
-            Reference = callback.Reference;
-            Extensions = callback.Extensions;
+            return new OpenApiCallback
+            {
+                PathItems = PathItems,
+                UnresolvedReference = UnresolvedReference,
+                Reference = Reference,
+                Extensions = Extensions
+            };
         }
 
         /// <summary>

src/Microsoft.OpenApi/Models/OpenApiComponents.cs

@@ -68,26 +68,24 @@ public class OpenApiComponents : IOpenApiSerializable, IOpenApiExtensible
         /// </summary>
         public IDictionary<string, IOpenApiExtension> Extensions { get; set; } = new Dictionary<string, IOpenApiExtension>();
 
-        /// <summary>
-        /// Parameter-less constructor
-        /// </summary>
-        public OpenApiComponents() { }
-
         /// <summary>
         /// Initializes a copy of an <see cref="OpenApiComponents"/> object
         /// </summary>
-        public OpenApiComponents(OpenApiComponents components)
+        public object Clone()
         {
-            Schemas = components.Schemas;
-            Responses = components.Responses;
-            Parameters = components.Parameters;
-            Examples = components.Examples;
-            RequestBodies = components.RequestBodies;
-            Headers = components.Headers;
-            SecuritySchemes = components.SecuritySchemes;
-            Links = components.Links;
-            Callbacks = components.Callbacks;
-            Extensions = components.Extensions;
+            return new OpenApiComponents
+            {
+                Schemas = Schemas,
+                Responses = Responses,
+                Parameters = Parameters,
+                Examples = Examples,
+                RequestBodies = RequestBodies,
+                Headers = Headers,
+                SecuritySchemes = SecuritySchemes,
+                Links = Links,
+                Callbacks = Callbacks,
+                Extensions = Extensions
+            };            
         }
 
         /// <summary>

src/Microsoft.OpenApi/Models/OpenApiContact.cs

@@ -35,22 +35,20 @@ public class OpenApiContact : IOpenApiSerializable, IOpenApiExtensible
         /// </summary>
         public IDictionary<string, IOpenApiExtension> Extensions { get; set; } = new Dictionary<string, IOpenApiExtension>();
 
-        /// <summary>
-        /// Parameter-less constructor
-        /// </summary>
-        public OpenApiContact() { }
-
         /// <summary>
         /// Initializes a copy of an <see cref="OpenApiContact"/> instance
         /// </summary>
-        public OpenApiContact(OpenApiContact contact)
+        public object Clone()
         {
-            Name = contact.Name;
-            Url = contact.Url;
-            Email = contact.Email;
-            Extensions = contact.Extensions;
+            return new OpenApiContact
+            {
+                Name = Name.Clone() as string,
+                Url = Url,
+                Email = Email.Clone() as string,
+                Extensions = Extensions
+            };           
         }
-
+        
         /// <summary>
         /// Serialize <see cref="OpenApiContact"/> to Open Api v3.0
         /// </summary>

src/Microsoft.OpenApi/Models/OpenApiDiscriminator.cs

@@ -22,18 +22,16 @@ public class OpenApiDiscriminator : IOpenApiSerializable
         /// </summary>
         public IDictionary<string, string> Mapping { get; set; } = new Dictionary<string, string>();
 
-        /// <summary>
-        /// Parameter-less constructor
-        /// </summary>
-        public OpenApiDiscriminator() { }
-
         /// <summary>
         /// Initializes a copy of an <see cref="OpenApiDiscriminator"/> instance
         /// </summary>
-        public OpenApiDiscriminator(OpenApiDiscriminator discriminator)
+        public object Clone()
         {
-            PropertyName = discriminator.PropertyName;
-            Mapping = discriminator.Mapping;
+            return new OpenApiDiscriminator
+            {
+                PropertyName = PropertyName.Clone() as string,
+                Mapping = Mapping
+            };
         }
 
         /// <summary>

src/Microsoft.OpenApi/Models/OpenApiDocument.cs

@@ -70,17 +70,19 @@ public OpenApiDocument() {}
         /// <summary>
         /// Initializes a copy of an an <see cref="OpenApiDocument"/> object
         /// </summary>
-        public OpenApiDocument(OpenApiDocument document)
+        public object Clone()
         {
-            Workspace = document.Workspace;
-            Info = document.Info;
-            Servers = document.Servers;
-            Paths = document.Paths;
-            Components = document.Components;
-            SecurityRequirements = document.SecurityRequirements;
-            Tags = document.Tags;
-            ExternalDocs = document.ExternalDocs;
-            Extensions = document.Extensions;
+            return new OpenApiDocument
+            {
+                Workspace = Workspace,
+                Info = Info,
+                Servers = Servers,
+                Components = Components,
+                SecurityRequirements = SecurityRequirements,
+                Tags = Tags,
+                ExternalDocs = ExternalDocs,
+                Extensions = Extensions
+            };            
         }
 
         /// <summary>

src/Microsoft.OpenApi/Models/OpenApiEncoding.cs

@@ -53,22 +53,20 @@ public class OpenApiEncoding : IOpenApiSerializable, IOpenApiExtensible
         /// </summary>
         public IDictionary<string, IOpenApiExtension> Extensions { get; set; } = new Dictionary<string, IOpenApiExtension>();
 
-        /// <summary>
-        /// Parameter-less constructor
-        /// </summary>
-        public OpenApiEncoding() {}
-
         /// <summary>
         /// Initializes a copy of an <see cref="OpenApiEncoding"/> object
         /// </summary>
-        public OpenApiEncoding(OpenApiEncoding encoding)
+        public object Clone()
         {
-            ContentType = encoding.ContentType;
-            Headers = encoding.Headers;
-            Style = encoding.Style;
-            Explode = encoding.Explode;
-            AllowReserved = encoding.AllowReserved;
-            Extensions = encoding.Extensions;
+            return new OpenApiEncoding
+            {
+                ContentType = ContentType.Clone() as string,
+                Headers = Headers,
+                Style = Style,
+                Explode = Explode,
+                AllowReserved = AllowReserved,
+                Extensions = Extensions
+            };
         }
 
         /// <summary>

src/Microsoft.OpenApi/Models/OpenApiExample.cs

@@ -54,23 +54,21 @@ public class OpenApiExample : IOpenApiSerializable, IOpenApiReferenceable, IOpen
         /// </summary>
         public bool UnresolvedReference { get; set; } = false;
 
-        /// <summary>
-        /// Parameter-less constructor
-        /// </summary>
-        public OpenApiExample() {}
-
         /// <summary>
         /// Initializes a copy of <see cref="OpenApiExample"/> object
         /// </summary>
-        public OpenApiExample(OpenApiExample example)
+        public object Clone()
         {
-            Summary = example.Summary;
-            Description = example.Description;
-            Value = example.Value;
-            ExternalValue = example.ExternalValue;
-            Extensions = example.Extensions;
-            Reference = example.Reference;
-            UnresolvedReference = example.UnresolvedReference;
+            return new OpenApiExample
+            {
+                Summary = Summary,
+                Description = Description,
+                Value = Value,
+                ExternalValue = ExternalValue,
+                Extensions = Extensions,
+                Reference = Reference,
+                UnresolvedReference = UnresolvedReference
+            };
         }
 
         /// <summary>

src/Microsoft.OpenApi/Models/OpenApiExternalDocs.cs

@@ -29,19 +29,17 @@ public class OpenApiExternalDocs : IOpenApiSerializable, IOpenApiExtensible
         /// </summary>
         public IDictionary<string, IOpenApiExtension> Extensions { get; set; } = new Dictionary<string, IOpenApiExtension>();
 
-        /// <summary>
-        /// Parameter-less constructor
-        /// </summary>
-        public OpenApiExternalDocs() {}
-
         /// <summary>
         /// Initializes a copy of an <see cref="OpenApiExternalDocs"/> object
         /// </summary>
-        public OpenApiExternalDocs(OpenApiExternalDocs externalDocs)
+        public Object Clone()
         {
-            Description = externalDocs.Description;
-            Url = externalDocs.Url;
-            Extensions = externalDocs.Extensions;
+            return new OpenApiExternalDocs
+            {
+                Description = Description.Clone() as string,
+                Url = Url,
+                Extensions = Extensions
+            };
         }
 
         /// <summary>

src/Microsoft.OpenApi/Models/OpenApiHeader.cs

@@ -1,6 +1,7 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT license. 
 
+using System;
 using System.Collections.Generic;
 using Microsoft.OpenApi.Any;
 using Microsoft.OpenApi.Extensions;
@@ -86,30 +87,28 @@ public class OpenApiHeader : IOpenApiSerializable, IOpenApiReferenceable, IOpenA
         /// </summary>
         public IDictionary<string, IOpenApiExtension> Extensions { get; set; } = new Dictionary<string, IOpenApiExtension>();
 
-        /// <summary>
-        /// Parameter-less constructor
-        /// </summary>
-        public OpenApiHeader() {}
-
         /// <summary>
         /// Initializes a copy of an <see cref="OpenApiHeader"/> object
         /// </summary>
-        public OpenApiHeader(OpenApiHeader header)
+        public Object Clone()
         {
-            UnresolvedReference = header.UnresolvedReference;
-            Reference = header.Reference;
-            Description = header.Description;
-            Required = header.Required;
-            Deprecated = header.Deprecated;
-            AllowEmptyValue = header.AllowEmptyValue;
-            Style = header.Style;
-            Explode = header.Explode;
-            AllowReserved = header.AllowReserved;
-            Schema = header.Schema;
-            Example = header.Example;
-            Examples = header.Examples;
-            Content = header.Content;
-            Extensions = header.Extensions;
+            return new OpenApiHeader
+            {
+                UnresolvedReference = UnresolvedReference,
+                Reference = Reference,
+                Description = Description.Clone() as string,
+                Required = Required,
+                Deprecated = Deprecated,
+                AllowEmptyValue = AllowEmptyValue,
+                Style = Style,
+                Explode = Explode,
+                AllowReserved = AllowReserved,
+                Schema = Schema,
+                Example = Example,
+                Examples = Examples,
+                Content = Content,
+                Extensions = Extensions
+            };
         }
 
         /// <summary>

src/Microsoft.OpenApi/Models/OpenApiInfo.cs

@@ -49,23 +49,21 @@ public class OpenApiInfo : IOpenApiSerializable, IOpenApiExtensible
         /// </summary>
         public IDictionary<string, IOpenApiExtension> Extensions { get; set; } = new Dictionary<string, IOpenApiExtension>();
 
-        /// <summary>
-        /// Parameter-less constructor
-        /// </summary>
-        public OpenApiInfo() {}
-
         /// <summary>
         /// Initializes a copy of an <see cref="OpenApiInfo"/> object
         /// </summary>
-        public OpenApiInfo(OpenApiInfo info)
+        public Object Clone()
         {
-            Title = info.Title;
-            Description = info.Description;
-            Version = info.Version;
-            TermsOfService = info.TermsOfService;
-            Contact = info.Contact;
-            License = info.License;
-            Extensions = info.Extensions;
+            return new OpenApiInfo
+            {
+                Title = Title.Clone() as string,
+                Description = Description.Clone() as string,
+                Version = Version.Clone() as string,
+                TermsOfService = TermsOfService,
+                Contact = Contact,
+                License = License,
+                Extensions = Extensions
+            };            
         }
 
         /// <summary>