introduces Response.json() static method #1462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
Contributor
Author
|
@microsoft-github-policy-service agree company="Vercel" |
5 tasks
feugy
force-pushed
the
feat/response-json-static
branch
from
bac9b4a to
d18f1a8
Compare
feugy
force-pushed
the
feat/response-json-static
branch
from
d18f1a8 to
f542c4a
Compare
regseb
reviewed
Jun 2, 2023
Contributor
Author
|
@HolgerJeromin, I've re-based this PR since this static method has been implemented on Firefox, and is planned in release 115. Despite the fact that is it not implemented in the MDN documentation yet, it is fully specified in the fetch spec. I hope we can now consider adding it to Typescript types. |
Contributor
|
Thanks, I think we can have this now. The wrong URL is IMO tolerable, LGTM |
Contributor
|
Merging because @saschanaz is a code-owner of all the changes - thanks! |
Contributor
Author
|
Thanks a mil! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📖 What's in there?
A new method has been added: static Response.json(data, init) to create a response that contains JSON (not to be confused with Response.prototype.json()).
All the details are in #1444