Ensure duplicate let/const declarations accross files are reported

Author: mhegazy

src/compiler/checker.ts

@@ -172,6 +172,7 @@ module ts {
 
         function getExcludedSymbolFlags(flags: SymbolFlags): SymbolFlags {
             var result: SymbolFlags = 0;
+            if (flags & SymbolFlags.BlockScoped) result |= SymbolFlags.BlockScopedExcludes;
             if (flags & SymbolFlags.Variable) result |= SymbolFlags.VariableExcludes;
             if (flags & SymbolFlags.Property) result |= SymbolFlags.PropertyExcludes;
             if (flags & SymbolFlags.EnumMember) result |= SymbolFlags.EnumMemberExcludes;

tests/baselines/reference/letDeclarations-scopes-duplicates2.errors.txt

@@ -0,0 +1,11 @@
+tests/cases/compiler/file2.ts(1,5): error TS2300: Duplicate identifier 'var1'.
+
+
+==== tests/cases/compiler/file1.ts (0 errors) ====
+    
+    let var1 = 0;
+    
+==== tests/cases/compiler/file2.ts (1 errors) ====
+    let var1 = 0;
+        ~~~~
+!!! error TS2300: Duplicate identifier 'var1'.

tests/baselines/reference/letDeclarations-scopes-duplicates2.js

@@ -0,0 +1,13 @@
+//// [tests/cases/compiler/letDeclarations-scopes-duplicates2.ts] ////
+
+//// [file1.ts]
+
+let var1 = 0;
+
+//// [file2.ts]
+let var1 = 0;
+
+//// [file1.js]
+let var1 = 0;
+//// [file2.js]
+let var1 = 0;

tests/baselines/reference/letDeclarations-scopes-duplicates3.errors.txt

@@ -0,0 +1,11 @@
+tests/cases/compiler/file2.ts(1,7): error TS2300: Duplicate identifier 'var1'.
+
+
+==== tests/cases/compiler/file1.ts (0 errors) ====
+    
+    let var1 = 0;
+    
+==== tests/cases/compiler/file2.ts (1 errors) ====
+    const var1 = 0;
+          ~~~~
+!!! error TS2300: Duplicate identifier 'var1'.

tests/baselines/reference/letDeclarations-scopes-duplicates3.js

@@ -0,0 +1,13 @@
+//// [tests/cases/compiler/letDeclarations-scopes-duplicates3.ts] ////
+
+//// [file1.ts]
+
+let var1 = 0;
+
+//// [file2.ts]
+const var1 = 0;
+
+//// [file1.js]
+let var1 = 0;
+//// [file2.js]
+const var1 = 0;

tests/baselines/reference/letDeclarations-scopes-duplicates4.errors.txt

@@ -0,0 +1,11 @@
+tests/cases/compiler/file2.ts(1,5): error TS2300: Duplicate identifier 'var1'.
+
+
+==== tests/cases/compiler/file1.ts (0 errors) ====
+    
+    const var1 = 0;
+    
+==== tests/cases/compiler/file2.ts (1 errors) ====
+    let var1 = 0;
+        ~~~~
+!!! error TS2300: Duplicate identifier 'var1'.

tests/baselines/reference/letDeclarations-scopes-duplicates4.js

@@ -0,0 +1,13 @@
+//// [tests/cases/compiler/letDeclarations-scopes-duplicates4.ts] ////
+
+//// [file1.ts]
+
+const var1 = 0;
+
+//// [file2.ts]
+let var1 = 0;
+
+//// [file1.js]
+const var1 = 0;
+//// [file2.js]
+let var1 = 0;

tests/baselines/reference/letDeclarations-scopes-duplicates5.errors.txt

@@ -0,0 +1,11 @@
+tests/cases/compiler/file2.ts(1,7): error TS2300: Duplicate identifier 'var1'.
+
+
+==== tests/cases/compiler/file1.ts (0 errors) ====
+    
+    const var1 = 0;
+    
+==== tests/cases/compiler/file2.ts (1 errors) ====
+    const var1 = 0;
+          ~~~~
+!!! error TS2300: Duplicate identifier 'var1'.

tests/baselines/reference/letDeclarations-scopes-duplicates5.js

@@ -0,0 +1,13 @@
+//// [tests/cases/compiler/letDeclarations-scopes-duplicates5.ts] ////
+
+//// [file1.ts]
+
+const var1 = 0;
+
+//// [file2.ts]
+const var1 = 0;
+
+//// [file1.js]
+const var1 = 0;
+//// [file2.js]
+const var1 = 0;

tests/baselines/reference/letDeclarations-scopes-duplicates6.errors.txt

@@ -0,0 +1,11 @@
+tests/cases/compiler/file2.ts(1,5): error TS2300: Duplicate identifier 'var1'.
+
+
+==== tests/cases/compiler/file1.ts (0 errors) ====
+    
+    var var1 = 0;
+    
+==== tests/cases/compiler/file2.ts (1 errors) ====
+    let var1 = 0;
+        ~~~~
+!!! error TS2300: Duplicate identifier 'var1'.