Make triple-slash comment classification more restrictive #33056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was overly permissive and ended up making a mess of C#-style comments: `/// <summary>Text</summary>` Now it checks the element name. Attribute names remain unchecked.
RyanCavanaugh
approved these changes
Aug 23, 2019
Member
Author
|
@typescript-bot cherry-pick this to release-3.6 |
Collaborator
|
Hey @amcasey, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-3.6 manually. |
Member
Author
|
@RyanCavanaugh I believe these are the relevant errors: |
amcasey
added a commit
to amcasey/TypeScript
that referenced
this pull request
Aug 23, 2019
Make triple-slash comment classification more restrictive (cherry picked from commit 5b59cfb)
amcasey
added a commit
that referenced
this pull request
Aug 26, 2019
Merge pull request #33056 from amcasey/TripleSlashRestrictions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was overly permissive and ended up making a mess of C#-style comments:
/// <summary>Text</summary>Now it checks the element name. Attribute names remain unchecked.