Fluent Tester: App Icons + iPad multitasking support + app icons #1952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrieshin
approved these changes
Aug 3, 2022
chiuam
approved these changes
Aug 3, 2022
10 tasks
Collaborator
Author
|
macOS test app seems broken. Investigating. |
mischreiber
approved these changes
Aug 3, 2022
Collaborator
Author
|
Indeed, the addition of macOS E2E testing found a bug in react-native-test-app for macOS, which is why our CI is failing. Opened an issue here: microsoft/react-native-test-app#1039 Thanks @samuelfreiberg :) |
Contributor
|
Nice icons! I like the color :) |
…ive; branch 'main' of github.com:microsoft/fluentui-react-native into rnta-update
|
Hello @Saadnajmi! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Let's bump us to the latest release of react-native-test-app, which gets us a lot of goodies :)
We also got a designer to make us icons =). I chose the blue set over the pink set.
Verification
I didn't test building with turbo modules, we don't quite support this yet anyway.
Verified that SlideOver windows work on iOS. Some additional JS fixes are needed to make layout act properly though.
Android icon:
macOS icon (dock):
iOS icon
Pull request checklist
This PR has considered (when applicable):