PR review; initial named parameter and index parameter restrictions

Author: tkyc

src/main/java/com/microsoft/sqlserver/jdbc/ISQLServerConnection.java

@@ -496,5 +496,5 @@ CallableStatement prepareCall(String sql, int nType, int nConcur, int nHold,
      * @param calcBigDecimalScale
      *        A boolean that indicates if the driver should calculate scale from inputted big decimal values.
      */
-    void setCalcBigDecimalScale(boolean computeBigDecimal);
+    void setCalcBigDecimalScale(boolean calcBigDecimalScale);
 }

src/main/java/com/microsoft/sqlserver/jdbc/SQLServerCallableStatement.java

@@ -470,6 +470,10 @@ private Parameter getterGetParam(int index) throws SQLServerException {
 
         // Check for valid index
         if (index < 1 || index > inOutParam.length) {
+            if (!connection.getUseFlexibleCallableStatements()) {
+                SQLServerException.makeFromDriverError(connection, this,
+                        SQLServerException.getErrString("R_unknownOutputParameter"), SQLSTATE_07009, false);
+            }
             MessageFormat form = new MessageFormat(SQLServerException.getErrString("R_invalidOutputParameter"));
             Object[] msgArgs = {index};
             SQLServerException.makeFromDriverError(connection, this, form.format(msgArgs), SQLSTATE_07009, false);
@@ -1412,6 +1416,12 @@ private String stripLeadingAtSign(String columnName) {
      * @return the index
      */
     private int findColumn(String columnName, CallableStatementGetterSetterMethod method) throws SQLServerException {
+        isSetByName = true;
+        if (!connection.getUseFlexibleCallableStatements() && isSetByName && isSetByIndex) {
+            SQLServerException.makeFromDriverError(connection, this,
+                    SQLServerException.getErrString("R_noNamedAndIndexedParameters"), null, false);
+        }
+
         // If inOutParam is null, likely the statement was closed beforehand.
         if (null == inOutParam) {
             SQLServerException.makeFromDriverError(connection, this,

src/main/java/com/microsoft/sqlserver/jdbc/SQLServerConnection.java

@@ -7842,8 +7842,11 @@ public boolean getUseFlexibleCallableStatements() {
      * Sets whether or not sp_sproc_columns will be used for parameter name lookup.
      *
      * @param useFlexibleCallableStatements
-     *        When set to true, sp_sproc_columns is not used for parameter name lookup
-     *        in callable statements.
+     *        When set to false, sp_sproc_columns is not used for parameter name lookup
+     *        in callable statements. This eliminates a round trip to the server but imposes limitations
+     *        on how parameters are set. When set to false, applications must either reference
+     *        parameters by name or by index, not both. Parameters must also be set in the same
+     *        order as the stored procedure definition.
      */
     public void setUseFlexibleCallableStatements(boolean useFlexibleCallableStatements) {
         this.useFlexibleCallableStatements = useFlexibleCallableStatements;

src/main/java/com/microsoft/sqlserver/jdbc/SQLServerPreparedStatement.java

@@ -144,6 +144,8 @@ protected Object[][] getContents() {
         {"R_stringNotInHex", "The string is not in a valid hex format."},
         {"R_unknownType", "The Java type {0} is not a supported type."},
         {"R_physicalConnectionIsClosed", "The physical connection is closed for this pooled connection."},
+        {"R_noNamedAndIndexedParameters", "Detected uncompliant use of both named and indexed parameters while 'useFlexibleCallableStatements=false'. It is suggested to either exclusively use named parameters or indexed parameters."},
+        {"R_unknownOutputParameter", "Cannot acquire output parameter value by name. No parameter index was associated with the output parameter name. If acquiring output parameter by name, verify that the output parameter was initially registered by name."},
         {"R_invalidDataSourceReference", "Invalid DataSource reference."},
         {"R_cantGetColumnValueFromDeletedRow", "Cannot get a value from a deleted row."},
         {"R_cantGetUpdatedColumnValue", "Updated columns cannot be accessed until updateRow() or cancelRowUpdates() has been called."},

src/main/java/com/microsoft/sqlserver/jdbc/SQLServerResource.java

@@ -149,6 +149,12 @@ final boolean wasExecuted() {
      */
     boolean isCloseOnCompletion = false;
 
+    /** Checks if the callable statement's parameters are set by name **/
+    protected boolean isSetByName = false;
+
+    /** Checks if the prepared statement's parameters were set by index **/
+    protected boolean isSetByIndex = false;
+
     /**
      * Currently executing or most recently executed TDSCommand (statement cmd, server cursor cmd, ...) subject to
      * cancellation through Statement.cancel.

src/main/java/com/microsoft/sqlserver/jdbc/SQLServerStatement.java

@@ -56,6 +56,8 @@ protected Object[][] getContents() {
             {"R_createDropAlterTableFailed", "Create/drop/alter table with preparedStatement failed!"},
             {"R_grantFailed", "grant table with preparedStatement failed!"},
             {"R_connectionIsClosed", "The connection is closed."},
+            {"R_noNamedAndIndexedParameters", "Detected uncompliant use of both named and indexed parameters while 'useFlexibleCallableStatements=false'. It is suggested to either exclusively use named parameters or indexed parameters."},
+            {"R_unknownOutputParameter", "Cannot acquire output parameter value by name. No parameter index was associated with the output parameter name. If acquiring output parameter by name, verify that the output parameter was initially registered by name."},
             {"R_ConnectionURLNull", "The connection URL is null."},
             {"R_connectionIsNotClosed", "The connection is not closed."},
             {"R_invalidExceptionMessage", "Invalid exception message"},