Skip to content

Commit 82ce736

Browse files
authored
test: remove stale fixme/skips in capabilities spec (#36617)
1 parent fab3043 commit 82ce736

File tree

1 file changed

+4
-14
lines changed

1 file changed

+4
-14
lines changed

tests/library/capabilities.spec.ts

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
* limitations under the License.
1515
*/
1616

17-
import os from 'os';
1817
import url from 'url';
1918
import { contextTest as it, expect } from '../config/browserTest';
2019
import { hostPlatform } from '../../packages/playwright-core/src/server/utils/hostPlatform';
@@ -31,8 +30,7 @@ it('SharedArrayBuffer should work @smoke', async function({ contextFactory, http
3130
expect(await page.evaluate(() => typeof SharedArrayBuffer)).toBe('function');
3231
});
3332

34-
it('Web Assembly should work @smoke', async ({ page, server, browserName, platform }) => {
35-
it.fixme(browserName === 'webkit' && platform === 'win32', 'Windows JIT is disabled: https://bugs.webkit.org/show_bug.cgi?id=273854');
33+
it('Web Assembly should work @smoke', async ({ page, server }) => {
3634
await page.goto(server.PREFIX + '/wasm/table2.html');
3735
expect(await page.evaluate('loadTable()')).toBe('42, 83');
3836
});
@@ -101,20 +99,16 @@ it('should play audio @smoke', async ({ page, server, browserName, platform }) =
10199
expect(await page.$eval('audio', e => e.currentTime)).toBeGreaterThan(0.2);
102100
});
103101

104-
it('should support webgl @smoke', async ({ page, browserName, platform }) => {
105-
it.fixme(browserName === 'chromium' && platform === 'darwin' && os.arch() === 'arm64', 'SwiftShader is not available on macOS-arm64 - https://github.com/microsoft/playwright/issues/28216');
102+
it('should support webgl @smoke', async ({ page }) => {
106103
const hasWebGL = await page.evaluate(() => {
107104
const canvas = document.createElement('canvas');
108105
return !!canvas.getContext('webgl');
109106
});
110107
expect(hasWebGL).toBe(true);
111108
});
112109

113-
it('should support webgl 2 @smoke', async ({ page, browserName, headless, isWindows, platform }) => {
114-
it.skip(browserName === 'webkit', 'WebKit doesn\'t have webgl2 enabled yet upstream.');
110+
it('should support webgl 2 @smoke', async ({ page, browserName, isWindows }) => {
115111
it.fixme(browserName === 'firefox' && isWindows);
116-
it.fixme(browserName === 'chromium' && !headless, 'chromium doesn\'t like webgl2 when running under xvfb');
117-
it.fixme(browserName === 'chromium' && platform === 'darwin' && os.arch() === 'arm64', 'SwiftShader is not available on macOS-arm64 - https://github.com/microsoft/playwright/issues/28216');
118112

119113
const hasWebGL2 = await page.evaluate(() => {
120114
const canvas = document.createElement('canvas');
@@ -131,7 +125,6 @@ it('should not crash on page with mp4 @smoke', async ({ page, server, platform,
131125

132126
it('should not crash on showDirectoryPicker', async ({ page, server, browserName, browserMajorVersion }) => {
133127
it.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/7339' });
134-
it.skip(browserName === 'chromium' && browserMajorVersion < 99, 'Fixed in Chromium r956769');
135128
it.skip(browserName !== 'chromium', 'showDirectoryPicker is only available in Chromium');
136129
await page.goto(server.EMPTY_PAGE);
137130
// "User activation is required to show a file picker." - so we click first.
@@ -148,7 +141,6 @@ it('should not crash on showDirectoryPicker', async ({ page, server, browserName
148141

149142
it('should not crash on storage.getDirectory()', async ({ page, server, browserName, isMac }) => {
150143
it.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/18235' });
151-
it.skip(browserName === 'firefox', 'navigator.storage.getDirectory is not a function');
152144
await page.goto(server.EMPTY_PAGE);
153145
const error = await page.evaluate(async () => {
154146
const dir = await navigator.storage.getDirectory();
@@ -281,7 +273,6 @@ it('should send no Content-Length header for GET requests with a Content-Type',
281273

282274
it('Intl.ListFormat should work', async ({ page, server, browserName }) => {
283275
it.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/23978' });
284-
it.skip(browserName === 'webkit' && hostPlatform.startsWith('ubuntu20.04'), 'libicu is too old and WebKit disables Intl.ListFormat by default then');
285276
await page.goto(server.EMPTY_PAGE);
286277
const formatted = await page.evaluate(() => {
287278
const data = ['first', 'second', 'third'];
@@ -434,8 +425,7 @@ it('should not crash when clicking a color input', {
434425
type: 'issue',
435426
description: 'https://github.com/microsoft/playwright/issues/33864'
436427
}
437-
}, async ({ page, browserMajorVersion, browserName }) => {
438-
it.skip(browserName === 'firefox' && browserMajorVersion < 135);
428+
}, async ({ page }) => {
439429

440430
await page.setContent('<input type="color">');
441431
const input = page.locator('input');

0 commit comments

Comments
 (0)