Skip to content

feat(trace-viewer): Collapse sections inside network request #38086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(trace-viewer): Collapse sections inside network request #38086

wants to merge 1 commit into from
+96 −30

Conversation

@cpAdm
Copy link
Contributor

@cpAdm cpAdm commented Oct 31, 2025 •
edited
Loading

  • Made sections collapsible by using<details>s
  • Store the collapsed state in local storage
  • Kept almost all existing styling, adapted margin-left to align the chevron with the close icon above
  • Added test

Before:
image

After:
image
image

references: #35214

pavelfeldman
pavelfeldman reviewed Oct 31, 2025
View reviewed changes
packages/trace-viewer/src/ui/networkResourceDetails.tsx
);
};

const DetailsSection: React.FC<{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have a bunch of expandable controls that could be reused. Did none of them match?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pavelfeldman pavelfeldman pavelfeldman left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cpAdm @pavelfeldman