Skip to content

Commit 4ba0dda

Browse files
dulmandakhfacebook-github-bot
authored andcommitted
decouple compileSdk version from build tools version (facebook#21205)
Summary: Android CI was failing due to that it was trying to extract major version from build tools and use it to compile ReactAndroid. Now, it'll extract compileSdkVersion from ReactAndroid/build.gradle and use it. Issue was that facebook@68c7999 dowgraded compileSdk version to 26 while retaining build tools version as 27.0.3, so CI was trying to use SDK 27. Pull Request resolved: facebook#21205 Differential Revision: D9943909 Pulled By: hramos fbshipit-source-id: ec9bc0c40956a16f8088532340722fd43cadde37
1 parent 7f208cf commit 4ba0dda

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

scripts/validate-android-test-env.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ fi
5656
BUILD_TOOLS_VERSION=`grep buildToolsVersion $(dirname $0)/../ReactAndroid/build.gradle | sed 's/^[^"]*\"//' | sed 's/"//'`
5757

5858
# MAJOR is something like "23"
59-
MAJOR=`echo $BUILD_TOOLS_VERSION | sed 's/\..*//'`
59+
MAJOR=`grep compileSdkVersion $(dirname $0)/../ReactAndroid/build.gradle | sed 's/[^[:digit:]]//g'`
6060

6161
# Check that we have the right major version of the Android SDK.
6262
PLATFORM_DIR="$ANDROID_HOME/platforms/android-$MAJOR"

0 commit comments

Comments
 (0)