Enable unused-private-field warning (facebook#13450)

Uladzislau Paulovich · facebook-github-bot · commit 75e884727c75 · 2018-11-08T09:23:12.000-08:00
Summary: Pull Request resolved: pytorch/pytorch#13450 Pull Request resolved: facebook#22065 This diff enables -Wunused-private-field clang warning for Android builds and fixes all broken targets. Reviewed By: gkmhub Differential Revision: D12881793 fbshipit-source-id: 515555661e137be9e7b20eac9b5bdcb549d6a094
diff --git a/ReactCommon/fabric/imagemanager/platform/android/ImageManager.cpp b/ReactCommon/fabric/imagemanager/platform/android/ImageManager.cpp
@@ -11,6 +11,8 @@ namespace facebook {
 namespace react {
 
 ImageManager::ImageManager(void *platformSpecificCounterpart) {
+  // Silence unused-private-field warning.
+  (void)self_;
   // Not implemented.
 }
 

Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,8 @@ namespace facebook {`
`11`	`11`	`namespace react {`
`12`	`12`
`13`	`13`	`ImageManager::ImageManager(void *platformSpecificCounterpart) {`
	`14`	`+ // Silence unused-private-field warning.`
	`15`	`+ (void)self_;`
`14`	`16`	`// Not implemented.`
`15`	`17`	`}`
`16`	`18`