Remove references to hermes-engine-darwin (#956)

* Remove hermes-engine-darwin, update generator-macos

* fix typo

* one postinstall

* remove test targets

* disable flipper

* minimal changes to podfile

* one less diff

* Updatee from PR comments

* Update local-cli/generator-macos/templates/macos/Podfile

Co-authored-by: Tommy Nguyen <[email protected]>

Co-authored-by: Tommy Nguyen <[email protected]>

Author: Saadnajmi

local-cli/generator-macos/templates/macos/Podfile

@@ -6,12 +6,8 @@ target 'HelloWorld-macOS' do
   use_native_modules!
   use_react_native!(
     :path => '../node_modules/react-native-macos',
-    
-    # To use Hermes, install the `hermes-engine-darwin` npm package, e.g.:
-    #   $ yarn add 'hermes-engine-darwin@~0.5.3'
-    #
-    # Then enable this option:
-    #   :hermes_enabled => true
+    # to enable hermes on macOS, change `false` to `true` and then install pods
+    :hermes_enabled => false
   )
 
   # Pods specifically for macOS target
@@ -29,7 +25,6 @@ target 'HelloWorld-iOS' do
   use_flipper!
 
   post_install do |installer|
-    flipper_post_install(installer)
     react_native_post_install(installer)
     __apply_Xcode_12_5_M1_post_install_workaround(installer)
   end

repo-config/package.json

@@ -39,7 +39,6 @@
     "eslint-plugin-react-native": "3.10.0",
     "eslint-plugin-relay": "1.8.1",
     "flow-bin": "^0.158.0",
-    "hermes-engine-darwin": "~0.5.0",
     "jest": "^26.6.3",
     "jest-junit": "^10.0.0",
     "jscodeshift": "^0.11.0",

yarn.lock

@@ -4306,11 +4306,6 @@ has@^1.0.3:
   dependencies:
     function-bind "^1.1.1"
 
-hermes-engine-darwin@~0.5.0:
-  version "0.5.3"
-  resolved "https://registry.yarnpkg.com/hermes-engine-darwin/-/hermes-engine-darwin-0.5.3.tgz#4eb8edabfff640c2150cf974290a03429b66cc11"
-  integrity sha512-TwCpLJgEDm/Z2pOr88IDlXlC1Y3WITvXoYtOr4iChc6ecJqYOUklQW838lKZ7urBBFfPb0rW6poVD6iZORdzZQ==
-
 hermes-engine@~0.9.0:
   version "0.9.0"
   resolved "https://registry.yarnpkg.com/hermes-engine/-/hermes-engine-0.9.0.tgz#84d9cfe84e8f6b1b2020d6e71b350cec84ed982f"