accommodate for breaking changes in 0.70

Author: tido64

android/app/src/main/jni/TurboModuleManagerDelegate.cpp

@@ -7,6 +7,8 @@ using facebook::react::CallInvoker;
 using facebook::react::JavaTurboModule;
 using facebook::react::TurboModule;
 using ReactTestApp::TurboModuleManagerDelegate;
+using ReactTestApp::TurboModuleManagerDelegate::SharedCallInvoker;
+using ReactTestApp::TurboModuleManagerDelegate::StringRef;
 
 void TurboModuleManagerDelegate::registerNatives()
 {
@@ -16,14 +18,14 @@ void TurboModuleManagerDelegate::registerNatives()
     });
 }
 
-std::shared_ptr<TurboModule>
-TurboModuleManagerDelegate::getTurboModule(const std::string, const std::shared_ptr<CallInvoker>)
+std::shared_ptr<TurboModule> TurboModuleManagerDelegate::getTurboModule(const StringRef,
+                                                                        const SharedCallInvoker)
 {
     return nullptr;
 }
 
 std::shared_ptr<TurboModule> TurboModuleManagerDelegate::getTurboModule(
-    const std::string name, const JavaTurboModule::InitParams &params)
+    const StringRef name, const JavaTurboModule::InitParams &params)
 {
     // Try autolinked module providers first
     auto rncli_module = rncli_ModuleProvider(name, params);
@@ -41,7 +43,7 @@ TurboModuleManagerDelegate::initHybrid(
     return makeCxxInstance();
 }
 
-bool TurboModuleManagerDelegate::canCreateTurboModule(std::string name)
+bool TurboModuleManagerDelegate::canCreateTurboModule(const StringRef name)
 {
     return getTurboModule(name, nullptr) != nullptr ||
            getTurboModule(name, {.moduleName = name}) != nullptr;

android/app/src/main/jni/TurboModuleManagerDelegate.h

@@ -14,18 +14,27 @@ namespace ReactTestApp
         : public facebook::jni::HybridClass<TurboModuleManagerDelegate,
                                             facebook::react::TurboModuleManagerDelegate>
     {
+        // Signatures changed in 0.70 to avoid unnecessary string copies; see
+        // https://github.com/facebook/react-native/commit/3337add547c60b84816ef5dad82f4ead2e8742ef
+#if __has_include(<ReactCommon/CompositeTurboModuleManagerDelegate.h>)
+        using SharedCallInvoker = std::shared_ptr<facebook::react::CallInvoker> &;
+        using StringRef = std::string &;
+#else
+        using SharedCallInvoker = std::shared_ptr<facebook::react::CallInvoker>;
+        using StringRef = std::string;
+#endif
+
     public:
         static constexpr auto kJavaDescriptor =
             "Lcom/microsoft/reacttestapp/turbomodule/TurboModuleManagerDelegate;";
 
         static void registerNatives();
 
         std::shared_ptr<facebook::react::TurboModule>
-        getTurboModule(const std::string name,  //
-                       const std::shared_ptr<facebook::react::CallInvoker> jsInvoker) override;
+        getTurboModule(const StringRef name, const SharedCallInvoker jsInvoker) override;
 
         std::shared_ptr<facebook::react::TurboModule>
-        getTurboModule(const std::string name,  //
+        getTurboModule(const StringRef name,  //
                        const facebook::react::JavaTurboModule::InitParams &params) override;
 
     private:
@@ -36,7 +45,7 @@ namespace ReactTestApp
          * Test-only method. Allows user to verify whether a TurboModule can be
          * created by instances of this class.
          */
-        bool canCreateTurboModule(std::string name);
+        bool canCreateTurboModule(const StringRef name);
     };
 }  // namespace ReactTestApp