From 7e2fdf1788e281230eb418f25578fb50793b769c Mon Sep 17 00:00:00 2001
From: Simon Cropp <simon.cropp@gmail.com>
Date: Thu, 23 May 2024 13:05:43 +1000
Subject: [PATCH] remove unnecessary list alloc for 2 scenarios in
 TestRequestManager.GetSources

---
 .../TestPlatformHelpers/TestRequestManager.cs    | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)

diff --git a/src/vstest.console/TestPlatformHelpers/TestRequestManager.cs b/src/vstest.console/TestPlatformHelpers/TestRequestManager.cs
index bd6c30de67..4a8134cd03 100644
--- a/src/vstest.console/TestPlatformHelpers/TestRequestManager.cs
+++ b/src/vstest.console/TestPlatformHelpers/TestRequestManager.cs
@@ -1510,23 +1510,21 @@ private IRequestData GetRequestData(ProtocolConfig protocolConfig)
     private static List<string> GetSources(TestRunRequestPayload testRunRequestPayload)
     {
         // TODO: This should also use hashset to only return distinct sources.
-        List<string> sources = new();
-        if (testRunRequestPayload.Sources != null
-            && testRunRequestPayload.Sources.Count > 0)
+        if (testRunRequestPayload.Sources is { Count: > 0 })
         {
-            sources = testRunRequestPayload.Sources;
+            return testRunRequestPayload.Sources;
         }
-        else if (testRunRequestPayload.TestCases != null
-                 && testRunRequestPayload.TestCases.Count > 0)
+
+        if (testRunRequestPayload.TestCases is { Count: > 0 })
         {
-            ISet<string> sourcesSet = new HashSet<string>();
+            var sourcesSet = new HashSet<string>();
             foreach (var testCase in testRunRequestPayload.TestCases)
             {
                 sourcesSet.Add(testCase.Source);
             }
-            sources = sourcesSet.ToList();
+            return sourcesSet.ToList();
         }
-        return sources;
+        return [];
     }
 }