From 2380d964be3b1e02e39fbeef241707e10f0e722b Mon Sep 17 00:00:00 2001 From: Kenny Kerr Date: Fri, 16 May 2025 17:38:04 -0500 Subject: [PATCH] must_use --- crates/libs/bindgen/src/lib.rs | 1 + crates/samples/components/json_validator_winrt/build.rs | 3 ++- .../samples/components/json_validator_winrt_client/build.rs | 3 ++- crates/tests/misc/component/build.rs | 3 ++- crates/tests/misc/component_client/build.rs | 3 ++- crates/tests/winrt/collection_interop/build.rs | 3 ++- crates/tests/winrt/composable/build.rs | 3 ++- crates/tests/winrt/composable_client/build.rs | 3 ++- crates/tests/winrt/constructors/build.rs | 3 ++- crates/tests/winrt/constructors_client/build.rs | 3 ++- crates/tests/winrt/events/build.rs | 3 ++- crates/tests/winrt/events_client/build.rs | 3 ++- crates/tests/winrt/noexcept/build.rs | 3 ++- crates/tests/winrt/overloads/build.rs | 3 ++- crates/tests/winrt/overloads_client/build.rs | 3 ++- crates/tests/winrt/ref_params/build.rs | 3 ++- crates/tests/winrt/reference/build.rs | 3 ++- crates/tests/winrt/reference_client/build.rs | 3 ++- crates/tests/winrt/reference_custom/build.rs | 2 +- crates/tests/winrt/reference_float/build.rs | 2 +- crates/tests/winrt/reference_no_deps/build.rs | 2 +- crates/tests/winrt/reference_no_windows/build.rs | 3 ++- crates/tests/winrt/reference_windows/build.rs | 3 ++- crates/tools/bindgen/src/main.rs | 4 ++-- crates/tools/bindings/src/main.rs | 4 ++-- crates/tools/standalone/src/main.rs | 4 ++-- 26 files changed, 48 insertions(+), 28 deletions(-) diff --git a/crates/libs/bindgen/src/lib.rs b/crates/libs/bindgen/src/lib.rs index bd58b51721..c683cf30fb 100644 --- a/crates/libs/bindgen/src/lib.rs +++ b/crates/libs/bindgen/src/lib.rs @@ -54,6 +54,7 @@ use method_names::*; /// The Windows code generator. #[track_caller] +#[must_use] pub fn bindgen(args: I) -> Warnings where I: IntoIterator, diff --git a/crates/samples/components/json_validator_winrt/build.rs b/crates/samples/components/json_validator_winrt/build.rs index 1695cf0dd7..f530a0bcde 100644 --- a/crates/samples/components/json_validator_winrt/build.rs +++ b/crates/samples/components/json_validator_winrt/build.rs @@ -31,5 +31,6 @@ fn main() { "Sample", "--flat", "--implement", - ]); + ]) + .unwrap(); } diff --git a/crates/samples/components/json_validator_winrt_client/build.rs b/crates/samples/components/json_validator_winrt_client/build.rs index 5712ee01ba..e1d69d0403 100644 --- a/crates/samples/components/json_validator_winrt_client/build.rs +++ b/crates/samples/components/json_validator_winrt_client/build.rs @@ -8,5 +8,6 @@ fn main() { "--filter", "Sample", "--flat", - ]); + ]) + .unwrap(); } diff --git a/crates/tests/misc/component/build.rs b/crates/tests/misc/component/build.rs index f944753b1c..66d27cf285 100644 --- a/crates/tests/misc/component/build.rs +++ b/crates/tests/misc/component/build.rs @@ -33,5 +33,6 @@ fn main() { "--no-comment", "--reference", "windows", - ]); + ]) + .unwrap(); } diff --git a/crates/tests/misc/component_client/build.rs b/crates/tests/misc/component_client/build.rs index 7346b84fa3..2afb7fc3a4 100644 --- a/crates/tests/misc/component_client/build.rs +++ b/crates/tests/misc/component_client/build.rs @@ -11,5 +11,6 @@ fn main() { "--flat", "--reference", "windows", - ]); + ]) + .unwrap(); } diff --git a/crates/tests/winrt/collection_interop/build.rs b/crates/tests/winrt/collection_interop/build.rs index d4e7c38b36..552e770445 100644 --- a/crates/tests/winrt/collection_interop/build.rs +++ b/crates/tests/winrt/collection_interop/build.rs @@ -40,7 +40,8 @@ fn main() { "--no-comment", "--reference", "windows_collections,flat,Windows", - ]); + ]) + .unwrap(); let include = std::env::var("OUT_DIR").unwrap(); diff --git a/crates/tests/winrt/composable/build.rs b/crates/tests/winrt/composable/build.rs index e68bc882e7..45cdd8896c 100644 --- a/crates/tests/winrt/composable/build.rs +++ b/crates/tests/winrt/composable/build.rs @@ -29,5 +29,6 @@ fn main() { "--implement", "--no-comment", "--flat", - ]); + ]) + .unwrap(); } diff --git a/crates/tests/winrt/composable_client/build.rs b/crates/tests/winrt/composable_client/build.rs index eb297b0e2b..7b02e7643e 100644 --- a/crates/tests/winrt/composable_client/build.rs +++ b/crates/tests/winrt/composable_client/build.rs @@ -16,7 +16,8 @@ fn main() { "test_composable", "--no-comment", "--flat", - ]); + ]) + .unwrap(); let include = std::env::var("OUT_DIR").unwrap(); diff --git a/crates/tests/winrt/constructors/build.rs b/crates/tests/winrt/constructors/build.rs index 29c16b40a7..e937ae8b94 100644 --- a/crates/tests/winrt/constructors/build.rs +++ b/crates/tests/winrt/constructors/build.rs @@ -29,5 +29,6 @@ fn main() { "--implement", "--no-comment", "--flat", - ]); + ]) + .unwrap(); } diff --git a/crates/tests/winrt/constructors_client/build.rs b/crates/tests/winrt/constructors_client/build.rs index 854f0a05b2..18322ed910 100644 --- a/crates/tests/winrt/constructors_client/build.rs +++ b/crates/tests/winrt/constructors_client/build.rs @@ -16,7 +16,8 @@ fn main() { "test_constructors", "--no-comment", "--flat", - ]); + ]) + .unwrap(); let include = std::env::var("OUT_DIR").unwrap(); diff --git a/crates/tests/winrt/events/build.rs b/crates/tests/winrt/events/build.rs index f48913f6eb..fb0900b2da 100644 --- a/crates/tests/winrt/events/build.rs +++ b/crates/tests/winrt/events/build.rs @@ -33,5 +33,6 @@ fn main() { "--flat", "--reference", "windows", - ]); + ]) + .unwrap(); } diff --git a/crates/tests/winrt/events_client/build.rs b/crates/tests/winrt/events_client/build.rs index 5209838145..d9d26f1816 100644 --- a/crates/tests/winrt/events_client/build.rs +++ b/crates/tests/winrt/events_client/build.rs @@ -13,5 +13,6 @@ fn main() { "--flat", "--reference", "windows", - ]); + ]) + .unwrap(); } diff --git a/crates/tests/winrt/noexcept/build.rs b/crates/tests/winrt/noexcept/build.rs index 37e2f7285f..6fefbf3656 100644 --- a/crates/tests/winrt/noexcept/build.rs +++ b/crates/tests/winrt/noexcept/build.rs @@ -38,7 +38,8 @@ fn main() { "--implement", "--flat", "--no-comment", - ]); + ]) + .unwrap(); let include = std::env::var("OUT_DIR").unwrap(); diff --git a/crates/tests/winrt/overloads/build.rs b/crates/tests/winrt/overloads/build.rs index de58c48395..34d6dabbba 100644 --- a/crates/tests/winrt/overloads/build.rs +++ b/crates/tests/winrt/overloads/build.rs @@ -29,5 +29,6 @@ fn main() { "--implement", "--no-comment", "--flat", - ]); + ]) + .unwrap(); } diff --git a/crates/tests/winrt/overloads_client/build.rs b/crates/tests/winrt/overloads_client/build.rs index a000026736..7a8850d9e6 100644 --- a/crates/tests/winrt/overloads_client/build.rs +++ b/crates/tests/winrt/overloads_client/build.rs @@ -9,5 +9,6 @@ fn main() { "test_overloads", "--no-comment", "--flat", - ]); + ]) + .unwrap(); } diff --git a/crates/tests/winrt/ref_params/build.rs b/crates/tests/winrt/ref_params/build.rs index 37e2f7285f..6fefbf3656 100644 --- a/crates/tests/winrt/ref_params/build.rs +++ b/crates/tests/winrt/ref_params/build.rs @@ -38,7 +38,8 @@ fn main() { "--implement", "--flat", "--no-comment", - ]); + ]) + .unwrap(); let include = std::env::var("OUT_DIR").unwrap(); diff --git a/crates/tests/winrt/reference/build.rs b/crates/tests/winrt/reference/build.rs index e6fc431133..8225fa0ca8 100644 --- a/crates/tests/winrt/reference/build.rs +++ b/crates/tests/winrt/reference/build.rs @@ -31,5 +31,6 @@ fn main() { "--flat", "--reference", "windows", - ]); + ]) + .unwrap(); } diff --git a/crates/tests/winrt/reference_client/build.rs b/crates/tests/winrt/reference_client/build.rs index 20c7ad2df9..ef30383630 100644 --- a/crates/tests/winrt/reference_client/build.rs +++ b/crates/tests/winrt/reference_client/build.rs @@ -11,5 +11,6 @@ fn main() { "--flat", "--reference", "windows", - ]); + ]) + .unwrap(); } diff --git a/crates/tests/winrt/reference_custom/build.rs b/crates/tests/winrt/reference_custom/build.rs index b4138df627..dc35579da6 100644 --- a/crates/tests/winrt/reference_custom/build.rs +++ b/crates/tests/winrt/reference_custom/build.rs @@ -20,7 +20,7 @@ fn main() { panic!("Failed to run midlrt"); } - windows_bindgen::bindgen([ + _ = windows_bindgen::bindgen([ "--in", "default", "test.winmd", diff --git a/crates/tests/winrt/reference_float/build.rs b/crates/tests/winrt/reference_float/build.rs index b6133c226b..f4a7604ed0 100644 --- a/crates/tests/winrt/reference_float/build.rs +++ b/crates/tests/winrt/reference_float/build.rs @@ -18,7 +18,7 @@ fn main() { panic!("Failed to run midlrt"); } - windows_bindgen::bindgen([ + _ = windows_bindgen::bindgen([ "--in", "metadata.winmd", "../../../libs/bindgen/default", diff --git a/crates/tests/winrt/reference_no_deps/build.rs b/crates/tests/winrt/reference_no_deps/build.rs index c0af24e324..b3c102a80a 100644 --- a/crates/tests/winrt/reference_no_deps/build.rs +++ b/crates/tests/winrt/reference_no_deps/build.rs @@ -20,7 +20,7 @@ fn main() { panic!("Failed to run midlrt"); } - windows_bindgen::bindgen([ + _ = windows_bindgen::bindgen([ "--in", "default", "test.winmd", diff --git a/crates/tests/winrt/reference_no_windows/build.rs b/crates/tests/winrt/reference_no_windows/build.rs index 1b86ce3254..7d1cd5b119 100644 --- a/crates/tests/winrt/reference_no_windows/build.rs +++ b/crates/tests/winrt/reference_no_windows/build.rs @@ -32,5 +32,6 @@ fn main() { "--implement", "--flat", "--no-comment", - ]); + ]) + .unwrap(); } diff --git a/crates/tests/winrt/reference_windows/build.rs b/crates/tests/winrt/reference_windows/build.rs index 5ea5e6fec6..7bc3a562a2 100644 --- a/crates/tests/winrt/reference_windows/build.rs +++ b/crates/tests/winrt/reference_windows/build.rs @@ -33,5 +33,6 @@ fn main() { "--no-comment", "--reference", "windows", - ]); + ]) + .unwrap(); } diff --git a/crates/tools/bindgen/src/main.rs b/crates/tools/bindgen/src/main.rs index 425f007f4d..396edcaf8d 100644 --- a/crates/tools/bindgen/src/main.rs +++ b/crates/tools/bindgen/src/main.rs @@ -6,11 +6,11 @@ use windows_bindgen::bindgen; fn test(args: &str) { let mut expand = vec!["--no-comment", "--in", "default", "--flat"]; expand.extend(args.split_whitespace()); - bindgen(expand); + _ = bindgen(expand); } fn test_raw(args: &str) { - bindgen(args.split_whitespace()); + _ = bindgen(args.split_whitespace()); } fn main() { diff --git a/crates/tools/bindings/src/main.rs b/crates/tools/bindings/src/main.rs index 5d8e4776eb..a3e3b79475 100644 --- a/crates/tools/bindings/src/main.rs +++ b/crates/tools/bindings/src/main.rs @@ -17,8 +17,8 @@ fn main() { bindgen(["--etc", "crates/tools/bindings/src/threading.txt"]).unwrap(); bindgen(["--etc", "crates/tools/bindings/src/services.txt"]).unwrap(); - bindgen(["--etc", "crates/tools/bindings/src/sys.txt"]); - bindgen(["--etc", "crates/tools/bindings/src/windows.txt"]); + _ = bindgen(["--etc", "crates/tools/bindings/src/sys.txt"]); + _ = bindgen(["--etc", "crates/tools/bindings/src/windows.txt"]); println!("Finished in {:.2}s", time.elapsed().as_secs_f32()); } diff --git a/crates/tools/standalone/src/main.rs b/crates/tools/standalone/src/main.rs index c7aeadd79a..58cd91043d 100644 --- a/crates/tools/standalone/src/main.rs +++ b/crates/tools/standalone/src/main.rs @@ -228,7 +228,7 @@ fn write_win(output: &Path, filter: &[&str]) { args.extend_from_slice(&["--no-comment"]); args.extend_from_slice(&["--flat"]); println!("running: bindgen {}", args.join(" ")); - windows_bindgen::bindgen(args); + _ = windows_bindgen::bindgen(args); } fn write_no_inner_attr(output: &Path, filter: &[&str]) { @@ -246,5 +246,5 @@ fn bindgen(output: &Path, filter: &[&str], config: &[&str]) { args.extend_from_slice(&["--no-comment"]); args.extend_from_slice(config); println!("running: bindgen {}", args.join(" ")); - windows_bindgen::bindgen(args); + _ = windows_bindgen::bindgen(args); }