Disable create service account button if no policy (#1006)

* disable button if no policies

* merge fix

* finding group policies

* fixing style

Co-authored-by: Daniel Valdivia <[email protected]>
Co-authored-by: Adam Stafford <[email protected]>
Co-authored-by: Alex <[email protected]>

Author: 4 people

models/user.go

@@ -151,6 +151,7 @@ const UserDetails = ({ classes, match }: IUserDetailsProps) => {
   const [changeUserPasswordModalOpen, setChangeUserPasswordModalOpen] =
     useState<boolean>(false);
   const [deleteOpen, setDeleteOpen] = useState<boolean>(false);
+  const [hasPolicy, setHasPolicy] = useState<boolean>(false);
 
   const userName = match.params["userName"];
 
@@ -188,6 +189,7 @@ const UserDetails = ({ classes, match }: IUserDetailsProps) => {
         }
         setCurrentPolicies(currentPolicies);
         setEnabled(res.status === "enabled");
+        setHasPolicy(res.hasPolicy)
         setLoading(false);
       })
       .catch((err: ErrorResponseHandler) => {
@@ -382,7 +384,7 @@ const UserDetails = ({ classes, match }: IUserDetailsProps) => {
               />
             </TabPanel>
             <TabPanel index={1} value={curTab}>
-              <UserServiceAccountsPanel user={userName} classes={classes} />
+              <UserServiceAccountsPanel user={userName} classes={classes} hasPolicy={hasPolicy} />
             </TabPanel>
             <TabPanel index={2} value={curTab}>
               <div className={classes.actionsTray}>

portal-ui/src/screens/Console/Users/UserDetails.tsx

@@ -38,6 +38,7 @@ interface IUserServiceAccountsProps {
   classes: any;
   user: string;
   setErrorSnackMessage: typeof setErrorSnackMessage;
+  hasPolicy: boolean;
 }
 
 const styles = (theme: Theme) =>
@@ -53,6 +54,7 @@ const UserServiceAccountsPanel = ({
   classes,
   user,
   setErrorSnackMessage,
+  hasPolicy,
 }: IUserServiceAccountsProps) => {
   const [records, setRecords] = useState<string[]>([]);
   const [loading, setLoading] = useState<boolean>(false);
@@ -75,7 +77,6 @@ const UserServiceAccountsPanel = ({
         .invoke("GET", `/api/v1/user/${user}/service-accounts`)
         .then((res: string[]) => {
           const serviceAccounts = res.sort(stringSort);
-
           setLoading(false);
           setRecords(serviceAccounts);
         })
@@ -169,6 +170,7 @@ const UserServiceAccountsPanel = ({
             setAddScreenOpen(true);
             setSelectedServiceAccount(null);
           }}
+          disabled={!hasPolicy}
         >
           Create service account
         </Button>

portal-ui/src/screens/Console/Users/UserServiceAccountsPanel.tsx

@@ -281,11 +281,35 @@ func getUserInfoResponse(session *models.Principal, params admin_api.GetUserInfo
 		return nil, prepareError(err)
 	}
 
+	var policies []string
+	if user.PolicyName == "" {
+		policies = []string{}
+	} else {
+		policies = strings.Split(user.PolicyName, ",")
+	}
+
+	hasPolicy := true
+
+	if len(policies) == 0 {
+		hasPolicy = false
+		for i := 0; i < len(user.MemberOf); i++ {
+			group, err := adminClient.getGroupDescription(ctx, user.MemberOf[i])
+			if err != nil {
+				continue
+			}
+			if group.Policy != "" {
+				hasPolicy = true
+				break
+			}
+		}
+	}
+
 	userInformation := &models.User{
 		AccessKey: params.Name,
 		MemberOf:  user.MemberOf,
-		Policy:    strings.Split(user.PolicyName, ","),
+		Policy:    policies,
 		Status:    string(user.Status),
+		HasPolicy: hasPolicy,
 	}
 
 	return userInformation, nil

restapi/admin_users.go

@@ -2485,6 +2485,9 @@ definitions:
           type: string
       status:
         type: string
+      hasPolicy:
+        type: boolean
+
   listUsersResponse:
     type: object
     properties: