Address Harsha comments

Author: Anis Elleuch

restapi/client-admin.go

@@ -487,6 +487,13 @@ var httpClients = struct {
 	m: make(map[string]*http.Client),
 }
 
+func isLocalAddress(address string) bool {
+	if u, err := url.Parse(address); err == nil && u.Host != "" {
+		return address == "127.0.0.1" || strings.HasPrefix(address, "127.0.0.1:")
+	}
+	return false
+}
+
 // GetConsoleHTTPClient caches different http clients depending on the target endpoint while taking
 // in consideration CA certs stored in ${HOME}/.console/certs/CAs and ${HOME}/.minio/certs/CAs
 // If the target endpoint points to a loopback device, skip the TLS verification.
@@ -502,9 +509,7 @@ func GetConsoleHTTPClient(address string) *http.Client {
 		return client
 	}
 
-	isLocalAddress := address == "127.0.0.1" || strings.HasPrefix(address, "127.0.0.1:")
-
-	client = PrepareConsoleHTTPClient(isLocalAddress)
+	client = PrepareConsoleHTTPClient(isLocalAddress(address))
 	httpClients.Lock()
 	httpClients.m[address] = client
 	httpClients.Unlock()

restapi/client.go

@@ -21,7 +21,6 @@ import (
 	"errors"
 	"fmt"
 	"io"
-	"net/url"
 	"path"
 	"strings"
 	"time"
@@ -458,10 +457,7 @@ func newS3Config(endpoint, accessKey, secretKey, sessionToken string) *mc.Config
 	s3Config.SessionToken = sessionToken
 	s3Config.Signature = "S3v4"
 
-	insecure := false
-	if u, err := url.ParseRequestURI(endpoint); err == nil && u.Host != "" {
-		insecure = u.Host == "127.0.0.1" || strings.HasPrefix(u.Host, "127.0.0.1:")
-	}
+	insecure := isLocalAddress(endpoint)
 	s3Config.Insecure = insecure
 	s3Config.Transport = PrepareSTSClientTransport(insecure)