Skip to content

Commit 38c74bd

Browse files
authored
Reset config test and verb change to POST (#1986)
1 parent 117da11 commit 38c74bd

File tree

6 files changed

+68
-8
lines changed

6 files changed

+68
-8
lines changed

integration/config_test.go

Lines changed: 60 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -188,3 +188,63 @@ func Test_SetConfigAPI(t *testing.T) {
188188
})
189189
}
190190
}
191+
192+
func Test_ResetConfigAPI(t *testing.T) {
193+
assert := assert.New(t)
194+
195+
type args struct {
196+
name string
197+
}
198+
tests := []struct {
199+
name string
200+
args args
201+
expectedStatus int
202+
expectedError error
203+
}{
204+
{
205+
name: "Reset Config - Valid",
206+
args: args{
207+
name: "region",
208+
},
209+
expectedStatus: 200,
210+
expectedError: nil,
211+
},
212+
{
213+
name: "Reset Config - Invalid",
214+
args: args{
215+
name: "regiontest",
216+
},
217+
expectedStatus: 500,
218+
expectedError: nil,
219+
},
220+
}
221+
222+
for _, tt := range tests {
223+
t.Run(tt.name, func(t *testing.T) {
224+
client := &http.Client{
225+
Timeout: 3 * time.Second,
226+
}
227+
228+
requestDataPolicy := map[string]interface{}{}
229+
230+
requestDataJSON, _ := json.Marshal(requestDataPolicy)
231+
requestDataBody := bytes.NewReader(requestDataJSON)
232+
request, err := http.NewRequest(
233+
"POST", fmt.Sprintf("http://localhost:9090/api/v1/configs/%s/reset", tt.args.name), requestDataBody)
234+
if err != nil {
235+
log.Println(err)
236+
return
237+
}
238+
request.Header.Add("Cookie", fmt.Sprintf("token=%s", token))
239+
request.Header.Add("Content-Type", "application/json")
240+
response, err := client.Do(request)
241+
if err != nil {
242+
log.Println(err)
243+
return
244+
}
245+
if response != nil {
246+
assert.Equal(tt.expectedStatus, response.StatusCode, tt.name+" Failed")
247+
}
248+
})
249+
}
250+
}

portal-ui/src/screens/Console/NotificationEndpoints/CustomForms/ResetConfigurationModal.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ const ResetConfigurationModal = ({
5757
useEffect(() => {
5858
if (resetLoading) {
5959
api
60-
.invoke("GET", `/api/v1/configs/${configurationName}/reset`)
60+
.invoke("POST", `/api/v1/configs/${configurationName}/reset`)
6161
.then((res) => {
6262
setResetLoading(false);
6363
closeResetModalAndRefresh(true);

restapi/embedded_spec.go

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

restapi/operations/configuration/reset_config.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

restapi/operations/console_api.go

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

swagger-console.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2168,7 +2168,7 @@ paths:
21682168
- Configuration
21692169

21702170
/configs/{name}/reset:
2171-
get:
2171+
post:
21722172
summary: Configuration reset
21732173
operationId: ResetConfig
21742174
parameters:

0 commit comments

Comments
 (0)