Skip to content

Commit 9ed7983

Browse files
author
Benjamin Perez
committed
Fixed some issues with incomming data from mc
1 parent d9270f4 commit 9ed7983

File tree

7 files changed

+66
-75
lines changed

7 files changed

+66
-75
lines changed

portal-ui/bindata_assetfs.go

Lines changed: 54 additions & 54 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

portal-ui/src/screens/Console/Buckets/ListBuckets/ListBuckets.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -120,8 +120,8 @@ class ListBuckets extends React.Component<
120120
.then((res: BucketList) => {
121121
this.setState({
122122
loading: false,
123-
records: res.buckets,
124-
totalRecords: res.total,
123+
records: res.buckets || [],
124+
totalRecords: !res.buckets ? 0 : res.total,
125125
error: ""
126126
});
127127
// if we get 0 results, and page > 0 , go down 1 page

portal-ui/src/screens/Console/Buckets/ViewBucket/DeleteEvent.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ class DeleteEvent extends React.Component<
6767
if (bucketEvent == null) {
6868
return;
6969
}
70+
7071
this.setState({ deleteLoading: true }, () => {
7172
api
7273
.invoke(

portal-ui/src/screens/Console/Buckets/ViewBucket/ViewBucket.tsx

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -123,19 +123,16 @@ class ViewBucket extends React.Component<IViewBucketProps, IViewBucketState> {
123123
api
124124
.invoke("GET", `/api/v1/buckets/${bucketName}/events`)
125125
.then((res: BucketEventList) => {
126+
const events = res.events;
127+
126128
this.setState({
127129
loading: false,
128-
records: res.events,
130+
records: events || [],
129131
totalRecords: res.total,
130132
error: ""
131133
});
132134
// if we get 0 results, and page > 0 , go down 1 page
133-
if (
134-
(res.events === undefined ||
135-
res.events == null ||
136-
res.events.length === 0) &&
137-
page > 0
138-
) {
135+
if ((!events || res.events.length === 0) && page > 0) {
139136
const newPage = page - 1;
140137
this.setState({ page: newPage }, () => {
141138
this.fetchEvents();

portal-ui/src/screens/Console/Groups/Groups.tsx

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -129,10 +129,7 @@ const Groups = ({ classes }: IGroupsProps) => {
129129
resGroups = res.groups.sort(groupsSort);
130130
}
131131
setRecords(resGroups);
132-
let total = 0;
133-
if (res.total !== null) {
134-
total = res.total;
135-
}
132+
const total = !res.total ? 0 : res.total;
136133
setTotalRecords(total);
137134
setError("");
138135
isLoading(false);

portal-ui/src/screens/Console/Users/AddUser.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ class AddUserContent extends React.Component<
164164
addLoading: false,
165165
addError: "",
166166
accessKey: res.accessKey,
167-
selectedGroups: res.memberOf,
167+
selectedGroups: res.memberOf || [],
168168
enabled: res.status
169169
});
170170
})

portal-ui/src/screens/Console/Users/Users.tsx

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -128,19 +128,15 @@ class Users extends React.Component<IUsersProps, IUsersState> {
128128
api
129129
.invoke("GET", `/api/v1/users?offset=${offset}&limit=${rowsPerPage}`)
130130
.then((res: UsersList) => {
131+
const usersList = !res.users ? [] : res.users;
131132
this.setState({
132133
loading: false,
133-
records: res.users.sort(usersSort),
134+
records: usersList.sort(usersSort),
134135
totalRecords: res.users.length,
135136
error: ""
136137
});
137138
// if we get 0 results, and page > 0 , go down 1 page
138-
if (
139-
(res.users === undefined ||
140-
res.users == null ||
141-
res.users.length === 0) &&
142-
page > 0
143-
) {
139+
if ((!usersList || res.users.length === 0) && page > 0) {
144140
const newPage = page - 1;
145141
this.setState({ page: newPage }, () => {
146142
this.fetchRecords();

0 commit comments

Comments
 (0)