Skip to content

Commit c30f1ce

Browse files
authored
Policies Routing Wildcard (#1041)
* Policies Routing Wildcard Signed-off-by: Daniel Valdivia <[email protected]> * Remove Console.log Signed-off-by: Daniel Valdivia <[email protected]>
1 parent a060ddb commit c30f1ce

File tree

4 files changed

+17
-9
lines changed

4 files changed

+17
-9
lines changed

pkg/acl/endpoints.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ var (
2727
usersDetail = "/users/:userName+"
2828
groups = "/groups"
2929
iamPolicies = "/policies"
30-
policiesDetail = "/policies/:policyName"
30+
policiesDetail = "/policies/*"
3131
dashboard = "/dashboard"
3232
metrics = "/metrics"
3333
profiling = "/profiling"

portal-ui/src/screens/Console/Console.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,7 @@ const Console = ({
253253
},
254254
{
255255
component: Policies,
256-
path: "/policies/:policyName",
256+
path: "/policies/*",
257257
},
258258
{
259259
component: Policies,

portal-ui/src/screens/Console/Policies/Policies.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,8 @@ const Users = () => {
2222
return (
2323
<Router history={history}>
2424
<Switch>
25-
<Route path="/policies/:policyName" component={PolicyDetails} />
25+
<Route path="/policies/" exact={true} component={ListPolicies} />
26+
<Route path="/policies/*" component={PolicyDetails} />
2627
<Route path="/" component={ListPolicies} />
2728
<Route component={NotFoundPage} />
2829
</Switch>

portal-ui/src/screens/Console/Policies/PolicyDetails.tsx

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -192,9 +192,7 @@ const PolicyDetails = ({
192192
const [userList, setUserList] = useState<string[]>([]);
193193
const [groupList, setGroupList] = useState<string[]>([]);
194194
const [addLoading, setAddLoading] = useState<boolean>(false);
195-
const [policyName, setPolicyName] = useState<string>(
196-
match.params["policyName"]
197-
);
195+
const [policyName, setPolicyName] = useState<string>(match.params[0]);
198196
const [policyDefinition, setPolicyDefinition] = useState<string>("");
199197
const [loadingPolicy, setLoadingPolicy] = useState<boolean>(true);
200198
const [filterUsers, setFilterUsers] = useState<string>("");
@@ -227,7 +225,10 @@ const PolicyDetails = ({
227225
const loadUsersForPolicy = () => {
228226
if (loadingUsers) {
229227
api
230-
.invoke("GET", `/api/v1/policies/${policyName}/users`)
228+
.invoke(
229+
"GET",
230+
`/api/v1/policies/${encodeURIComponent(policyName)}/users`
231+
)
231232
.then((result: any) => {
232233
setUserList(result);
233234
setLoadingUsers(false);
@@ -241,7 +242,10 @@ const PolicyDetails = ({
241242
const loadGroupsForPolicy = () => {
242243
if (loadingGroups) {
243244
api
244-
.invoke("GET", `/api/v1/policies/${policyName}/groups`)
245+
.invoke(
246+
"GET",
247+
`/api/v1/policies/${encodeURIComponent(policyName)}/groups`
248+
)
245249
.then((result: any) => {
246250
setGroupList(result);
247251
setLoadingGroups(false);
@@ -255,7 +259,10 @@ const PolicyDetails = ({
255259
const loadPolicyDetails = () => {
256260
if (loadingPolicy) {
257261
api
258-
.invoke("GET", `/api/v1/policy?name=${policyName}`)
262+
.invoke(
263+
"GET",
264+
`/api/v1/policy?name=${encodeURIComponent(policyName)}`
265+
)
259266
.then((result: any) => {
260267
if (result) {
261268
setPolicy(result);

0 commit comments

Comments
 (0)