From f755532c6c559718a38f42b084ce1a5a84ab75c7 Mon Sep 17 00:00:00 2001 From: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com> Date: Fri, 21 Jan 2022 17:05:42 -0800 Subject: [PATCH] Menu Adjustments: Watch to Monitoring. Tiers to Settings. Notifications to Settings. Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com> --- .github/workflows/permissions.yml | 4 +- portal-ui/package.json | 2 +- portal-ui/src/common/BackLink.tsx | 2 +- .../src/common/SecureComponent/permissions.ts | 18 +- .../Buckets/ListBuckets/BucketListItem.tsx | 3 +- .../FormComponents/common/styleLibrary.ts | 4 +- .../ConfigurationOptions.tsx | 9 +- .../screens/Console/HealthInfo/HealthInfo.tsx | 3 +- .../screens/Console/Menu/ConsoleMenuList.tsx | 44 +--- portal-ui/src/screens/Console/Menu/Menu.tsx | 82 ++++--- .../AddNotificationEndpoint.tsx | 2 +- .../NotificationTypeSelector.tsx | 2 +- portal-ui/src/screens/Console/Watch/Watch.tsx | 2 +- portal-ui/tests/constants/timestamp.txt | 2 +- portal-ui/tests/permissions/admin.ts | 56 ++--- .../tests/permissions/bucketAssignPolicy.ts | 20 +- portal-ui/tests/permissions/bucketRead.ts | 14 +- portal-ui/tests/permissions/bucketWrite.ts | 17 +- portal-ui/tests/permissions/diagnostics.ts | 14 +- portal-ui/tests/permissions/groups.ts | 42 +++- portal-ui/tests/permissions/heal.ts | 53 +++-- .../permissions/notificationEndpoints.ts | 17 +- portal-ui/tests/permissions/settings.ts | 14 +- portal-ui/tests/permissions/tiers.ts | 14 +- portal-ui/tests/permissions/watch.ts | 23 +- portal-ui/tests/utils/elements-menu.ts | 27 ++- portal-ui/tests/utils/elements.ts | 47 ++-- portal-ui/tests/utils/functions.ts | 46 +++- portal-ui/yarn.lock | 206 ++++++++++++++++-- 29 files changed, 510 insertions(+), 279 deletions(-) diff --git a/.github/workflows/permissions.yml b/.github/workflows/permissions.yml index d550bf41d7..23a4ff3c24 100644 --- a/.github/workflows/permissions.yml +++ b/.github/workflows/permissions.yml @@ -1,4 +1,4 @@ -name: "Front-End Permission Tests" +name: "UI" on: pull_request: @@ -10,7 +10,7 @@ on: jobs: permissions: - name: Front-End Permission Tests + name: Permissions Tests runs-on: ${{ matrix.os }} strategy: matrix: diff --git a/portal-ui/package.json b/portal-ui/package.json index d5469e174a..01cc1490aa 100644 --- a/portal-ui/package.json +++ b/portal-ui/package.json @@ -58,7 +58,7 @@ "redux-thunk": "^2.3.0", "styled-components": "^5.3.1", "superagent": "^6.1.0", - "testcafe": "^1.17.1", + "testcafe": "^1.18.2", "typeface-roboto": "^0.0.75", "use-debounce": "^5.0.1", "websocket": "^1.0.31" diff --git a/portal-ui/src/common/BackLink.tsx b/portal-ui/src/common/BackLink.tsx index 74dca00065..0e3deda774 100644 --- a/portal-ui/src/common/BackLink.tsx +++ b/portal-ui/src/common/BackLink.tsx @@ -27,7 +27,7 @@ const styles = (theme: Theme) => display: "flex", alignItems: "center", textDecoration: "none", - maxWidth: "250px", + maxWidth: "300px", padding: "2rem 2rem 0rem 2rem", color: theme.palette.primary.light, fontSize: ".8rem", diff --git a/portal-ui/src/common/SecureComponent/permissions.ts b/portal-ui/src/common/SecureComponent/permissions.ts index 59cf6ee367..966d6d95c3 100644 --- a/portal-ui/src/common/SecureComponent/permissions.ts +++ b/portal-ui/src/common/SecureComponent/permissions.ts @@ -161,6 +161,7 @@ export const IAM_PAGES = { METRICS: "/tools/metrics", DASHBOARD: "/tools/dashboard", TOOLS_HEAL: "/tools/heal", + TOOLS_WATCH: "/tools/watch", /* Health */ HEALTH: "/health", @@ -171,23 +172,22 @@ export const IAM_PAGES = { TOOLS_SPEEDTEST: "/support/speedtest", CALL_HOME: "/support/call-home", PROFILE: "/support/profile", - TOOLS_WATCH: "/support/inspect", /** License **/ LICENSE: "/license", /* Settings **/ - SETTINGS: "/settings", - SETTINGS_VIEW: "/settings/:option", + SETTINGS: "/settings/configurations", + SETTINGS_VIEW: "/settings/configurations/:option", /* Documentation **/ DOCUMENTATION: "/documentation", /* TBD ? */ - NOTIFICATIONS_ENDPOINTS: "/lambda/notification-endpoints", - NOTIFICATIONS_ENDPOINTS_ADD: "/lambda/notification-endpoints/add", + NOTIFICATIONS_ENDPOINTS: "/settings/notification-endpoints", + NOTIFICATIONS_ENDPOINTS_ADD: "/settings/notification-endpoints/add", NOTIFICATIONS_ENDPOINTS_ADD_SERVICE: - "/lambda/notification-endpoints/add/:service", - TIERS: "/tiers", - TIERS_ADD: "/tiers/add", - TIERS_ADD_SERVICE: "/tiers/add/:service", + "/settings/notification-endpoints/add/:service", + TIERS: "/settings/tiers", + TIERS_ADD: "/settings/tiers/add", + TIERS_ADD_SERVICE: "/settings/tiers/add/:service", /* Operator */ TENANTS: "/tenants", diff --git a/portal-ui/src/screens/Console/Buckets/ListBuckets/BucketListItem.tsx b/portal-ui/src/screens/Console/Buckets/ListBuckets/BucketListItem.tsx index 47dbd030aa..e5f4cc5082 100644 --- a/portal-ui/src/screens/Console/Buckets/ListBuckets/BucketListItem.tsx +++ b/portal-ui/src/screens/Console/Buckets/ListBuckets/BucketListItem.tsx @@ -35,6 +35,7 @@ import { } from "../../../../common/SecureComponent/permissions"; import SecureComponent from "../../../../common/SecureComponent/SecureComponent"; import RBIconButton from "../BucketDetails/SummaryItems/RBIconButton"; +import clsx from "clsx"; const styles = (theme: Theme) => createStyles({ @@ -195,7 +196,7 @@ const BucketListItem = ({ }; return ( - + diff --git a/portal-ui/src/screens/Console/Common/FormComponents/common/styleLibrary.ts b/portal-ui/src/screens/Console/Common/FormComponents/common/styleLibrary.ts index 63e22f769d..363dcb400e 100644 --- a/portal-ui/src/screens/Console/Common/FormComponents/common/styleLibrary.ts +++ b/portal-ui/src/screens/Console/Common/FormComponents/common/styleLibrary.ts @@ -1273,5 +1273,5 @@ export const TableRowPredefStyles: any = { color: "#ACACAC", backgroundColor: "#FDFDFD", fontStyle: "italic", - } -} + }, +}; diff --git a/portal-ui/src/screens/Console/Configurations/ConfigurationPanels/ConfigurationOptions.tsx b/portal-ui/src/screens/Console/Configurations/ConfigurationPanels/ConfigurationOptions.tsx index 10cbf93697..fef87b8c57 100644 --- a/portal-ui/src/screens/Console/Configurations/ConfigurationPanels/ConfigurationOptions.tsx +++ b/portal-ui/src/screens/Console/Configurations/ConfigurationPanels/ConfigurationOptions.tsx @@ -37,6 +37,7 @@ import get from "lodash/get"; import ScreenTitle from "../../Common/ScreenTitle/ScreenTitle"; import withSuspense from "../../Common/Components/withSuspense"; +import { IAM_PAGES } from "../../../../common/SecureComponent/permissions"; const ConfigurationForm = withSuspense( React.lazy(() => import("./ConfigurationForm")) @@ -64,7 +65,7 @@ const styles = (theme: Theme) => }); const getRoutePath = (path: string) => { - return `/settings/${path}`; + return `${IAM_PAGES.SETTINGS}/${path}`; }; const ConfigurationOptions = ({ classes, match }: IConfigurationOptions) => { @@ -95,12 +96,12 @@ const ConfigurationOptions = ({ classes, match }: IConfigurationOptions) => { ))} - - + + diff --git a/portal-ui/src/screens/Console/HealthInfo/HealthInfo.tsx b/portal-ui/src/screens/Console/HealthInfo/HealthInfo.tsx index 0f9eb25fbb..d3c8d2e4f6 100644 --- a/portal-ui/src/screens/Console/HealthInfo/HealthInfo.tsx +++ b/portal-ui/src/screens/Console/HealthInfo/HealthInfo.tsx @@ -231,7 +231,7 @@ const HealthInfo = ({ return ( - + @@ -286,6 +286,7 @@ const HealthInfo = ({ )}