Merge pull request #3167 from mitre/issue-3132

filter 0-score facts from operation source

Author: elegantmoose

app/objects/c_operation.py

@@ -191,6 +191,7 @@ async def all_facts(self):
         seeded_facts = []
         if self.source:
             seeded_facts = await data_svc_handle.get_facts_from_source(self.source.id)
+            seeded_facts = [f for f in seeded_facts if f.score > 0]
         learned_facts = await knowledge_svc_handle.get_facts(criteria=dict(source=self.id))
         learned_facts = [f for f in learned_facts if f.score > 0]
         return seeded_facts + learned_facts

tests/objects/test_operation.py

@@ -190,7 +190,7 @@ def _make_agent(platform='windows', trusted=True, executor_name='psh'):
 
 @pytest.fixture
 def op_with_learning_and_seeded(ability, adversary, operation_agent, parse_datestring):
-    sc = Source(id='3124', name='test', facts=[Fact(trait='domain.user.name', value='bob')])
+    sc = Source(id='3124', name='test', facts=[Fact(trait='domain.user.name', value='bob'), Fact(trait='domain.user.name', value='jane', score=0)])
     op = Operation(id='6789', name='testC', agents=[], adversary=adversary, source=sc, use_learning_parsers=True)
     # patch operation to make it 'realistic'
     op.start = parse_datestring(OP_START_TIME)