fix(mjml-table): updated return for numericValue #2995

dazgreer · dazgreer · commit 3703f32e506c · 2025-10-16T10:31:09.000+02:00
fixes #2995
diff --git a/packages/mjml-table/src/index.js b/packages/mjml-table/src/index.js
@@ -74,7 +74,7 @@ export default class MjTable extends BodyComponent {
   hasCellspacing() {
     const cellspacing = this.getAttribute('cellspacing')
     const numericValue = parseFloat(String(cellspacing).replace(/[^\d.]/g, ''))
-    return numericValue > 0 && typeof cellspacing !== 'undefined'
+    return !Number.isNaN(numericValue) && numericValue > 0
   }
 
   render() {

Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ export default class MjTable extends BodyComponent {`
`74`	`74`	`hasCellspacing() {`
`75`	`75`	`const cellspacing = this.getAttribute('cellspacing')`
`76`	`76`	`const numericValue = parseFloat(String(cellspacing).replace(/[^\d.]/g, ''))`
`77`		`- return numericValue > 0 && typeof cellspacing !== 'undefined'`
	`77`	`+ return !Number.isNaN(numericValue) && numericValue > 0`
`78`	`78`	`}`
`79`	`79`
`80`	`80`	`render() {`