Skip to content

[Metrics] Add missing fields in Reset #2574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2024
Merged

[Metrics] Add missing fields in Reset #2574

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions cpp/serve/metrics.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,13 +130,11 @@ picojson::object EngineMetrics::AsJSON() const {
const TimeCost& item = time_list[i];
if (item.count == 0) continue;
std::ostringstream label_mean;
label_mean << "mean"
<< "{batch_size=" << i << "}";
label_mean << "mean{batch_size=" << i << "}";
double mean = item.sum / item.count;
result[label_mean.str()] = picojson::value(mean);
std::ostringstream label_count;
label_count << "count"
<< "{batch_size=" << i << "}";
label_count << "count{batch_size=" << i << "}";
result[label_count.str()] = picojson::value(item.count);
}
return picojson::value(result);
Expand Down Expand Up @@ -164,9 +162,12 @@ std::string EngineMetrics::AsUsageJSONStr() const {
void EngineMetrics::Reset() {
engine_prefill_time_sum = 0.0;
engine_decode_time_sum = 0.0;
engine_jump_forward_time_sum = 0;
prompt_tokens_sum = 0;
prefill_tokens_sum = 0;
completion_tokens_sum = 0;
prefill_tokens_sum = 0;
decode_tokens_sum = 0;
jump_forward_tokens_sum = 0;
last_finished_request.Reset();
spec_decode.Reset();
decode_time_by_batch_size.clear();
Expand Down