Skip to content

Commit 89bdd06

Browse files
jophishjeanregisser
authored andcommitted
feat(send): Remove CPV from send flow (#12)
### Description For [RET-1146](https://linear.app/valora/issue/RET-1146/[shell]-update-sendreceive-flow). Removes contact + CPV + secure send functionality from the send flow. This is accomplished _not_ by gutting the wallet of anything related to CPV, but instead by removing any possibility of accessing a feature which interacts with the CPV system. This is a bit of a tradeoff, as it leads to a decent chunk of unused code just kinda hanging around, but I opted for this approach for the following reasons: * Actually removing all the CPV-related code would make it very difficult and cumbersome to re-introduce it if we ever wanted to add CPV support to Mobile Stack, which is a real possibility. * Removing all the code would introduce a huge diff between the MS Runtime and the Valora wallet, which we'd really like to avoid if we can. The CPV system touches a lot of parts of the app. * This approach is just much easier than the alternative; gutting the app of CPV code would have been a much greater task. ### Test plan Unit tests updated (or skipped, where appropriate). See video below: https://github.com/user-attachments/assets/94f24f05-a791-4392-8893-e820aaed1232 ### Related issues - Fixes [RET-1146](https://linear.app/valora/issue/RET-1146/[shell]-update-sendreceive-flow). ### Backwards compatibility Yes. ### Network scalability If a new NetworkId and/or Network are added in the future, the changes in this PR will: - [x] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)
1 parent d78e3e4 commit 89bdd06

23 files changed

+124
-178
lines changed

knip.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ const config: KnipConfig = {
3333
'@types/jest',
3434
'husky',
3535
],
36-
ignore: ['src/utils/inputValidation.ts', 'src/utils/country.json'],
36+
ignore: ['src/utils/inputValidation.ts', 'src/utils/country.json', 'src/icons/Social.tsx'],
3737
}
3838

3939
export default config

locales/base/translation.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1049,7 +1049,7 @@
10491049
"inviteVerifyPayment": "Invite & Confirm Payment",
10501050
"noResultsFor": "No results for",
10511051
"noContacts": "No contacts",
1052-
"searchForSomeone": "Search for someone using their name, phone number, or address",
1052+
"searchForSomeone": "Search for someone using their wallet address",
10531053
"sentPayment": "Sent Payment",
10541054
"sentEscrowPayment": "Sent Escrow Payment",
10551055
"mobileNumber": "Mobile #",
@@ -2120,7 +2120,7 @@
21202120
"importButton": "Import"
21212121
},
21222122
"sendSelectRecipient": {
2123-
"searchText": "Search by name, phone, wallet...",
2123+
"searchText": "Search by wallet address",
21242124
"paste": "Paste from clipboard",
21252125
"title": "Select a recipient",
21262126
"contactsTitle": "Select a contact",

locales/de/translation.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1047,7 +1047,7 @@
10471047
"inviteVerifyPayment": "Einladen & Zahlung bestätigen",
10481048
"noResultsFor": "Keine Ergebnisse für",
10491049
"noContacts": "Keine Kontakte",
1050-
"searchForSomeone": "Suche nach jemandem mit Namen, Telefonnummer oder Adresse",
1050+
"searchForSomeone": "Suchen Sie nach jemandem, indem Sie dessen Wallet-Adresse verwenden",
10511051
"sentPayment": "Zahlung gesendet",
10521052
"sentEscrowPayment": "Escrow-Zahlung gesendet",
10531053
"mobileNumber": "Handy #",
@@ -2118,7 +2118,7 @@
21182118
"importButton": "Importieren"
21192119
},
21202120
"sendSelectRecipient": {
2121-
"searchText": "Suche nach Name, Telefon, Wallet ...",
2121+
"searchText": "Suche nach Wallet-Adresse",
21222122
"paste": "Aus Zwischenablage einfügen",
21232123
"title": "Einen Empfänger auswählen",
21242124
"contactsTitle": "Kontakt wählen",
@@ -2708,4 +2708,4 @@
27082708
"duration_yearMonth_other": "{{count}} Jahre, {{count2}} Monate",
27092709
"celoDollarAmount": "<0></0> Celo Dollar",
27102710
"celoDollarAmount_plural": "<0></0> Celo Dollars"
2711-
}
2711+
}

locales/en-US/translation.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1047,7 +1047,7 @@
10471047
"inviteVerifyPayment": "Invite & Confirm Payment",
10481048
"noResultsFor": "No results for",
10491049
"noContacts": "No contacts",
1050-
"searchForSomeone": "Search for someone using their name, phone number, or address",
1050+
"searchForSomeone": "Search for someone using their wallet address",
10511051
"sentPayment": "Sent Payment",
10521052
"sentEscrowPayment": "Sent Escrow Payment",
10531053
"mobileNumber": "Mobile #",
@@ -2118,7 +2118,7 @@
21182118
"importButton": "Import"
21192119
},
21202120
"sendSelectRecipient": {
2121-
"searchText": "Search by name, phone, wallet...",
2121+
"searchText": "Search by wallet address",
21222122
"paste": "Paste from clipboard",
21232123
"title": "Select a recipient",
21242124
"contactsTitle": "Select a contact",
@@ -2708,4 +2708,4 @@
27082708
"duration_yearMonth_other": "{{count}} years, {{count2}} months",
27092709
"celoDollarAmount": "<0></0> Celo Dollar",
27102710
"celoDollarAmount_plural": "<0></0> Celo Dollars"
2711-
}
2711+
}

locales/es-419/translation.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1047,7 +1047,7 @@
10471047
"inviteVerifyPayment": "Invitar y confirmar el pago",
10481048
"noResultsFor": "Sin resultados para",
10491049
"noContacts": "No se encontraron contactos",
1050-
"searchForSomeone": "Busca a alguien por su nombre, número de teléfono o dirección",
1050+
"searchForSomeone": "Buscar a alguien usando su dirección de billetera",
10511051
"sentPayment": "Pago enviado",
10521052
"sentEscrowPayment": "Pago de garantía enviado",
10531053
"mobileNumber": "Número de teléfono",
@@ -2118,7 +2118,7 @@
21182118
"importButton": "Importar"
21192119
},
21202120
"sendSelectRecipient": {
2121-
"searchText": "Busca por nombre, teléfono, wallet...",
2121+
"searchText": "Busca por wallet",
21222122
"paste": "Pegar desde el portapapeles",
21232123
"title": "Selecciona un destinatario",
21242124
"contactsTitle": "Selecciona un contacto",
@@ -2708,4 +2708,4 @@
27082708
"duration_yearMonth_other": "{{count}} años, {{count2}} meses",
27092709
"celoDollarAmount": "<0></0> Celo Dollar",
27102710
"celoDollarAmount_plural": "<0></0> Celo Dollars"
2711-
}
2711+
}

locales/fr-FR/translation.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1047,7 +1047,7 @@
10471047
"inviteVerifyPayment": "Invitez et confirmez le paiement",
10481048
"noResultsFor": "Aucun résultat pour",
10491049
"noContacts": "Aucun contact",
1050-
"searchForSomeone": "Recherchez quelqu'un en utilisant son nom, son numéro de téléphone ou son adresse",
1050+
"searchForSomeone": "Rechercher quelqu'un en utilisant son adresse de portefeuille",
10511051
"sentPayment": "Paiement envoyé",
10521052
"sentEscrowPayment": "Paiement au prestataire de séquestre envoyé",
10531053
"mobileNumber": "N° de portable",
@@ -2118,7 +2118,7 @@
21182118
"importButton": "Importation"
21192119
},
21202120
"sendSelectRecipient": {
2121-
"searchText": "Recherchez par nom, téléphone, portefeuille...",
2121+
"searchText": "Rechercher par adresse de portefeuille",
21222122
"paste": "Coller depuis le presse-papiers",
21232123
"title": "Sélectionnez un destinataire",
21242124
"contactsTitle": "Sélectionnez un contact",
@@ -2708,4 +2708,4 @@
27082708
"duration_yearMonth_other": "{{count}} ans, {{count2}} mois",
27092709
"celoDollarAmount": "<0></0> Celo Dollar",
27102710
"celoDollarAmount_plural": "<0></0> Celo Dollars"
2711-
}
2711+
}

locales/it-IT/translation.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1047,7 +1047,7 @@
10471047
"inviteVerifyPayment": "Invita e conferma pagamento",
10481048
"noResultsFor": "Nessun risultato per",
10491049
"noContacts": "Nessun contatto",
1050-
"searchForSomeone": "Cerca qualcuno tramite il suo nome, numero telefonico o indirizzo",
1050+
"searchForSomeone": "Cerca qualcuno utilizzando l'indirizzo del suo portafoglio",
10511051
"sentPayment": "Pagamento inviato",
10521052
"sentEscrowPayment": "Pagamento per deposito in garanzia inviato",
10531053
"mobileNumber": "N. di cellulare",
@@ -2118,7 +2118,7 @@
21182118
"importButton": "Importa"
21192119
},
21202120
"sendSelectRecipient": {
2121-
"searchText": "Cerca per nome, numero telefonico, portafoglio...",
2121+
"searchText": "Cerca per indirizzo del portafoglio",
21222122
"paste": "Incolla dagli Appunti",
21232123
"title": "Seleziona un destinatario",
21242124
"contactsTitle": "Seleziona un contatto",
@@ -2708,4 +2708,4 @@
27082708
"duration_yearMonth_other": "{{count}} anni, {{count2}} mesi",
27092709
"celoDollarAmount": "<0></0> Celo Dollar",
27102710
"celoDollarAmount_plural": "<0></0> Celo Dollar"
2711-
}
2711+
}

locales/pl-PL/translation.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1051,7 +1051,7 @@
10511051
"inviteVerifyPayment": "Zaproś i potwierdź płatność",
10521052
"noResultsFor": "Brak wyników dla",
10531053
"noContacts": "Brak kontaktów",
1054-
"searchForSomeone": "Wyszukaj kontakt po nazwie, numerze telefonu lub adresie",
1054+
"searchForSomeone": "Wyszukaj osobę, korzystając z adresu jej portfela",
10551055
"sentPayment": "Przesłana płatność",
10561056
"sentEscrowPayment": "Przesłana płatność Escrow",
10571057
"mobileNumber": "Nr telefonu komórkowego",
@@ -2122,7 +2122,7 @@
21222122
"importButton": "Import"
21232123
},
21242124
"sendSelectRecipient": {
2125-
"searchText": "Szukaj według nazwy, telefonu, portfela",
2125+
"searchText": "Szukaj według adresu portfela",
21262126
"paste": "Wklej ze schowka",
21272127
"title": "Wybierz odbiorcę",
21282128
"contactsTitle": "Wybierz kontakt",
@@ -2714,4 +2714,4 @@
27142714
"celoDollarAmount_1": "&amp;lt;0&amp;gt;&amp;lt;/0&amp;gt; Celo Dolary",
27152715
"celoDollarAmount_2": "&amp;lt;0&amp;gt;&amp;lt;/0&amp;gt; Celo Dolarów",
27162716
"celoDollarAmount_3": "&amp;lt;0&amp;gt;&amp;lt;/0&amp;gt; Celo Dolara"
2717-
}
2717+
}

locales/pt-BR/translation.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1047,7 +1047,7 @@
10471047
"inviteVerifyPayment": "Convidar e confirmar pagamento",
10481048
"noResultsFor": "Sem resultados para",
10491049
"noContacts": "Não há contatos",
1050-
"searchForSomeone": "Pesquise alguém por nome, número de celular ou endereço de conta",
1050+
"searchForSomeone": "Procure alguém usando o endereço da carteira",
10511051
"sentPayment": "Pagamento enviado",
10521052
"sentEscrowPayment": "Pagamento de caução enviado",
10531053
"mobileNumber": "Número do celular",
@@ -2118,7 +2118,7 @@
21182118
"importButton": "Importar"
21192119
},
21202120
"sendSelectRecipient": {
2121-
"searchText": "Pesquise por nome, telefone, carteira...",
2121+
"searchText": "Pesquise por endereço de carteira",
21222122
"paste": "Colar da área de transferência",
21232123
"title": "Selecione um destinatário",
21242124
"contactsTitle": "Selecione um contato",
@@ -2708,4 +2708,4 @@
27082708
"duration_yearMonth_other": "{{count}} anos, {{count2}} meses",
27092709
"celoDollarAmount": "<0></0> Celo Dollar",
27102710
"celoDollarAmount_plural": "<0></0> Celo Dollars"
2711-
}
2711+
}

locales/ru-RU/translation.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1051,7 +1051,7 @@
10511051
"inviteVerifyPayment": "Пригласить и подтвердить платеж",
10521052
"noResultsFor": "Нет результатов для",
10531053
"noContacts": "Нет контактов",
1054-
"searchForSomeone": "Поиск лиц по имени, номеру телефона или адресу",
1054+
"searchForSomeone": "Найдите кого-нибудь по адресу его кошелька",
10551055
"sentPayment": "Отправленный платеж",
10561056
"sentEscrowPayment": "Отправленный эскроу-платеж",
10571057
"mobileNumber": "Мобильный номер",
@@ -2122,7 +2122,7 @@
21222122
"importButton": "Импорт"
21232123
},
21242124
"sendSelectRecipient": {
2125-
"searchText": "Поиск по имени, телефону, кошельку...",
2125+
"searchText": "Поиск по адресу кошелька",
21262126
"paste": "Вставить из буфера обмена",
21272127
"title": "Выберите получателя",
21282128
"contactsTitle": "Выберите контакт",
@@ -2714,4 +2714,4 @@
27142714
"celoDollarAmount_1": "<0></0> Celo Dollars",
27152715
"celoDollarAmount_2": "<0></0> Celo Dollars",
27162716
"celoDollarAmount_3": "<0></0> Celo Dollars"
2717-
}
2717+
}

0 commit comments

Comments
 (0)