Skip to content

Conversation

@NoahStapp
Copy link
Contributor

No description provided.

@NoahStapp NoahStapp requested a review from a team as a code owner November 14, 2023 18:08
@NoahStapp NoahStapp requested review from blink1073 and removed request for a team November 14, 2023 18:08

"""Version-related data for motor."""
version_tuple = (3, 4, 0, ".dev0")
version_tuple = (3, 3, 2, ".dev0")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove the .dev0 portion.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not have been removed until all the 3.3.2 commits are merged. Stilling waiting on #233 and #240 IIUC.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(For next time). No need to change it now.

@NoahStapp NoahStapp requested a review from blink1073 November 14, 2023 18:17
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NoahStapp NoahStapp merged commit 593b57f into mongodb:master Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants