Skip to content

MIGRATION-467 Replace deprecated slaveOk logic with mongosh-compatible read preference #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

MIGRATION-467 Replace deprecated slaveOk logic with mongosh-compatible read preference #160

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions getMongoData/getMongoData.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -651,12 +651,19 @@ function printShardOrReplicaSetInfo() {
return true;
} else if (state != "standalone" && state != "configsvr") {
if (state == "SECONDARY" || state == 2) {
if (rs.secondaryOk) {
rs.secondaryOk();
// Detect mongosh (Node-style 'process' exists)
const isMongoSh = (typeof process !== 'undefined' &&
process.release && process.release.name === 'node');

if (isMongoSh) {
// mongosh: avoid deprecation noise
db.getMongo().setReadPref("primaryPreferred");
} else if (typeof rs !== "undefined" && typeof rs.secondaryOk === "function") {
rs.secondaryOk();
} else {
rs.slaveOk();
throw new Error("Could not enable reads on secondary in legacy mongo shell");
}
}
}
printReplicaSetInfo();
}
return false;
Expand Down