Skip to content

Conversation

@mattsb42-aws
Copy link
Contributor

As discussed in #129 and #99, this project currently lacks a changelog. I'm putting this here as a starting point for resolving that.

@codecov
Copy link

codecov bot commented Apr 8, 2019

Codecov Report

Merging #132 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #132   +/-   ##
=======================================
  Coverage   96.52%   96.52%           
=======================================
  Files          14       14           
  Lines        1065     1065           
=======================================
  Hits         1028     1028           
  Misses         37       37

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d2e03f...acf9c9d. Read the comment docs.

@zejn
Copy link
Collaborator

zejn commented Apr 9, 2019

The changelog itself looks great, with one comment.

Looks to me that the Python "3.7" testing actually happens in Python 3.5. The testing environment itself is 3.7, but the tox command uses 3.5. See here https://travis-ci.org/mpdavis/python-jose/jobs/517511343#L237

@mattsb42-aws
Copy link
Contributor Author

doh...that was a copy-paste fail on my part.

@mattsb42-aws mattsb42-aws mentioned this pull request Apr 9, 2019
@mattsb42-aws
Copy link
Contributor Author

#135 created to fix that

@zejn
Copy link
Collaborator

zejn commented Apr 9, 2019

Thank you for this contribution, looks awesome now.

@zejn zejn merged commit 03707b1 into mpdavis:master Apr 9, 2019
@mattsb42-aws mattsb42-aws deleted the changelog branch April 9, 2019 19:46
@blag blag mentioned this pull request Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants