Convert to a YAML editor

Signed-off-by: Ettore Di Giacinto <[email protected]>

Author: mudler

core/http/endpoints/localai/edit_model.go

@@ -4,13 +4,10 @@ import (
 	"fmt"
 	"os"
 	"path/filepath"
-	"regexp"
-	"strconv"
-	"strings"
 
 	"github.com/gofiber/fiber/v2"
 	"github.com/mudler/LocalAI/core/config"
-	"github.com/mudler/LocalAI/pkg/downloader"
+	"github.com/mudler/LocalAI/pkg/utils"
 	"gopkg.in/yaml.v3"
 )
 
@@ -28,6 +25,14 @@ func GetEditModelPage(cl *config.BackendConfigLoader, appConfig *config.Applicat
 
 		// Load the existing configuration
 		configPath := filepath.Join(appConfig.ModelPath, modelName+".yaml")
+		if err := utils.InTrustedRoot(configPath, appConfig.ModelPath); err != nil {
+			response := ModelResponse{
+				Success: false,
+				Error:   "Model configuration not trusted: " + err.Error(),
+			}
+			return c.Status(404).JSON(response)
+		}
+
 		if _, err := os.Stat(configPath); os.IsNotExist(err) {
 			response := ModelResponse{
 				Success: false,
@@ -56,7 +61,7 @@ func GetEditModelPage(cl *config.BackendConfigLoader, appConfig *config.Applicat
 		}
 
 		// Render the edit page with the current configuration
-		return c.Render("views/edit-model", fiber.Map{
+		return c.Render("views/model-editor", fiber.Map{
 			"ModelName": modelName,
 			"Config":    backendConfig,
 		})
@@ -73,11 +78,22 @@ func EditModelEndpoint(cl *config.BackendConfigLoader, appConfig *config.Applica
 			})
 		}
 
-		var req ModelRequest
-		if err := c.BodyParser(&req); err != nil {
+		// Get the raw body as YAML
+		body := c.Body()
+		if len(body) == 0 {
 			response := ModelResponse{
 				Success: false,
-				Error:   "Failed to parse request: " + err.Error(),
+				Error:   "Request body is empty",
+			}
+			return c.Status(400).JSON(response)
+		}
+
+		// Unmarshal YAML directly into BackendConfig
+		var req config.BackendConfig
+		if err := yaml.Unmarshal(body, &req); err != nil {
+			response := ModelResponse{
+				Success: false,
+				Error:   "Failed to parse YAML: " + err.Error(),
 			}
 			return c.Status(400).JSON(response)
 		}
@@ -93,6 +109,14 @@ func EditModelEndpoint(cl *config.BackendConfigLoader, appConfig *config.Applica
 
 		// Load the existing configuration
 		configPath := filepath.Join(appConfig.ModelPath, modelName+".yaml")
+		if err := utils.InTrustedRoot(configPath, appConfig.ModelPath); err != nil {
+			response := ModelResponse{
+				Success: false,
+				Error:   "Model configuration not trusted: " + err.Error(),
+			}
+			return c.Status(404).JSON(response)
+		}
+
 		if _, err := os.Stat(configPath); os.IsNotExist(err) {
 			response := ModelResponse{
 				Success: false,
@@ -111,146 +135,25 @@ func EditModelEndpoint(cl *config.BackendConfigLoader, appConfig *config.Applica
 			return c.Status(500).JSON(response)
 		}
 
-		var existingConfig config.BackendConfig
-		if err := yaml.Unmarshal(configData, &existingConfig); err != nil {
+		var backendConfig config.BackendConfig
+		if err := yaml.Unmarshal(configData, &backendConfig); err != nil {
 			response := ModelResponse{
 				Success: false,
 				Error:   "Failed to parse existing configuration: " + err.Error(),
 			}
 			return c.Status(500).JSON(response)
 		}
 
-		// Update the configuration with new values
-		backendConfig := &existingConfig
-		backendConfig.Backend = req.Backend
-		backendConfig.Description = req.Description
-		backendConfig.Usage = req.Usage
-		backendConfig.Model = req.Model
-		backendConfig.MMProj = req.MMProj
-
-		// Set template configuration
-		if req.ChatTemplate != "" || req.CompletionTemplate != "" {
-			backendConfig.TemplateConfig = config.TemplateConfig{
-				Chat:       req.ChatTemplate,
-				Completion: req.CompletionTemplate,
-			}
-		}
-
-		// Set system prompt
-		if req.SystemPrompt != "" {
-			backendConfig.SystemPrompt = req.SystemPrompt
-		}
-
-		// Set prediction options
-		if temp, err := strconv.ParseFloat(req.Temperature, 32); err == nil {
-			backendConfig.Temperature = &temp
-		}
-		if topP, err := strconv.ParseFloat(req.TopP, 32); err == nil {
-			backendConfig.TopP = &topP
-		}
-		if topK, err := strconv.Atoi(req.TopK); err == nil {
-			backendConfig.TopK = &topK
-		}
-		if ctxSize, err := strconv.Atoi(req.ContextSize); err == nil {
-			backendConfig.ContextSize = &ctxSize
-		}
-		if threads, err := strconv.Atoi(req.Threads); err == nil {
-			backendConfig.Threads = &threads
-		}
-		if seed, err := strconv.Atoi(req.Seed); err == nil {
-			backendConfig.Seed = &seed
-		}
-
-		// Set feature flags
-		backendConfig.F16 = &req.F16
-		backendConfig.CUDA = req.CUDA
-		backendConfig.Embeddings = &req.Embeddings
-		backendConfig.Debug = &req.Debug
-		backendConfig.MMap = &req.MMap
-		backendConfig.MMlock = &req.MMlock
-
-		// Set backend-specific configurations
-		switch req.Backend {
-		case "llama.cpp":
-			if req.LoraAdapter != "" {
-				backendConfig.LoraAdapter = req.LoraAdapter
-			}
-			if req.Grammar != "" {
-				backendConfig.Grammar = req.Grammar
-			}
-		case "diffusers":
-			if req.PipelineType != "" {
-				backendConfig.Diffusers.PipelineType = req.PipelineType
-			}
-			if req.SchedulerType != "" {
-				backendConfig.Diffusers.SchedulerType = req.SchedulerType
-			}
-		case "whisper":
-			if req.AudioPath != "" {
-				backendConfig.AudioPath = req.AudioPath
-			}
-		case "bark-cpp":
-			if req.Voice != "" {
-				backendConfig.Voice = req.Voice
-			}
-		}
-
 		// Set defaults
 		backendConfig.SetDefaults()
 
-		// Check if model file is a URL and needs downloading
-		if strings.HasPrefix(req.Model, "http") {
-			// Add to download files
-			backendConfig.DownloadFiles = append(backendConfig.DownloadFiles, config.File{
-				URI: downloader.URI(req.Model),
-			})
-		}
-
-		if req.MMProj != "" && strings.HasPrefix(req.MMProj, "http") {
-			// Add MMProj to download files
-			backendConfig.DownloadFiles = append(backendConfig.DownloadFiles, config.File{
-				URI: downloader.URI(req.MMProj),
-			})
-		}
-
 		// Validate the configuration
 		if !backendConfig.Validate() {
-			// Provide more specific validation error messages
-			var validationErrors []string
-
-			if backendConfig.Backend == "" {
-				validationErrors = append(validationErrors, "Backend name is required")
-			} else {
-				// Check if backend name contains invalid characters
-				re := regexp.MustCompile(`^[a-zA-Z0-9-_\.]+$`)
-				if !re.MatchString(backendConfig.Backend) {
-					validationErrors = append(validationErrors, "Backend name contains invalid characters (only letters, numbers, hyphens, underscores, and dots are allowed)")
-				}
-			}
-
-			if backendConfig.Model == "" {
-				validationErrors = append(validationErrors, "Model file/URL is required")
-			}
-
-			// Check for path traversal attempts
-			if strings.Contains(backendConfig.Model, "..") || strings.Contains(backendConfig.Model, string(os.PathSeparator)) {
-				validationErrors = append(validationErrors, "Model path contains invalid characters")
-			}
-
-			if backendConfig.MMProj != "" {
-				if strings.Contains(backendConfig.MMProj, "..") || strings.Contains(backendConfig.MMProj, string(os.PathSeparator)) {
-					validationErrors = append(validationErrors, "MMProj path contains invalid characters")
-				}
-			}
-
-			if len(validationErrors) == 0 {
-				validationErrors = append(validationErrors, "Configuration validation failed")
-			}
 
 			response := ModelResponse{
 				Success: false,
 				Error:   "Validation failed",
-				Details: validationErrors,
+				Details: []string{"Calling backend.Config.Validate()"},
 			}
 			return c.Status(400).JSON(response)
 		}