Skip to content

Commit c0ceea8

Browse files
author
Marcelo Vanzin
committed
Add comments about dependency management.
1 parent c38228d commit c0ceea8

File tree

1 file changed

+12
-6
lines changed

1 file changed

+12
-6
lines changed

external/flume-sink/pom.xml

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,15 @@
4343
<groupId>org.apache.flume</groupId>
4444
<artifactId>flume-ng-sdk</artifactId>
4545
<exclusions>
46+
<!-- Guava is excluded to avoid its use in this module. -->
4647
<exclusion>
4748
<groupId>com.google.guava</groupId>
4849
<artifactId>guava</artifactId>
4950
</exclusion>
51+
<!--
52+
Exclude libthrift since the flume poms seem to confuse sbt, which fails to find the
53+
dependency.
54+
-->
5055
<exclusion>
5156
<groupId>org.apache.thrift</groupId>
5257
<artifactId>libthrift</artifactId>
@@ -71,18 +76,19 @@
7176
<groupId>org.scala-lang</groupId>
7277
<artifactId>scala-library</artifactId>
7378
</dependency>
74-
<!--
75-
Dependencies explicitly added in test as they have been excluded from
76-
Flume dependency (to avoid runtime problems when running with
77-
Spark) but unit tests need it.
78-
-->
7979
<dependency>
80+
<!-- Add Guava in test scope since flume actually needs it. -->
8081
<groupId>com.google.guava</groupId>
8182
<artifactId>guava</artifactId>
8283
<scope>test</scope>
8384
</dependency>
8485
<dependency>
85-
<!-- Version of Netty on which Flume 1.4.0 depends on is "3.4.0.Final" . -->
86+
<!--
87+
Netty explicitly added in test as it has been excluded from
88+
Flume dependency (to avoid runtime problems when running with
89+
Spark) but unit tests need it. Version of Netty on which
90+
Flume 1.4.0 depends on is "3.4.0.Final" .
91+
-->
8692
<groupId>io.netty</groupId>
8793
<artifactId>netty</artifactId>
8894
<version>3.4.0.Final</version>

0 commit comments

Comments
 (0)