Update ExponentialBackoffRetryLogic (#1603)

This update ensures that a failed transaction error is handled appropriately by the logic.

Author: injectives

driver/src/main/java/org/neo4j/driver/internal/retry/ExponentialBackoffRetryLogic.java

@@ -30,10 +30,9 @@
 import java.util.function.Supplier;
 import org.neo4j.driver.Logger;
 import org.neo4j.driver.Logging;
-import org.neo4j.driver.exceptions.ClientException;
 import org.neo4j.driver.exceptions.Neo4jException;
 import org.neo4j.driver.exceptions.RetryableException;
-import org.neo4j.driver.exceptions.SecurityRetryableException;
+import org.neo4j.driver.exceptions.TransactionTerminatedException;
 import org.neo4j.driver.internal.util.Futures;
 import org.reactivestreams.Publisher;
 import reactor.core.publisher.Flux;
@@ -161,10 +160,7 @@ protected boolean canRetryOn(Throwable error) {
      * @return the possible cause or the original error
      */
     private static Throwable extractPossibleTerminationCause(Throwable error) {
-        // Having a dedicated "TerminatedException" inheriting from ClientException might be a good idea.
-        if (!(error instanceof SecurityRetryableException)
-                && error instanceof ClientException
-                && error.getCause() != null) {
+        if (error instanceof TransactionTerminatedException && error.getCause() != null) {
             return error.getCause();
         }
         return error;

driver/src/test/java/org/neo4j/driver/internal/retry/ExponentialBackoffRetryLogicTest.java

@@ -68,6 +68,7 @@
 import org.neo4j.driver.exceptions.ConnectionReadTimeoutException;
 import org.neo4j.driver.exceptions.ServiceUnavailableException;
 import org.neo4j.driver.exceptions.SessionExpiredException;
+import org.neo4j.driver.exceptions.TransactionTerminatedException;
 import org.neo4j.driver.exceptions.TransientException;
 import org.neo4j.driver.internal.util.ImmediateSchedulingEventExecutor;
 import org.reactivestreams.Publisher;
@@ -1300,7 +1301,7 @@ private static ServiceUnavailableException serviceUnavailable() {
     }
 
     private static RuntimeException clientExceptionWithValidTerminationCause() {
-        return new ClientException("¯\\_(ツ)_/¯", serviceUnavailable());
+        return new TransactionTerminatedException("¯\\_(ツ)_/¯", serviceUnavailable());
     }
 
     private static RuntimeException randomClientException() {