Refactoring

Author: injectives

driver/src/main/java/org/neo4j/driver/TransactionWork.java

@@ -26,6 +26,7 @@
  * @deprecated superseded by {@link TransactionCallback}.
  */
 @Deprecated
+@SuppressWarnings("DeprecatedIsStillUsed")
 public interface TransactionWork<T> {
     /**
      * Executes all given operations against the same transaction.

driver/src/main/java/org/neo4j/driver/async/AsyncTransactionWork.java

@@ -27,6 +27,7 @@
  * @deprecated superseded by {@link AsyncTransactionCallback}.
  */
 @Deprecated
+@SuppressWarnings("DeprecatedIsStillUsed")
 public interface AsyncTransactionWork<T> {
     /**
      * Executes all given operations against the same transaction.

driver/src/main/java/org/neo4j/driver/internal/cluster/RediscoveryImpl.java

@@ -310,6 +310,7 @@ private CompletionStage<ClusterComposition> lookupOnRouter(
                 });
     }
 
+    @SuppressWarnings("ThrowableNotThrown")
     private ClusterComposition handleRoutingProcedureError(
             Throwable error, RoutingTable routingTable, BoltServerAddress routerAddress, Throwable baseError) {
         if (mustAbortDiscovery(error)) {

driver/src/main/java/org/neo4j/driver/internal/handlers/RunResponseHandler.java

@@ -61,6 +61,7 @@ public void onSuccess(Map<String, Value> metadata) {
     }
 
     @Override
+    @SuppressWarnings("ThrowableNotThrown")
     public void onFailure(Throwable error) {
         if (tx != null) {
             tx.markTerminated(error);

driver/src/main/java/org/neo4j/driver/internal/handlers/TransactionPullResponseCompletionListener.java

@@ -35,6 +35,7 @@ public TransactionPullResponseCompletionListener(UnmanagedTransaction tx) {
     public void afterSuccess(Map<String, Value> metadata) {}
 
     @Override
+    @SuppressWarnings("ThrowableNotThrown")
     public void afterFailure(Throwable error) {
         // always mark transaction as terminated because every error is "acknowledged" with a RESET message
         // so database forgets about the transaction after the first error

driver/src/main/java/org/neo4j/driver/internal/messaging/common/CommonValuePacker.java

@@ -173,6 +173,7 @@ private void packLocalDateTime(LocalDateTime localDateTime) throws IOException {
         packer.pack(nano);
     }
 
+    @SuppressWarnings("DuplicatedCode")
     private void packZonedDateTimeUsingUtcBaseline(ZonedDateTime zonedDateTime) throws IOException {
         var instant = zonedDateTime.toInstant();
         var epochSecondLocal = instant.getEpochSecond();
@@ -196,6 +197,7 @@ private void packZonedDateTimeUsingUtcBaseline(ZonedDateTime zonedDateTime) thro
         }
     }
 
+    @SuppressWarnings("DuplicatedCode")
     private void packZonedDateTime(ZonedDateTime zonedDateTime) throws IOException {
         var epochSecondLocal = zonedDateTime.toLocalDateTime().toEpochSecond(UTC);
         var nano = zonedDateTime.getNano();

driver/src/main/java/org/neo4j/driver/internal/messaging/common/CommonValueUnpacker.java

@@ -277,6 +277,7 @@ protected Value unpackRelationship() throws IOException {
         return new RelationshipValue(adapted);
     }
 
+    @SuppressWarnings("DuplicatedCode")
     protected InternalNode unpackNode() throws IOException {
         var urn = unpacker.unpackLong();
 
@@ -295,7 +296,7 @@ protected InternalNode unpackNode() throws IOException {
         return new InternalNode(urn, String.valueOf(urn), labels, props);
     }
 
-    @SuppressWarnings("deprecation")
+    @SuppressWarnings({"deprecation", "DuplicatedCode"})
     protected Value unpackPath() throws IOException {
         // List of unique nodes
         var uniqNodes = new Node[(int) unpacker.unpackListHeader()];

driver/src/main/java/org/neo4j/driver/internal/messaging/v4/MessageWriterV4.java

@@ -48,6 +48,7 @@ public MessageWriterV4(PackOutput output) {
         super(new CommonValuePacker(output, false), buildEncoders());
     }
 
+    @SuppressWarnings("DuplicatedCode")
     private static Map<Byte, MessageEncoder> buildEncoders() {
         Map<Byte, MessageEncoder> result = Iterables.newHashMapWithSize(9);
         result.put(HelloMessage.SIGNATURE, new HelloMessageEncoder());

driver/src/main/java/org/neo4j/driver/internal/messaging/v43/MessageWriterV43.java

@@ -56,6 +56,7 @@ public MessageWriterV43(PackOutput output, boolean dateTimeUtcEnabled) {
         super(new CommonValuePacker(output, dateTimeUtcEnabled), buildEncoders());
     }
 
+    @SuppressWarnings("DuplicatedCode")
     private static Map<Byte, MessageEncoder> buildEncoders() {
         Map<Byte, MessageEncoder> result = Iterables.newHashMapWithSize(9);
         result.put(HelloMessage.SIGNATURE, new HelloMessageEncoder());

driver/src/main/java/org/neo4j/driver/internal/messaging/v44/MessageWriterV44.java

@@ -53,6 +53,7 @@ public MessageWriterV44(PackOutput output, boolean dateTimeUtcEnabled) {
         super(new CommonValuePacker(output, dateTimeUtcEnabled), buildEncoders());
     }
 
+    @SuppressWarnings("DuplicatedCode")
     private static Map<Byte, MessageEncoder> buildEncoders() {
         Map<Byte, MessageEncoder> result = Iterables.newHashMapWithSize(9);
         result.put(HelloMessage.SIGNATURE, new HelloMessageEncoder());