Do not generate 404.html in project root

Netlify dev now picks up the custom 404.html from the publish folder
(matching the behavior of deployment on Netlify). We can remove the
workaround where we copied the 404.html to the project root.

Fix in netlify/cli: netlify/cli#1159

Author: FinnWoelm

README.md

@@ -135,7 +135,6 @@ Lastly, add the following lines to your `.gitignore`:
 # Files generated by next-on-netlify command
 /out_publish/
 /out_functions/
-/404.html
 ```
 
 Now you're all set.

lib/setupHtmlPages.js

@@ -28,14 +28,6 @@ const setupHtmlPages = () => {
       }
     )
   })
-
-  // Copy 404.html to directory root
-  // This is a temporary workaround. Currenly, Netlify (deployed) expects the
-  // 404.html file in the publish folder, while netlify-cli dev expects it at
-  // the directory root. In order to cover both cases, we copy the 404.html to
-  // both locations until this is fixed.
-  if(existsSync(join(NETLIFY_PUBLISH_PATH, "404.html")))
-    copySync(join(NETLIFY_PUBLISH_PATH, "404.html"), join(".", "404.html"))
 }
 
 module.exports = setupHtmlPages

tests/defaults.test.js

@@ -154,11 +154,6 @@ describe('404 Page', () => {
 
     expect(existsSync(join(OUTPUT_PATH, "404.html"))).toBe(true)
   })
-
-  // This is required for 404.html to work on netlify-dev
-  test('copies 404.html to directory root', () => {
-    expect(existsSync(join(PROJECT_PATH, "404.html"))).toBe(true)
-  })
 })
 
 describe('Public assets', () => {

tests/preRenderedIndexPages.test.js

@@ -86,11 +86,6 @@ describe('404 Page', () => {
 
     expect(existsSync(join(OUTPUT_PATH, "404.html"))).toBe(true)
   })
-
-  // This is required for 404.html to work on netlify-dev
-  test('copies 404.html to directory root', () => {
-    expect(existsSync(join(PROJECT_PATH, "404.html"))).toBe(true)
-  })
 })
 
 describe('Routing',() => {

tests/staticIndexPages.test.js

@@ -86,11 +86,6 @@ describe('404 Page', () => {
 
     expect(existsSync(join(OUTPUT_PATH, "404.html"))).toBe(true)
   })
-
-  // This is required for 404.html to work on netlify-dev
-  test('copies 404.html to directory root', () => {
-    expect(existsSync(join(PROJECT_PATH, "404.html"))).toBe(true)
-  })
 })
 
 describe('Routing',() => {