feat: add watch mode by erezrokah · Pull Request #162 · netlify/next-on-netlify · GitHub

This repository was archived by the owner on May 10, 2021. It is now read-only.

Contributor

erezrokah commented Feb 1, 2021

Fixes #96

Opening as draft as I have some questions/clarifications, I'll add those as comments on the PR.


          feat: add watch mode

7daaaed

erezrokah commented

View reviewed changes

README.md Show resolved Hide resolved

erezrokah commented

View reviewed changes

index.js Show resolved Hide resolved

erezrokah commented

View reviewed changes

lib/config.js Show resolved Hide resolved

erezrokah commented

View reviewed changes

lib/config.js Show resolved Hide resolved

erezrokah commented

View reviewed changes

lib/helpers/getNextDistDir.js Show resolved Hide resolved

erezrokah commented

View reviewed changes

lib/helpers/getNextSrcDir.js Outdated Show resolved Hide resolved

erezrokah commented

View reviewed changes

next-on-netlify.js Outdated Show resolved Hide resolved

erezrokah added the type: feature label

erezrokah requested a review from lindsaylevine

February 1, 2021 17:58

erezrokah commented

View reviewed changes

next-on-netlify.js

Contributor Author

erezrokah Feb 2, 2021

We can use an option (e.g. --watch) instead of a command, but with a command we can add specific watch configuration (e.g. watch --path a --path b)

lindsaylevine requested a review from ehmicky

February 2, 2021 16:24

ehmicky reviewed

View reviewed changes

index.js Outdated Show resolved Hide resolved

index.js Show resolved Hide resolved

erezrokah added 2 commits

February 2, 2021 19:21


          fix: move success log into build function

f9db2b7


          refactor: use 'all' instead of specific events

bc77c75

erezrokah marked this pull request as ready for review

February 3, 2021 10:00

lindsaylevine reviewed

View reviewed changes

Contributor

lindsaylevine left a comment

this is neat, finally got around to sharing some thoughts!

README.md Show resolved Hide resolved

index.js Show resolved Hide resolved

index.js Show resolved Hide resolved

lib/helpers/getNextSrcDir.js Outdated Show resolved Hide resolved

next-on-netlify.js Show resolved Hide resolved

Contributor

lindsaylevine commented Feb 3, 2021

how does this PR fit in? do you have thoughts on it? #126 (comment)

i was deferring to finn but finn's been pretty busy


          fix: use src instead of src/pages

8283b98

erezrokah mentioned this pull request

Update netlify dev configuration recommendation #126

Closed

Contributor Author

erezrokah commented Feb 4, 2021

how does this PR fit in? do you have thoughts on it? #126 (comment)

I'll comment on the PR. Running the Next.js dev only gives you the sense it's working - but you're not really simulating the functions/redirects Next on Netlify generates (see my comment https://github.com/netlify/next-on-netlify/pull/162/files#r568023419)

lindsaylevine approved these changes

View reviewed changes

Contributor

lindsaylevine left a comment

!!!

erezrokah merged commit 7f01dd3 into main

erezrokah deleted the feat/add_watch_mode branch

February 4, 2021 15:47

lindsaylevine added a commit that referenced this pull request


          Publish v2.9.0

b0ff95d

- add support for background functions in api pages only ([#171](#171))
- remove next as peer dependency ([#167](#167))
- add watch mode ([#162](#162))

erezrokah mentioned this pull request

Add onPreDev build plugin hook netlify/cli#3184

Closed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels