build!: fix engines.node
#210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was unintentionally(?) widened when porting the package into this monorepo. See original: https://github.com/netlify/functions/blob/acc2879e1a9629d1e2c8acefa207ad594ef63d5e/package.json#L95.
I don't believe there's any reason to support 14 and 16 in any of these, and this will lead to many blocked dependency upgrades down the road. Doing this now before public launch avoids user-facing major releases across all these packages. The only exception is `@netlify/blobs` (left unchanged here), because that's an existing package that [would require a major bump](https://github.com/netlify/blobs/blob/16973e4290e9d605792a3bd3774858e89eb33596/package.json#L7) and some thought to update. Note that Netlify CLI - an eventual consumer of some of these packages - currently requires >=18.14.0 (so no problem with dropping 14 and 16), but should be dropping 18 entirely by the time it starts to pull these packages in (it reached EOL a month ago).
serhalp
commented
May 26, 2025
Comment on lines
-50
to
-52
| - name: Install npm@7 | ||
| run: npm install -g npm@7 | ||
| if: ${{ matrix.node-version == '14.16.0' && !steps.release-check.outputs.IS_RELEASE }} |
pieh
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
29fe1ee
@netlify/functionsThis was unintentionally(?) widened when porting this existing package into this monorepo.
See original: https://github.com/netlify/functions/blob/acc2879e1a9629d1e2c8acefa207ad594ef63d5e/package.json#L95.
This commit just reverts it back to what it was.
@netlify/blobsThe only package I left unchanged here is
@netlify/blobs, because that's an existing public-facing package that would require a major bump and some thought to update.Related note: I noticed we aren't testing in CI against node 14 and 16. Once this PR is merged, this will only be relevant for
@netlify/blobs. If we decide we don't want to drop 14 and 16 there, we should add CI coverage just for that package somehow.9940844 all other packages
I don't believe there's any reason to support 14 and 16 in any of these, and this would lead to many blocked dependency upgrades down the road. I assume this was just copypasta from elsewhere.
Doing this now before public launch avoids user-facing major releases across all these packages.
I might argue for dropping 18 entirely in these packages, as they're brand new packages we are launched post-node-18-EOL (Apr 30), but this may significantly reduce the users and sites that will be able to our use Vite plugin, so at the very least let's take some time to evaluate that. (A quick spot-check shows many major frameworks' latest releases still supporting some subset of 18.x versions.)
Note that Netlify CLI — an eventual consumer of some of these packages — currently requires
>=18.14.0(i.e. no problem with dropping 14 and 16 here), but should be dropping 18 entirely by the time it starts to pull these packages in (18 reached EOL a month ago and we are fine with being aggressive with these in CLI).