This repository was archived by the owner on Jun 4, 2025. It is now read-only.
Override LRScheduler when using LRModifiers #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfineran
requested review from
a team and
horheynm
and removed request for
a team
markurtz
approved these changes
Aug 31, 2021
natuan
approved these changes
Aug 31, 2021
KSGulin
pushed a commit
that referenced
this pull request
Mar 9, 2022
bfineran
pushed a commit
that referenced
this pull request
Jun 5, 2024
* Cohere Model Release (#1) Cohere Model Release * Remove unnecessary files and code (#2) Some cleanup * Delete cohere-model directory (#3) * Make Fix (#5) * Pr fixes (#6) * fixes for pr * pr fixes for the format * pr fixes for the format * src/transformers/models/auto/tokenization_auto.py * Tokenizer test (#8) * tokenizer test * format fix * Adding Docs and other minor changes (#7) * Add modeling tests (#9) * Smol Fix (#11) * tokenization tests are fixed * format fixes * fix pr doc tests * fix pr doc tests * fix pr doc tests * fix pr style check * small changes in cohere.md * FIX: Address final comments for transformers integration (#13) * fix modeling final nits and add proper test file * for now leave empty tests * add integration test * push new test * fix modeling cohere (#14) * Update chat templates to use the new API (#15) --------- Co-authored-by: ahmetustun <[email protected]> Co-authored-by: Younes Belkada <[email protected]> Co-authored-by: Matt <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to perform pruning and QAT phases in the same recipe, it is useful to control the LR schedule within the recipe. currently, the HF LR scheduler will be called after the sparseml step, overriding any LR Modifiers. This PR detects if there are any LR modifiers in a Trainer's recipe, and if so, sets the HF LR scheduler to a dummy one.
example LR schedule recipe for pruning+QAT:
Produced schedule from W&B:
W&B: https://wandb.ai/neuralmagic/huggingface/runs/40ycsv8g?workspace=user-neuralmagic