Improve configure/release script to work with pinned requirements #2184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g#2070 Now ./configure will install dependencies that present in our github pypi as per OS/arch/python Signed-off-by: Abhishek Kumar <[email protected]>
…ode-org#295 Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
It fixes the error like 'OSError: [Errno 18] Invalid cross-device link' Signed-off-by: Abhishek Kumar <[email protected]>
pombredanne
reviewed
Aug 26, 2020
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
Abhishek-Dev09-zz
force-pushed
the
295-./configure
branch
from
4b12f56 to
cc714f0
Compare
pombredanne
requested changes
Aug 26, 2020
etc/configure.py
Outdated
| vcmd += ['-qq'] | ||
| # third parties may be in more than one directory | ||
| vcmd.extend(build_pip_dirs_args(tpp_dirs, root_dir)) | ||
| # Window doesn't support link as extra-search-dir |
There was a problem hiding this comment.
Is there a link in the doc or a bug about this? Please add it there as a comment
There was a problem hiding this comment.
i didn't get docs about this specifying same issue.
| - requirements_base.txt contains common requirements installed on all platforms. | ||
| - requirements_win.txt, requirements_linux.txt, requirements_mac.txt and | ||
| requirements_posix.txt are os-specific requirements. | ||
| - requirements-py36_base.txt contains common requirements installed on all platforms. |
There was a problem hiding this comment.
What's the difference between a requirements files for 3.6, 3.7 and 3.8?
There was a problem hiding this comment.
Requirements files difer in wheels that have native code like intbitset is diff for py36,py37,py38 and many such more wheels like extractcode-7z
Because all requirement files differ in native wheels like intbitset . I use py36 to avoid confusion. |
Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
Also clarify and document complex for loop Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve configure/release script to work of pinned requirements using github-pypi links.
Fixes : #2070 #2072
Signed-off-by: Abhishek Kumar [email protected]