test: given-when-that 명시적 적용

Author: chemistryx

src/test/java/io/suhan/lotto/model/NumberPoolTest.java

@@ -13,25 +13,39 @@
 public class NumberPoolTest {
     @Test
     void 특정_범위를_가진_Pool을_생성할_수_있다() {
-        NumberPool pool = NumberPool.of(1, 10);
+        // given
+        int from = 1;
+        int to = 10;
 
-        assertThat(pool.getNumbers()).hasSize(10);
+        // when
+        NumberPool pool = NumberPool.of(from, to);
+
+        // then
+        assertThat(pool.getNumbers()).hasSize(to - from + 1);
     }
 
     @Test
     void from은_to보다_클_수_없다() {
+        // given
+        int from = 2;
+        int to = 1;
         String expectedMessage = "from 값은 to 값보다 작아야 합니다.";
 
-        assertThatThrownBy(() -> NumberPool.of(2, 1))
+        // when and then
+        assertThatThrownBy(() -> NumberPool.of(from, to))
                 .isInstanceOf(IllegalArgumentException.class)
                 .hasMessage(expectedMessage);
     }
 
     @Test
     void 범위의_크기는_LOTTO_SIZE보다_커야_한다() {
+        // given
+        int from  = Lotto.LOTTO_NUMBER_MIN;
+        int to = Lotto.LOTTO_NUMBER_MIN + Lotto.LOTTO_SIZE - 2;
         String expectedMessage = "범위의 크기는 " + Lotto.LOTTO_SIZE + " 보다 커야 합니다.";
 
-        assertThatThrownBy(() -> NumberPool.of(Lotto.LOTTO_NUMBER_MIN, Lotto.LOTTO_NUMBER_MIN + Lotto.LOTTO_SIZE - 2))
+        // when and then
+        assertThatThrownBy(() -> NumberPool.of(from, to))
                 .isInstanceOf(IllegalArgumentException.class)
                 .hasMessage(expectedMessage);
     }

src/test/java/io/suhan/lotto/model/executor/DrawExecutorTest.java

@@ -34,15 +34,16 @@ void setUp() {
 
     @Test
     void 당첨번호와_로또를_비교할_수_있다() {
+        // given
         registry.add(winningLotto);
-
         LottoNumber bonusNumber = new LottoNumber(7);
-
         DrawExecutor executor = new DrawExecutor(registry, winningLotto, bonusNumber);
-        executor.execute();
 
+        // when
+        executor.execute();
         List<DrawResult> results = executor.getResults();
 
+        // then
         SoftAssertions.assertSoftly((softly) -> {
             softly.assertThat(results).hasSize(1);
             softly.assertThat(results.get(0).getMatchedCount()).isEqualTo(Lotto.LOTTO_SIZE);
@@ -51,11 +52,12 @@ void setUp() {
 
     @Test
     void 보너스_번호는_당첨번호와_중복될_수_없다() {
+        // given
         Lotto lotto = LottoFactory.createLotto(LottoType.AUTOMATIC);
         registry.add(lotto);
-
         LottoNumber bonusNumber = new LottoNumber(6);
 
+        // when and then
         assertThatThrownBy(() -> {
             DrawExecutor executor = new DrawExecutor(registry, winningLotto, bonusNumber);
             executor.execute();

src/test/java/io/suhan/lotto/model/executor/PurchaseExecutorTest.java

@@ -13,13 +13,17 @@
 public class PurchaseExecutorTest {
     @Test
     void 금액에_맞는_로또를_구매할_수_있다() {
+        // given
         LottoRegistry registry = new LottoRegistry();
         int count = 5;
         int balance = PRICE_PER_LOTTO * count;
 
         PurchaseExecutor executor = new PurchaseExecutor(registry, balance, 0);
+
+        // when
         executor.execute();
 
+        // then
         assertThat(registry.getLottos()).hasSize(count);
     }
 }

src/test/java/io/suhan/lotto/model/lotto/LottoNumberTest.java

@@ -12,15 +12,22 @@
 public class LottoNumberTest {
     @Test
     void 유효한_번호를_생성할_수_있다() {
-        LottoNumber number = new LottoNumber(Lotto.LOTTO_NUMBER_MIN);
+        // given
+        int validNumber = Lotto.LOTTO_NUMBER_MIN;
 
-        assertThat(Lotto.LOTTO_NUMBER_MIN).isEqualTo(number.getValue());
+        // when
+        LottoNumber lottoNumber = new LottoNumber(validNumber);
+
+        // then
+        assertThat(lottoNumber.getValue()).isEqualTo(validNumber);
     }
 
     @Test
     void 번호는_범위를_벗어날_수_없다() {
+        // given
         String expectedMessage = "로또 번호는 " + Lotto.LOTTO_NUMBER_MIN + "~" + Lotto.LOTTO_NUMBER_MAX + " 사이여야 합니다.";
 
+        // when and then
         SoftAssertions.assertSoftly((softly) -> {
             softly.assertThatThrownBy(() -> new LottoNumber(Lotto.LOTTO_NUMBER_MIN - 1))
                     .isInstanceOf(IllegalArgumentException.class)