Config schema checking #5816
Merged
Config schema checking #5816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Sherman <[email protected]>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
bentsherman
commented
Feb 25, 2025
Signed-off-by: Ben Sherman <[email protected]>
bentsherman
commented
Feb 25, 2025
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
bentsherman
commented
Feb 27, 2025
Comment on lines
-2
to
+1
| @@ -3,3 +1,4 @@ | |||
| outputDir = 'results' | |||
Member
Author
There was a problem hiding this comment.
Had to pick some valid config option here. Alternatively we could leave the invalid options and include the warnings for them in the expected stdout
Collaborator
|
The documentation looks good. |
pditommaso
reviewed
Mar 6, 2025
Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
pditommaso
requested changes
Mar 17, 2025
modules/nextflow/src/main/groovy/nextflow/config/ConfigParserFactory.groovy
Outdated
Show resolved
Hide resolved
Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
pditommaso
reviewed
Mar 17, 2025
Signed-off-by: Ben Sherman <[email protected]>
pditommaso
reviewed
Mar 17, 2025
pditommaso
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redo of #4201
This PR uses the config scope classes (in the new compiler module) to validate the config at runtime, for the
configandruncommands.Validation occurs after plugins are loaded, and the validator uses the plugin system to collect all implementations of the
ConfigScopeinterface, so plugins can use this interface to declare their config options to Nextflow.I suggest we merge this in an upcoming release and advise plugin developers to implement this interface before 25.04, to make the transition to next stable as smooth as possible.
This work is also a prerequisite to recognizing third-party plugin config in VS Code.