Skip to content

Conversation

@tsibley
Copy link
Member

@tsibley tsibley commented Nov 6, 2025

This avoids issues of mutual incompatibility between Nextstrain CLI dependencies and other things we install into the container's default Python. Those aren't hypothetical; we've run into them before and worked around in other ways, e.g. "Isolate AWS CLI (v1) into its own Python venv" (d041d6c).

This also aligns with our recommended and most common installation method.

Checklist

  • Checks pass
  • Update changelog

This avoids issues of mutual incompatibility between Nextstrain CLI
dependencies and other things we install into the container's default
Python.  Those aren't hypothetical; we've run into them before and
worked around in other ways, e.g. "Isolate AWS CLI (v1) into its own
Python venv" (d041d6c).

This also aligns with our recommended and most common installation
method.
@tsibley tsibley marked this pull request as draft November 6, 2025 21:29
@tsibley
Copy link
Member Author

tsibley commented Nov 6, 2025

I've had this code waiting in the wings for a bit. It needs an aarch64-unknown-linux-pc build of Nextstrain CLI, which I also have a WIP for. I'll either get that going quickly or push it up and PR it as-is and cross-link the PRs.

tsibley added a commit to nextstrain/cli that referenced this pull request Nov 6, 2025
GitHub released public runners.¹  This will ultimately let us use
standalone installation archives in our linux/arm64 Docker images.²

Changes to the standalone installer to follow separately³, as those need
to be held for merge until after the first release with these builds
available.

¹ <https://github.blog/changelog/2025-01-16-linux-arm64-hosted-runners-now-available-for-free-in-public-repositories-public-preview/>
² <nextstrain/docker-base#273>
³ <https://github.com/nextstrain/cli/pull/490>
tsibley added a commit to nextstrain/cli that referenced this pull request Nov 6, 2025
GitHub released public runners.¹  This will ultimately let us use
standalone installation archives in our linux/arm64 Docker images.²

Changes to the standalone installer to follow separately³, as those need
to be held for merge until after the first release with these builds
available.

¹ <https://github.blog/changelog/2025-01-16-linux-arm64-hosted-runners-now-available-for-free-in-public-repositories-public-preview/>
² <nextstrain/docker-base#273>
³ <#490>
@victorlin
Copy link
Member

The aarch64 build isn't strictly necessary – the x86_64 build can be run using emulation like many other tools in the image – but producing the platform-native build for Nextstrain CLI seems simple enough that we can wait for that here.

@tsibley
Copy link
Member Author

tsibley commented Nov 7, 2025

Yeah, good point! I'd forgotten that we still require x86_64 emulation for the aarch64 image, since Nextstrain CLI no longer requires emulation for itself. Aside from several testing infra hurdles for aarch64, the builds work just fine, so I'll get them going.

@tsibley tsibley marked this pull request as ready for review November 7, 2025 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants