enable logging in tests (#5499)

Author: vepatel

.github/actions/smoke-tests/action.yaml

@@ -73,6 +73,8 @@ runs:
         --durations=10 \
         --show-ic-logs=yes \
         --ad-secret=${{ inputs.azure-ad-secret }} \
-        -m ${{ inputs.marker != '' && inputs.marker || '""' }}
+        -m ${{ inputs.marker != '' && inputs.marker || '""' }} \
+        -v \
+        -s
       working-directory: ./tests
       shell: bash

tests/conftest.py

@@ -190,7 +190,7 @@ def pytest_runtest_makereport(item) -> None:
     rep = outcome.get_result()
 
     # we only look at actual failing test calls, not setup/teardown
-    if rep.when == "call" and rep.failed and item.config.getoption("--show-ic-logs") == "yes":
+    if rep.when == "call" and item.config.getoption("--show-ic-logs") == "yes":
         pod_namespace = item.funcargs["ingress_controller_prerequisites"].namespace
         pod_name = get_first_pod_name(item.funcargs["kube_apis"].v1, pod_namespace)
         print("\n===================== IC Logs Start =====================")