fix incorrect lenTuple implementation #13423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
timotheecour
force-pushed
the
pr_fix_lenTuple
branch
from
2a455dc to
6729ab9
Compare
krux02
reviewed
Feb 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some of the tests I added in this PR would not pass before this PR.
var operand = operand.skipTypes({tyGenericInst})could maybe be{tyGenericInst, tySink}but I went for consistency with other typetraits; most/all of these typetraits should use the same argument in skipTypes so, if needed, that could be handled in a separate (unrelated) PR that would fix all of these