Skip to content

Ref https://github.com/nim-lang/Nim/pull/17830 #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 25, 2021
Merged

Ref https://github.com/nim-lang/Nim/pull/17830 #90

merged 6 commits into from
Apr 25, 2021

Conversation

@ringabout
Copy link
Member

@ringabout ringabout commented Apr 24, 2021 •
edited by timotheecour
Loading

refs nim-lang/Nim#17830
(EDIT(timotheecour): github doesn't cross link via title), so i added url to PR msg)

@ringabout ringabout mentioned this pull request Apr 24, 2021
Merged
timotheecour
timotheecour approved these changes Apr 24, 2021
View reviewed changes
Copy link
Member

@timotheecour timotheecour left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but is there a chance this will break clients using nim 1.0, 1.2 or 1.4 ?

@ringabout
Copy link
Member Author

ringabout commented Apr 24, 2021

Since owned is nothing without --newruntime and newruntime is already deprecated in devel. So I think they can be removed.

@Araq Araq merged commit 31be851 into nim-lang:master Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timotheecour timotheecour timotheecour approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ringabout @timotheecour @Araq