From 3e2f6d57af464dc2ecd21b0a295d294ec4f52640 Mon Sep 17 00:00:00 2001 From: Orgad Shaneh Date: Tue, 8 Jul 2025 10:02:45 +0300 Subject: [PATCH] Replace obsolete ENV VAR VALUE with ENV VAR=VALUE Fixes these warnings: - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format --- 20/alpine3.21/Dockerfile | 4 ++-- 20/alpine3.22/Dockerfile | 4 ++-- 20/bookworm-slim/Dockerfile | 4 ++-- 20/bookworm/Dockerfile | 4 ++-- 20/bullseye-slim/Dockerfile | 4 ++-- 20/bullseye/Dockerfile | 4 ++-- 20/trixie-slim/Dockerfile | 4 ++-- 20/trixie/Dockerfile | 4 ++-- 22/alpine3.21/Dockerfile | 4 ++-- 22/alpine3.22/Dockerfile | 4 ++-- 22/bookworm-slim/Dockerfile | 4 ++-- 22/bookworm/Dockerfile | 4 ++-- 22/bullseye-slim/Dockerfile | 4 ++-- 22/bullseye/Dockerfile | 4 ++-- 22/trixie-slim/Dockerfile | 4 ++-- 22/trixie/Dockerfile | 4 ++-- 24/alpine3.21/Dockerfile | 4 ++-- 24/alpine3.22/Dockerfile | 4 ++-- 24/bookworm-slim/Dockerfile | 4 ++-- 24/bookworm/Dockerfile | 4 ++-- 24/bullseye-slim/Dockerfile | 4 ++-- 24/bullseye/Dockerfile | 4 ++-- 24/trixie-slim/Dockerfile | 4 ++-- 24/trixie/Dockerfile | 4 ++-- 25/alpine3.21/Dockerfile | 4 ++-- 25/alpine3.22/Dockerfile | 4 ++-- 25/bookworm-slim/Dockerfile | 4 ++-- 25/bookworm/Dockerfile | 4 ++-- 25/bullseye-slim/Dockerfile | 4 ++-- 25/bullseye/Dockerfile | 4 ++-- 25/trixie-slim/Dockerfile | 4 ++-- 25/trixie/Dockerfile | 4 ++-- Dockerfile-alpine.template | 4 ++-- Dockerfile-debian.template | 4 ++-- Dockerfile-slim.template | 4 ++-- README.md | 2 +- docs/BestPractices.md | 6 +++--- functions.sh | 2 +- genMatrix.js | 2 +- stackbrew.js | 2 +- update.sh | 4 ++-- 41 files changed, 79 insertions(+), 79 deletions(-) diff --git a/20/alpine3.21/Dockerfile b/20/alpine3.21/Dockerfile index 53bb2b5dd1..5f3680b28b 100644 --- a/20/alpine3.21/Dockerfile +++ b/20/alpine3.21/Dockerfile @@ -1,6 +1,6 @@ FROM alpine:3.21 -ENV NODE_VERSION 20.19.5 +ENV NODE_VERSION=20.19.5 RUN addgroup -g 1000 node \ && adduser -u 1000 -G node -s /bin/sh -D node \ @@ -78,7 +78,7 @@ RUN addgroup -g 1000 node \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 1.22.22 +ENV YARN_VERSION=1.22.22 RUN apk add --no-cache --virtual .build-deps-yarn curl gnupg tar \ # use pre-existing gpg directory, see https://github.com/nodejs/docker-node/pull/1895#issuecomment-1550389150 diff --git a/20/alpine3.22/Dockerfile b/20/alpine3.22/Dockerfile index 886eb12c58..8adae33d92 100644 --- a/20/alpine3.22/Dockerfile +++ b/20/alpine3.22/Dockerfile @@ -1,6 +1,6 @@ FROM alpine:3.22 -ENV NODE_VERSION 20.19.5 +ENV NODE_VERSION=20.19.5 RUN addgroup -g 1000 node \ && adduser -u 1000 -G node -s /bin/sh -D node \ @@ -78,7 +78,7 @@ RUN addgroup -g 1000 node \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 1.22.22 +ENV YARN_VERSION=1.22.22 RUN apk add --no-cache --virtual .build-deps-yarn curl gnupg tar \ # use pre-existing gpg directory, see https://github.com/nodejs/docker-node/pull/1895#issuecomment-1550389150 diff --git a/20/bookworm-slim/Dockerfile b/20/bookworm-slim/Dockerfile index d03d97ad67..195eefc502 100644 --- a/20/bookworm-slim/Dockerfile +++ b/20/bookworm-slim/Dockerfile @@ -3,7 +3,7 @@ FROM debian:bookworm-slim RUN groupadd --gid 1000 node \ && useradd --uid 1000 --gid node --shell /bin/bash --create-home node -ENV NODE_VERSION 20.19.5 +ENV NODE_VERSION=20.19.5 RUN ARCH= OPENSSL_ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && case "${dpkgArch##*-}" in \ @@ -60,7 +60,7 @@ RUN ARCH= OPENSSL_ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 1.22.22 +ENV YARN_VERSION=1.22.22 RUN set -ex \ && savedAptMark="$(apt-mark showmanual)" \ diff --git a/20/bookworm/Dockerfile b/20/bookworm/Dockerfile index e5a0976690..1af9fdba11 100644 --- a/20/bookworm/Dockerfile +++ b/20/bookworm/Dockerfile @@ -3,7 +3,7 @@ FROM buildpack-deps:bookworm RUN groupadd --gid 1000 node \ && useradd --uid 1000 --gid node --shell /bin/bash --create-home node -ENV NODE_VERSION 20.19.5 +ENV NODE_VERSION=20.19.5 RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && case "${dpkgArch##*-}" in \ @@ -46,7 +46,7 @@ RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 1.22.22 +ENV YARN_VERSION=1.22.22 RUN set -ex \ # use pre-existing gpg directory, see https://github.com/nodejs/docker-node/pull/1895#issuecomment-1550389150 diff --git a/20/bullseye-slim/Dockerfile b/20/bullseye-slim/Dockerfile index 4feae0bbdf..e2b9255293 100644 --- a/20/bullseye-slim/Dockerfile +++ b/20/bullseye-slim/Dockerfile @@ -3,7 +3,7 @@ FROM debian:bullseye-slim RUN groupadd --gid 1000 node \ && useradd --uid 1000 --gid node --shell /bin/bash --create-home node -ENV NODE_VERSION 20.19.5 +ENV NODE_VERSION=20.19.5 RUN ARCH= OPENSSL_ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && case "${dpkgArch##*-}" in \ @@ -60,7 +60,7 @@ RUN ARCH= OPENSSL_ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 1.22.22 +ENV YARN_VERSION=1.22.22 RUN set -ex \ && savedAptMark="$(apt-mark showmanual)" \ diff --git a/20/bullseye/Dockerfile b/20/bullseye/Dockerfile index b8e6c38ed8..23c9c321ff 100644 --- a/20/bullseye/Dockerfile +++ b/20/bullseye/Dockerfile @@ -3,7 +3,7 @@ FROM buildpack-deps:bullseye RUN groupadd --gid 1000 node \ && useradd --uid 1000 --gid node --shell /bin/bash --create-home node -ENV NODE_VERSION 20.19.5 +ENV NODE_VERSION=20.19.5 RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && case "${dpkgArch##*-}" in \ @@ -46,7 +46,7 @@ RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 1.22.22 +ENV YARN_VERSION=1.22.22 RUN set -ex \ # use pre-existing gpg directory, see https://github.com/nodejs/docker-node/pull/1895#issuecomment-1550389150 diff --git a/20/trixie-slim/Dockerfile b/20/trixie-slim/Dockerfile index eae3c02d4c..83af7f87d1 100644 --- a/20/trixie-slim/Dockerfile +++ b/20/trixie-slim/Dockerfile @@ -3,7 +3,7 @@ FROM debian:trixie-slim RUN groupadd --gid 1000 node \ && useradd --uid 1000 --gid node --shell /bin/bash --create-home node -ENV NODE_VERSION 20.19.5 +ENV NODE_VERSION=20.19.5 RUN ARCH= OPENSSL_ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && case "${dpkgArch##*-}" in \ @@ -60,7 +60,7 @@ RUN ARCH= OPENSSL_ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 1.22.22 +ENV YARN_VERSION=1.22.22 RUN set -ex \ && savedAptMark="$(apt-mark showmanual)" \ diff --git a/20/trixie/Dockerfile b/20/trixie/Dockerfile index 62b65b61da..6185b7810f 100644 --- a/20/trixie/Dockerfile +++ b/20/trixie/Dockerfile @@ -3,7 +3,7 @@ FROM buildpack-deps:trixie RUN groupadd --gid 1000 node \ && useradd --uid 1000 --gid node --shell /bin/bash --create-home node -ENV NODE_VERSION 20.19.5 +ENV NODE_VERSION=20.19.5 RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && case "${dpkgArch##*-}" in \ @@ -46,7 +46,7 @@ RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 1.22.22 +ENV YARN_VERSION=1.22.22 RUN set -ex \ # use pre-existing gpg directory, see https://github.com/nodejs/docker-node/pull/1895#issuecomment-1550389150 diff --git a/22/alpine3.21/Dockerfile b/22/alpine3.21/Dockerfile index 129ad0e909..b60b1cd2e4 100644 --- a/22/alpine3.21/Dockerfile +++ b/22/alpine3.21/Dockerfile @@ -1,6 +1,6 @@ FROM alpine:3.21 -ENV NODE_VERSION 22.20.0 +ENV NODE_VERSION=22.20.0 RUN addgroup -g 1000 node \ && adduser -u 1000 -G node -s /bin/sh -D node \ @@ -78,7 +78,7 @@ RUN addgroup -g 1000 node \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 1.22.22 +ENV YARN_VERSION=1.22.22 RUN apk add --no-cache --virtual .build-deps-yarn curl gnupg tar \ # use pre-existing gpg directory, see https://github.com/nodejs/docker-node/pull/1895#issuecomment-1550389150 diff --git a/22/alpine3.22/Dockerfile b/22/alpine3.22/Dockerfile index ad6fc354f6..e67143871e 100644 --- a/22/alpine3.22/Dockerfile +++ b/22/alpine3.22/Dockerfile @@ -1,6 +1,6 @@ FROM alpine:3.22 -ENV NODE_VERSION 22.20.0 +ENV NODE_VERSION=22.20.0 RUN addgroup -g 1000 node \ && adduser -u 1000 -G node -s /bin/sh -D node \ @@ -78,7 +78,7 @@ RUN addgroup -g 1000 node \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 1.22.22 +ENV YARN_VERSION=1.22.22 RUN apk add --no-cache --virtual .build-deps-yarn curl gnupg tar \ # use pre-existing gpg directory, see https://github.com/nodejs/docker-node/pull/1895#issuecomment-1550389150 diff --git a/22/bookworm-slim/Dockerfile b/22/bookworm-slim/Dockerfile index 4791b9a3d9..bd614d7244 100644 --- a/22/bookworm-slim/Dockerfile +++ b/22/bookworm-slim/Dockerfile @@ -3,7 +3,7 @@ FROM debian:bookworm-slim RUN groupadd --gid 1000 node \ && useradd --uid 1000 --gid node --shell /bin/bash --create-home node -ENV NODE_VERSION 22.20.0 +ENV NODE_VERSION=22.20.0 RUN ARCH= OPENSSL_ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && case "${dpkgArch##*-}" in \ @@ -60,7 +60,7 @@ RUN ARCH= OPENSSL_ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 1.22.22 +ENV YARN_VERSION=1.22.22 RUN set -ex \ && savedAptMark="$(apt-mark showmanual)" \ diff --git a/22/bookworm/Dockerfile b/22/bookworm/Dockerfile index 1c8b64fbf5..d5c57ce95d 100644 --- a/22/bookworm/Dockerfile +++ b/22/bookworm/Dockerfile @@ -3,7 +3,7 @@ FROM buildpack-deps:bookworm RUN groupadd --gid 1000 node \ && useradd --uid 1000 --gid node --shell /bin/bash --create-home node -ENV NODE_VERSION 22.20.0 +ENV NODE_VERSION=22.20.0 RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && case "${dpkgArch##*-}" in \ @@ -46,7 +46,7 @@ RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 1.22.22 +ENV YARN_VERSION=1.22.22 RUN set -ex \ # use pre-existing gpg directory, see https://github.com/nodejs/docker-node/pull/1895#issuecomment-1550389150 diff --git a/22/bullseye-slim/Dockerfile b/22/bullseye-slim/Dockerfile index a09041cd28..0211c35552 100644 --- a/22/bullseye-slim/Dockerfile +++ b/22/bullseye-slim/Dockerfile @@ -3,7 +3,7 @@ FROM debian:bullseye-slim RUN groupadd --gid 1000 node \ && useradd --uid 1000 --gid node --shell /bin/bash --create-home node -ENV NODE_VERSION 22.20.0 +ENV NODE_VERSION=22.20.0 RUN ARCH= OPENSSL_ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && case "${dpkgArch##*-}" in \ @@ -60,7 +60,7 @@ RUN ARCH= OPENSSL_ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 1.22.22 +ENV YARN_VERSION=1.22.22 RUN set -ex \ && savedAptMark="$(apt-mark showmanual)" \ diff --git a/22/bullseye/Dockerfile b/22/bullseye/Dockerfile index afe9fb0d27..5fb10090ae 100644 --- a/22/bullseye/Dockerfile +++ b/22/bullseye/Dockerfile @@ -3,7 +3,7 @@ FROM buildpack-deps:bullseye RUN groupadd --gid 1000 node \ && useradd --uid 1000 --gid node --shell /bin/bash --create-home node -ENV NODE_VERSION 22.20.0 +ENV NODE_VERSION=22.20.0 RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && case "${dpkgArch##*-}" in \ @@ -46,7 +46,7 @@ RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 1.22.22 +ENV YARN_VERSION=1.22.22 RUN set -ex \ # use pre-existing gpg directory, see https://github.com/nodejs/docker-node/pull/1895#issuecomment-1550389150 diff --git a/22/trixie-slim/Dockerfile b/22/trixie-slim/Dockerfile index b73f32ff55..619d73439d 100644 --- a/22/trixie-slim/Dockerfile +++ b/22/trixie-slim/Dockerfile @@ -3,7 +3,7 @@ FROM debian:trixie-slim RUN groupadd --gid 1000 node \ && useradd --uid 1000 --gid node --shell /bin/bash --create-home node -ENV NODE_VERSION 22.20.0 +ENV NODE_VERSION=22.20.0 RUN ARCH= OPENSSL_ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && case "${dpkgArch##*-}" in \ @@ -60,7 +60,7 @@ RUN ARCH= OPENSSL_ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 1.22.22 +ENV YARN_VERSION=1.22.22 RUN set -ex \ && savedAptMark="$(apt-mark showmanual)" \ diff --git a/22/trixie/Dockerfile b/22/trixie/Dockerfile index 59990dc7ca..dde716d875 100644 --- a/22/trixie/Dockerfile +++ b/22/trixie/Dockerfile @@ -3,7 +3,7 @@ FROM buildpack-deps:trixie RUN groupadd --gid 1000 node \ && useradd --uid 1000 --gid node --shell /bin/bash --create-home node -ENV NODE_VERSION 22.20.0 +ENV NODE_VERSION=22.20.0 RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && case "${dpkgArch##*-}" in \ @@ -46,7 +46,7 @@ RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 1.22.22 +ENV YARN_VERSION=1.22.22 RUN set -ex \ # use pre-existing gpg directory, see https://github.com/nodejs/docker-node/pull/1895#issuecomment-1550389150 diff --git a/24/alpine3.21/Dockerfile b/24/alpine3.21/Dockerfile index 77c971ad0e..3869746051 100644 --- a/24/alpine3.21/Dockerfile +++ b/24/alpine3.21/Dockerfile @@ -1,6 +1,6 @@ FROM alpine:3.21 -ENV NODE_VERSION 24.10.0 +ENV NODE_VERSION=24.10.0 RUN addgroup -g 1000 node \ && adduser -u 1000 -G node -s /bin/sh -D node \ @@ -78,7 +78,7 @@ RUN addgroup -g 1000 node \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 1.22.22 +ENV YARN_VERSION=1.22.22 RUN apk add --no-cache --virtual .build-deps-yarn curl gnupg tar \ # use pre-existing gpg directory, see https://github.com/nodejs/docker-node/pull/1895#issuecomment-1550389150 diff --git a/24/alpine3.22/Dockerfile b/24/alpine3.22/Dockerfile index 15200a0c70..21c0598b2e 100644 --- a/24/alpine3.22/Dockerfile +++ b/24/alpine3.22/Dockerfile @@ -1,6 +1,6 @@ FROM alpine:3.22 -ENV NODE_VERSION 24.10.0 +ENV NODE_VERSION=24.10.0 RUN addgroup -g 1000 node \ && adduser -u 1000 -G node -s /bin/sh -D node \ @@ -78,7 +78,7 @@ RUN addgroup -g 1000 node \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 1.22.22 +ENV YARN_VERSION=1.22.22 RUN apk add --no-cache --virtual .build-deps-yarn curl gnupg tar \ # use pre-existing gpg directory, see https://github.com/nodejs/docker-node/pull/1895#issuecomment-1550389150 diff --git a/24/bookworm-slim/Dockerfile b/24/bookworm-slim/Dockerfile index 74db423f14..f94c32ac8f 100644 --- a/24/bookworm-slim/Dockerfile +++ b/24/bookworm-slim/Dockerfile @@ -3,7 +3,7 @@ FROM debian:bookworm-slim RUN groupadd --gid 1000 node \ && useradd --uid 1000 --gid node --shell /bin/bash --create-home node -ENV NODE_VERSION 24.10.0 +ENV NODE_VERSION=24.10.0 RUN ARCH= OPENSSL_ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && case "${dpkgArch##*-}" in \ @@ -60,7 +60,7 @@ RUN ARCH= OPENSSL_ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 1.22.22 +ENV YARN_VERSION=1.22.22 RUN set -ex \ && savedAptMark="$(apt-mark showmanual)" \ diff --git a/24/bookworm/Dockerfile b/24/bookworm/Dockerfile index c9d59e74c0..db9a62f8df 100644 --- a/24/bookworm/Dockerfile +++ b/24/bookworm/Dockerfile @@ -3,7 +3,7 @@ FROM buildpack-deps:bookworm RUN groupadd --gid 1000 node \ && useradd --uid 1000 --gid node --shell /bin/bash --create-home node -ENV NODE_VERSION 24.10.0 +ENV NODE_VERSION=24.10.0 RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && case "${dpkgArch##*-}" in \ @@ -46,7 +46,7 @@ RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 1.22.22 +ENV YARN_VERSION=1.22.22 RUN set -ex \ # use pre-existing gpg directory, see https://github.com/nodejs/docker-node/pull/1895#issuecomment-1550389150 diff --git a/24/bullseye-slim/Dockerfile b/24/bullseye-slim/Dockerfile index b2af2d49b2..e5684e6121 100644 --- a/24/bullseye-slim/Dockerfile +++ b/24/bullseye-slim/Dockerfile @@ -3,7 +3,7 @@ FROM debian:bullseye-slim RUN groupadd --gid 1000 node \ && useradd --uid 1000 --gid node --shell /bin/bash --create-home node -ENV NODE_VERSION 24.10.0 +ENV NODE_VERSION=24.10.0 RUN ARCH= OPENSSL_ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && case "${dpkgArch##*-}" in \ @@ -60,7 +60,7 @@ RUN ARCH= OPENSSL_ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 1.22.22 +ENV YARN_VERSION=1.22.22 RUN set -ex \ && savedAptMark="$(apt-mark showmanual)" \ diff --git a/24/bullseye/Dockerfile b/24/bullseye/Dockerfile index 67af93faa0..84a919c834 100644 --- a/24/bullseye/Dockerfile +++ b/24/bullseye/Dockerfile @@ -3,7 +3,7 @@ FROM buildpack-deps:bullseye RUN groupadd --gid 1000 node \ && useradd --uid 1000 --gid node --shell /bin/bash --create-home node -ENV NODE_VERSION 24.10.0 +ENV NODE_VERSION=24.10.0 RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && case "${dpkgArch##*-}" in \ @@ -46,7 +46,7 @@ RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 1.22.22 +ENV YARN_VERSION=1.22.22 RUN set -ex \ # use pre-existing gpg directory, see https://github.com/nodejs/docker-node/pull/1895#issuecomment-1550389150 diff --git a/24/trixie-slim/Dockerfile b/24/trixie-slim/Dockerfile index aa8cbaf051..38f07e5129 100644 --- a/24/trixie-slim/Dockerfile +++ b/24/trixie-slim/Dockerfile @@ -3,7 +3,7 @@ FROM debian:trixie-slim RUN groupadd --gid 1000 node \ && useradd --uid 1000 --gid node --shell /bin/bash --create-home node -ENV NODE_VERSION 24.10.0 +ENV NODE_VERSION=24.10.0 RUN ARCH= OPENSSL_ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && case "${dpkgArch##*-}" in \ @@ -60,7 +60,7 @@ RUN ARCH= OPENSSL_ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 1.22.22 +ENV YARN_VERSION=1.22.22 RUN set -ex \ && savedAptMark="$(apt-mark showmanual)" \ diff --git a/24/trixie/Dockerfile b/24/trixie/Dockerfile index 948b2b9c0e..ef99c2d4bf 100644 --- a/24/trixie/Dockerfile +++ b/24/trixie/Dockerfile @@ -3,7 +3,7 @@ FROM buildpack-deps:trixie RUN groupadd --gid 1000 node \ && useradd --uid 1000 --gid node --shell /bin/bash --create-home node -ENV NODE_VERSION 24.10.0 +ENV NODE_VERSION=24.10.0 RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && case "${dpkgArch##*-}" in \ @@ -46,7 +46,7 @@ RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 1.22.22 +ENV YARN_VERSION=1.22.22 RUN set -ex \ # use pre-existing gpg directory, see https://github.com/nodejs/docker-node/pull/1895#issuecomment-1550389150 diff --git a/25/alpine3.21/Dockerfile b/25/alpine3.21/Dockerfile index b9479ee8d9..fbd07720e3 100644 --- a/25/alpine3.21/Dockerfile +++ b/25/alpine3.21/Dockerfile @@ -1,6 +1,6 @@ FROM alpine:3.21 -ENV NODE_VERSION 25.0.0 +ENV NODE_VERSION=25.0.0 RUN addgroup -g 1000 node \ && adduser -u 1000 -G node -s /bin/sh -D node \ @@ -78,7 +78,7 @@ RUN addgroup -g 1000 node \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 1.22.22 +ENV YARN_VERSION=1.22.22 RUN apk add --no-cache --virtual .build-deps-yarn curl gnupg tar \ # use pre-existing gpg directory, see https://github.com/nodejs/docker-node/pull/1895#issuecomment-1550389150 diff --git a/25/alpine3.22/Dockerfile b/25/alpine3.22/Dockerfile index 97b8186266..bb02edffdf 100644 --- a/25/alpine3.22/Dockerfile +++ b/25/alpine3.22/Dockerfile @@ -1,6 +1,6 @@ FROM alpine:3.22 -ENV NODE_VERSION 25.0.0 +ENV NODE_VERSION=25.0.0 RUN addgroup -g 1000 node \ && adduser -u 1000 -G node -s /bin/sh -D node \ @@ -78,7 +78,7 @@ RUN addgroup -g 1000 node \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 1.22.22 +ENV YARN_VERSION=1.22.22 RUN apk add --no-cache --virtual .build-deps-yarn curl gnupg tar \ # use pre-existing gpg directory, see https://github.com/nodejs/docker-node/pull/1895#issuecomment-1550389150 diff --git a/25/bookworm-slim/Dockerfile b/25/bookworm-slim/Dockerfile index 2d24c67251..cca13ebaea 100644 --- a/25/bookworm-slim/Dockerfile +++ b/25/bookworm-slim/Dockerfile @@ -3,7 +3,7 @@ FROM debian:bookworm-slim RUN groupadd --gid 1000 node \ && useradd --uid 1000 --gid node --shell /bin/bash --create-home node -ENV NODE_VERSION 25.0.0 +ENV NODE_VERSION=25.0.0 RUN ARCH= OPENSSL_ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && case "${dpkgArch##*-}" in \ @@ -60,7 +60,7 @@ RUN ARCH= OPENSSL_ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 1.22.22 +ENV YARN_VERSION=1.22.22 RUN set -ex \ && savedAptMark="$(apt-mark showmanual)" \ diff --git a/25/bookworm/Dockerfile b/25/bookworm/Dockerfile index 7662980b03..2a17c72cd6 100644 --- a/25/bookworm/Dockerfile +++ b/25/bookworm/Dockerfile @@ -3,7 +3,7 @@ FROM buildpack-deps:bookworm RUN groupadd --gid 1000 node \ && useradd --uid 1000 --gid node --shell /bin/bash --create-home node -ENV NODE_VERSION 25.0.0 +ENV NODE_VERSION=25.0.0 RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && case "${dpkgArch##*-}" in \ @@ -46,7 +46,7 @@ RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 1.22.22 +ENV YARN_VERSION=1.22.22 RUN set -ex \ # use pre-existing gpg directory, see https://github.com/nodejs/docker-node/pull/1895#issuecomment-1550389150 diff --git a/25/bullseye-slim/Dockerfile b/25/bullseye-slim/Dockerfile index 5c7e2b6411..88f2f80d03 100644 --- a/25/bullseye-slim/Dockerfile +++ b/25/bullseye-slim/Dockerfile @@ -3,7 +3,7 @@ FROM debian:bullseye-slim RUN groupadd --gid 1000 node \ && useradd --uid 1000 --gid node --shell /bin/bash --create-home node -ENV NODE_VERSION 25.0.0 +ENV NODE_VERSION=25.0.0 RUN ARCH= OPENSSL_ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && case "${dpkgArch##*-}" in \ @@ -60,7 +60,7 @@ RUN ARCH= OPENSSL_ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 1.22.22 +ENV YARN_VERSION=1.22.22 RUN set -ex \ && savedAptMark="$(apt-mark showmanual)" \ diff --git a/25/bullseye/Dockerfile b/25/bullseye/Dockerfile index 2753527074..b7851a9b64 100644 --- a/25/bullseye/Dockerfile +++ b/25/bullseye/Dockerfile @@ -3,7 +3,7 @@ FROM buildpack-deps:bullseye RUN groupadd --gid 1000 node \ && useradd --uid 1000 --gid node --shell /bin/bash --create-home node -ENV NODE_VERSION 25.0.0 +ENV NODE_VERSION=25.0.0 RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && case "${dpkgArch##*-}" in \ @@ -46,7 +46,7 @@ RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 1.22.22 +ENV YARN_VERSION=1.22.22 RUN set -ex \ # use pre-existing gpg directory, see https://github.com/nodejs/docker-node/pull/1895#issuecomment-1550389150 diff --git a/25/trixie-slim/Dockerfile b/25/trixie-slim/Dockerfile index b3520c1ae7..fa16ee20a8 100644 --- a/25/trixie-slim/Dockerfile +++ b/25/trixie-slim/Dockerfile @@ -3,7 +3,7 @@ FROM debian:trixie-slim RUN groupadd --gid 1000 node \ && useradd --uid 1000 --gid node --shell /bin/bash --create-home node -ENV NODE_VERSION 25.0.0 +ENV NODE_VERSION=25.0.0 RUN ARCH= OPENSSL_ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && case "${dpkgArch##*-}" in \ @@ -60,7 +60,7 @@ RUN ARCH= OPENSSL_ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 1.22.22 +ENV YARN_VERSION=1.22.22 RUN set -ex \ && savedAptMark="$(apt-mark showmanual)" \ diff --git a/25/trixie/Dockerfile b/25/trixie/Dockerfile index 453eebc6a2..8eac173146 100644 --- a/25/trixie/Dockerfile +++ b/25/trixie/Dockerfile @@ -3,7 +3,7 @@ FROM buildpack-deps:trixie RUN groupadd --gid 1000 node \ && useradd --uid 1000 --gid node --shell /bin/bash --create-home node -ENV NODE_VERSION 25.0.0 +ENV NODE_VERSION=25.0.0 RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && case "${dpkgArch##*-}" in \ @@ -46,7 +46,7 @@ RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 1.22.22 +ENV YARN_VERSION=1.22.22 RUN set -ex \ # use pre-existing gpg directory, see https://github.com/nodejs/docker-node/pull/1895#issuecomment-1550389150 diff --git a/Dockerfile-alpine.template b/Dockerfile-alpine.template index 832f637cc0..6aef5bcf81 100644 --- a/Dockerfile-alpine.template +++ b/Dockerfile-alpine.template @@ -1,6 +1,6 @@ FROM alpine:0.0 -ENV NODE_VERSION 0.0.0 +ENV NODE_VERSION=0.0.0 RUN addgroup -g 1000 node \ && adduser -u 1000 -G node -s /bin/sh -D node \ @@ -71,7 +71,7 @@ RUN addgroup -g 1000 node \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 0.0.0 +ENV YARN_VERSION=0.0.0 RUN apk add --no-cache --virtual .build-deps-yarn curl gnupg tar \ # use pre-existing gpg directory, see https://github.com/nodejs/docker-node/pull/1895#issuecomment-1550389150 diff --git a/Dockerfile-debian.template b/Dockerfile-debian.template index 8dac02f898..411f949961 100644 --- a/Dockerfile-debian.template +++ b/Dockerfile-debian.template @@ -3,7 +3,7 @@ FROM buildpack-deps:name RUN groupadd --gid 1000 node \ && useradd --uid 1000 --gid node --shell /bin/bash --create-home node -ENV NODE_VERSION 0.0.0 +ENV NODE_VERSION=0.0.0 RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && case "${dpkgArch##*-}" in \ @@ -39,7 +39,7 @@ RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 0.0.0 +ENV YARN_VERSION=0.0.0 RUN set -ex \ # use pre-existing gpg directory, see https://github.com/nodejs/docker-node/pull/1895#issuecomment-1550389150 diff --git a/Dockerfile-slim.template b/Dockerfile-slim.template index 0fe02e764d..2abec536cd 100644 --- a/Dockerfile-slim.template +++ b/Dockerfile-slim.template @@ -3,7 +3,7 @@ FROM debian:name-slim RUN groupadd --gid 1000 node \ && useradd --uid 1000 --gid node --shell /bin/bash --create-home node -ENV NODE_VERSION 0.0.0 +ENV NODE_VERSION=0.0.0 RUN ARCH= OPENSSL_ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && case "${dpkgArch##*-}" in \ @@ -53,7 +53,7 @@ RUN ARCH= OPENSSL_ARCH= && dpkgArch="$(dpkg --print-architecture)" \ && npm --version \ && rm -rf /tmp/* -ENV YARN_VERSION 0.0.0 +ENV YARN_VERSION=0.0.0 RUN set -ex \ && savedAptMark="$(apt-mark showmanual)" \ diff --git a/README.md b/README.md index c53d76b359..dfaf1abb46 100644 --- a/README.md +++ b/README.md @@ -121,7 +121,7 @@ simply use `ENV` to override `NPM_CONFIG_LOGLEVEL`. ```dockerfile FROM node -ENV NPM_CONFIG_LOGLEVEL info +ENV NPM_CONFIG_LOGLEVEL=info ... ``` diff --git a/docs/BestPractices.md b/docs/BestPractices.md index ad6dcc4e92..293df8af35 100644 --- a/docs/BestPractices.md +++ b/docs/BestPractices.md @@ -51,7 +51,7 @@ If you need to upgrade/downgrade `yarn` for a local install, you can do so by is ```Dockerfile FROM node:6 -ENV YARN_VERSION 1.16.0 +ENV YARN_VERSION=1.16.0 RUN yarn policies set-version $YARN_VERSION ``` @@ -61,7 +61,7 @@ RUN yarn policies set-version $YARN_VERSION ```Dockerfile FROM node:6 -ENV YARN_VERSION 1.16.0 +ENV YARN_VERSION=1.16.0 RUN curl -fSLO --compressed "https://yarnpkg.com/downloads/$YARN_VERSION/yarn-v$YARN_VERSION.tar.gz" \ && tar -xzf yarn-v$YARN_VERSION.tar.gz -C /opt/ \ @@ -75,7 +75,7 @@ If you're using an Alpine-based image, `curl` won't be present, so you'll need t ```Dockerfile FROM node:6-alpine -ENV YARN_VERSION 1.5.1 +ENV YARN_VERSION=1.5.1 RUN apk add --no-cache --virtual .build-deps-yarn curl \ && curl -fSLO --compressed "https://yarnpkg.com/downloads/$YARN_VERSION/yarn-v$YARN_VERSION.tar.gz" \ diff --git a/functions.sh b/functions.sh index 7c927cc081..444dc2f679 100755 --- a/functions.sh +++ b/functions.sh @@ -239,7 +239,7 @@ function get_full_version() { default_dockerfile="${version}/Dockerfile" fi - grep -m1 'ENV NODE_VERSION ' "${default_dockerfile}" | cut -d' ' -f3 + grep -m1 'ENV NODE_VERSION=' "${default_dockerfile}" | cut -d= -f2 } function get_major_minor_version() { diff --git a/genMatrix.js b/genMatrix.js index 9f57ea5096..1d592cca37 100644 --- a/genMatrix.js +++ b/genMatrix.js @@ -53,7 +53,7 @@ const getAffectedDockerfiles = (filesAdded, filesModified, filesRenamed) => { }; const getFullNodeVersionFromDockerfile = (file) => fs.readFileSync(file, 'utf8') - .match(/^ENV NODE_VERSION (\d*\.*\d*\.\d*)/m)[1]; + .match(/^ENV NODE_VERSION=(\d*\.*\d*\.\d*)/m)[1]; const getDockerfileMatrixEntry = (file) => { const [variant] = path.dirname(file).split(path.sep).slice(-1); diff --git a/stackbrew.js b/stackbrew.js index 58bec1daaf..77fa8b08a2 100755 --- a/stackbrew.js +++ b/stackbrew.js @@ -54,7 +54,7 @@ for (version of versions) { // Get full version from the first Dockerfile if (!fullversion) { let dockerfile = fs.readFileSync(dockerfilePath, 'utf-8') - fullversion = dockerfile.match(/ENV NODE_VERSION (?\d+)\.(?\d+)\.(?\d+)/) + fullversion = dockerfile.match(/ENV NODE_VERSION=(?\d+)\.(?\d+)\.(?\d+)/) } let tags = [ `${fullversion.groups.major}.${fullversion.groups.minor}.${fullversion.groups.patch}-${variant}`, diff --git a/update.sh b/update.sh index 88dcec1155..c30b6b3088 100755 --- a/update.sh +++ b/update.sh @@ -132,7 +132,7 @@ function update_node_version() { nodeVersion="${version}.${fullVersion:-0}" sed -Ei -e 's/^FROM (.*)/FROM '"$fromprefix"'\1/' "${dockerfile}-tmp" - sed -Ei -e 's/^(ENV NODE_VERSION ).*/\1'"${nodeVersion}"'/' "${dockerfile}-tmp" + sed -Ei -e 's/^(ENV NODE_VERSION)=.*/\1='"${nodeVersion}"'/' "${dockerfile}-tmp" # shellcheck disable=SC1004 new_line=' \\\ @@ -169,7 +169,7 @@ function update_node_version() { echo "${dockerfile} is already up to date!" else if [ "${SKIP}" != true ]; then - sed -Ei -e 's/^(ENV YARN_VERSION ).*/\1'"${yarnVersion}"'/' "${dockerfile}-tmp" + sed -Ei -e 's/^(ENV YARN_VERSION)=.*/\1='"${yarnVersion}"'/' "${dockerfile}-tmp" fi echo "${dockerfile} updated!" fi