Skip to content

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Jul 15, 2015

No description provided.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_unrefActive is throwing off the following formatting

@cjihrig
Copy link
Contributor

cjihrig commented Jul 15, 2015

LGTM with a couple comments

@rvagg rvagg force-pushed the tsc-minutes-2015-07-08 branch from cc4b6de to 1221111 Compare July 15, 2015 12:59
@mscdex mscdex added the doc Issues and PRs related to the documentations. label Jul 15, 2015
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Trever/Trevor/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@bnoordhuis
Copy link
Member

LGTM with nit.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does it has a - at the end?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@rvagg rvagg force-pushed the tsc-minutes-2015-07-08 branch from 1221111 to e147365 Compare July 16, 2015 11:25
rvagg added a commit that referenced this pull request Jul 16, 2015
PR-URL: #2184
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
@rvagg rvagg closed this Jul 16, 2015
@rvagg rvagg force-pushed the tsc-minutes-2015-07-08 branch from e147365 to 6c3aabf Compare July 16, 2015 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants