percent-encoded target test

Author: guybedford

doc/api/errors.md

@@ -2787,4 +2787,4 @@ such as `process.stdout.on('data')`.
 [vm]: vm.html
 [self-reference a package using its name]: esm.html#esm_self_referencing_a_package_using_its_name
 [define a custom subpath]: esm.html#esm_subpath_exports
-["imports" field]: esm.html#internal_package_imports
+["imports" field]: esm.html#esm_internal_package_imports

lib/internal/modules/cjs/loader.js

@@ -574,8 +574,8 @@ function resolveExportsTarget(baseUrl, target, subpath, mappingKey) {
       try {
         return fileURLToPath(resolved);
       } catch (err) {
-        if (err.code === 'ERR_INVALID_FILE_URL_PATH' &&
-            StringPrototypeIncludes(err.message, 'must not include encoded "/" characters')) {
+        if (err.code === 'ERR_INVALID_FILE_URL_PATH' && StringPrototypeIncludes(
+          err.message, 'must not include encoded "/" characters')) {
           throw new ERR_INVALID_MODULE_SPECIFIER(
             resolved.pathname, 'must not include encoded "/" characters',
             fileURLToPath(baseUrl));

test/es-module/test-esm-imports.mjs

@@ -58,6 +58,8 @@ const { requireImport, importImport } = importer;
     ['#', '#'],
     // Initial slash target must have a leading name
     ['#/initialslash', '#/initialslash'],
+    // Percent-encoded target paths
+    ['#percent', 'must not include encoded "/"'],
   ]);
 
   for (const [specifier, expected] of invalidImportSpecifiers) {
@@ -81,7 +83,6 @@ const { requireImport, importImport } = importer;
 
   for (const specifier of undefinedImports) {
     loadFixture(specifier).catch(mustCall((err) => {
-      console.log(err);
       strictEqual(err.code, 'ERR_PACKAGE_IMPORT_NOT_DEFINED');
       assertStartsWith(err.message, 'Package import ');
       assertIncludes(err.message, specifier);

test/fixtures/es-modules/pkgimports/package.json

@@ -24,6 +24,7 @@
     "#subpath/nullshadow/": [null],
     "#": "./test.js",
     "#/initialslash": "./test.js",
-    "#notfound": "./notfound.js"
+    "#notfound": "./notfound.js",
+    "#percent": "./..%2F/x.js"
   }
 }